mirror of
https://github.com/espressif/binutils-gdb.git
synced 2025-12-19 01:19:41 +08:00
c6115b5eac
With test-case gdb.base/maint.exp, I ran into: ... (gdb) file maint^M Reading symbols from maint...^M (gdb) mt set per-command on^M (gdb) Time for "DWARF indexing worker": ...^M Time for "DWARF indexing worker": ...^M Time for "DWARF indexing worker": ...^M Time for "DWARF indexing worker": ...^M Time for "DWARF skeletonless type units": ...^M Time for "DWARF add parent map": ...^M Time for "DWARF finalize worker": ...^M Time for "DWARF finalize worker": ...^M Time for "DWARF finalize worker": ...^M Time for "DWARF finalize worker": ...^M Time for "DWARF finalize worker": ...^M FAIL: $exp: warnings: per-command: mt set per-command on (timeout) mt set per-command off^M 2025-05-31 09:33:44.711 - command started^M (gdb) PASS: $exp: warnings: per-command: mt set per-command off ... I didn't manage to reproduce this by rerunning the test-case, but it's fairly easy to reproduce using a file with more debug info, for instance gdb: ... $ gdb -q -batch -ex "file build/gdb/gdb" -ex "mt set per-command on" ... Due to the default "mt dwarf synchronous" == off, the file command starts building the cooked index in the background, and returns immediately without waiting for the result. The subsequent "mt set per-command on" implies "mt set per-command time on", which switches on displaying of per-command execution time. The "Time for" lines are the result of those two commands, but these lines shouldn't be there because "mt per-command time" == off at the point of issuing the file command. Fix this by capturing the per_command_time variable, and using the captured value instead. Tested on x86_64-linux. Approved-By: Simon Marchi <simon.marchi@efficios.com> PR cli/33039 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33039
108 lines
3.1 KiB
C++
108 lines
3.1 KiB
C++
/* Support for GDB maintenance commands.
|
|
Copyright (C) 2013-2025 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef GDB_MAINT_H
|
|
#define GDB_MAINT_H
|
|
|
|
#include "gdbsupport/run-time-clock.h"
|
|
#include <chrono>
|
|
|
|
struct obj_section;
|
|
struct objfile;
|
|
|
|
extern void set_per_command_time (int);
|
|
|
|
extern void set_per_command_space (int);
|
|
|
|
/* Update the thread pool for the desired number of threads. */
|
|
|
|
extern void update_thread_pool_size ();
|
|
|
|
/* Records a run time and space usage to be used as a base for
|
|
reporting elapsed time or change in space. */
|
|
|
|
class scoped_command_stats
|
|
{
|
|
public:
|
|
|
|
explicit scoped_command_stats (bool msg_type);
|
|
~scoped_command_stats ();
|
|
|
|
private:
|
|
|
|
DISABLE_COPY_AND_ASSIGN (scoped_command_stats);
|
|
|
|
/* Print the time, along with a string. */
|
|
void print_time (const char *msg);
|
|
|
|
/* Zero if the saved time is from the beginning of GDB execution.
|
|
One if from the beginning of an individual command execution. */
|
|
bool m_msg_type;
|
|
/* Track whether the stat was enabled at the start of the command
|
|
so that we can avoid printing anything if it gets turned on by
|
|
the current command. */
|
|
bool m_time_enabled : 1;
|
|
bool m_space_enabled : 1;
|
|
bool m_symtab_enabled : 1;
|
|
run_time_clock::time_point m_start_cpu_time;
|
|
std::chrono::steady_clock::time_point m_start_wall_time;
|
|
long m_start_space;
|
|
/* Total number of symtabs (over all objfiles). */
|
|
int m_start_nr_symtabs;
|
|
/* A count of the compunits. */
|
|
int m_start_nr_compunit_symtabs;
|
|
/* Total number of blocks. */
|
|
int m_start_nr_blocks;
|
|
};
|
|
|
|
/* If true, display time usage both at startup and for each command. */
|
|
|
|
extern bool per_command_time;
|
|
|
|
/* RAII structure used to measure the time spent by the current thread in a
|
|
given scope. */
|
|
|
|
struct scoped_time_it
|
|
{
|
|
/* WHAT is the prefix to show when the summary line is printed. */
|
|
scoped_time_it (const char *what, bool enabled = per_command_time);
|
|
|
|
DISABLE_COPY_AND_ASSIGN (scoped_time_it);
|
|
~scoped_time_it ();
|
|
|
|
private:
|
|
bool m_enabled;
|
|
|
|
/* Summary line prefix. */
|
|
const char *m_what;
|
|
|
|
/* User time at the start of execution. */
|
|
user_cpu_time_clock::time_point m_start_user;
|
|
|
|
/* System time at the start of execution. */
|
|
system_cpu_time_clock::time_point m_start_sys;
|
|
|
|
/* Wall-clock time at the start of execution. */
|
|
std::chrono::steady_clock::time_point m_start_wall;
|
|
};
|
|
|
|
extern obj_section *maint_obj_section_from_bfd_section (bfd *abfd,
|
|
asection *asection,
|
|
objfile *ofile);
|
|
#endif /* GDB_MAINT_H */
|