mirror of
https://github.com/espressif/binutils-gdb.git
synced 2025-09-10 23:35:43 +08:00
30970df7d5
Clang 6 shows this warning
In file included from /home/emaisin/src/binutils-gdb/gdb/common/selftest.c:19:
In file included from /home/emaisin/src/binutils-gdb/gdb/common/common-defs.h:92:
In file included from /home/emaisin/src/binutils-gdb/gdb/common/gdb_unique_ptr.h:23:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/memory:81:
/usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/unique_ptr.h:76:2: error: delete called on 'selftests::selftest' that is abstract but has non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
delete __ptr;
^
/usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/unique_ptr.h:236:4: note: in instantiation of member function 'std::default_delete<selftests::selftest>::operator()' requested here
get_deleter()(__ptr);
^
/home/emaisin/src/binutils-gdb/gdb/common/selftest.c:57:17: note: in instantiation of member function 'std::unique_ptr<selftests::selftest, std::default_delete<selftests::selftest> >::~unique_ptr' requested here
tests[name] = std::unique_ptr<selftest> (test);
^
The error is legitimate, we (the unique_ptr) are deleting selftest
objects through the base pointer, so technically the destructor should
be virtual, so that the destructor of the subclass is invoked.
gdb/ChangeLog:
* common/selftest.h (struct selftest): Add virtual destructor.
74 lines
2.1 KiB
C++
74 lines
2.1 KiB
C++
/* GDB self-testing.
|
|
Copyright (C) 2016-2017 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef SELFTEST_H
|
|
#define SELFTEST_H
|
|
|
|
/* A test is just a function that does some checks and throws an
|
|
exception if something has gone wrong. */
|
|
|
|
typedef void self_test_function (void);
|
|
|
|
namespace selftests
|
|
{
|
|
|
|
/* Interface for the various kinds of selftests. */
|
|
|
|
struct selftest
|
|
{
|
|
virtual ~selftest () = default;
|
|
virtual void operator() () const = 0;
|
|
};
|
|
|
|
/* Register a new self-test. */
|
|
|
|
extern void register_test (const std::string &name, selftest *test);
|
|
|
|
/* Register a new self-test. */
|
|
|
|
extern void register_test (const std::string &name,
|
|
self_test_function *function);
|
|
|
|
/* Run all the self tests. This print a message describing the number
|
|
of test and the number of failures.
|
|
|
|
If FILTER is not NULL and not empty, only tests with names containing FILTER
|
|
will be ran. */
|
|
|
|
extern void run_tests (const char *filter);
|
|
|
|
/* Reset GDB or GDBserver's internal state. */
|
|
extern void reset ();
|
|
|
|
typedef void for_each_selftest_ftype (const std::string &name);
|
|
|
|
/* Call FUNC for each registered selftest. */
|
|
|
|
extern void for_each_selftest (for_each_selftest_ftype func);
|
|
}
|
|
|
|
/* Check that VALUE is true, and, if not, throw an exception. */
|
|
|
|
#define SELF_CHECK(VALUE) \
|
|
do { \
|
|
if (!(VALUE)) \
|
|
error (_("self-test failed at %s:%d"), __FILE__, __LINE__); \
|
|
} while (0)
|
|
|
|
#endif /* SELFTEST_H */
|