mirror of
https://github.com/espressif/binutils-gdb.git
synced 2025-08-06 06:45:56 +08:00
a0486bac41
- Use of nonportable <endian.h> - Use of qsort_r - Use of zlib without appropriate magic to pull in the binutils zlib - Use of off64_t without checking (fixed by dropping the unused fields that need off64_t entirely) - signedness problems due to long being too short a type on 32-bit platforms: ctf_id_t is now 'unsigned long', and CTF_ERR must be used only for functions that return ctf_id_t - One lingering use of bzero() and of <sys/errno.h> All fixed, using code from gnulib where possible. Relatedly, set cts_size in a couple of places it was missed (string table and symbol table loading upon ctf_bfdopen()). binutils/ * objdump.c (make_ctfsect): Drop cts_type, cts_flags, and cts_offset. * readelf.c (shdr_to_ctf_sect): Likewise. include/ * ctf-api.h (ctf_sect_t): Drop cts_type, cts_flags, and cts_offset. (ctf_id_t): This is now an unsigned type. (CTF_ERR): Cast it to ctf_id_t. Note that it should only be used for ctf_id_t-returning functions. libctf/ * Makefile.am (ZLIB): New. (ZLIBINC): Likewise. (AM_CFLAGS): Use them. (libctf_a_LIBADD): New, for LIBOBJS. * configure.ac: Check for zlib, endian.h, and qsort_r. * ctf-endian.h: New, providing htole64 and le64toh. * swap.h: Code style fixes. (bswap_identity_64): New. * qsort_r.c: New, from gnulib (with one added #include). * ctf-decls.h: New, providing a conditional qsort_r declaration, and unconditional definitions of MIN and MAX. * ctf-impl.h: Use it. Do not use <sys/errno.h>. (ctf_set_errno): Now returns unsigned long. * ctf-util.c (ctf_set_errno): Adjust here too. * ctf-archive.c: Use ctf-endian.h. (ctf_arc_open_by_offset): Use memset, not bzero. Drop cts_type, cts_flags and cts_offset. (ctf_arc_write): Drop debugging dependent on the size of off_t. * ctf-create.c: Provide a definition of roundup if not defined. (ctf_create): Drop cts_type, cts_flags and cts_offset. (ctf_add_reftype): Do not check if type IDs are below zero. (ctf_add_slice): Likewise. (ctf_add_typedef): Likewise. (ctf_add_member_offset): Cast error-returning ssize_t's to size_t when known error-free. Drop CTF_ERR usage for functions returning int. (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning int. (ctf_add_variable): Likewise. (enumcmp): Likewise. (enumadd): Likewise. (membcmp): Likewise. (ctf_add_type): Likewise. Cast error-returning ssize_t's to size_t when known error-free. * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions returning int: use CTF_ERR for functions returning ctf_type_id. (ctf_dump_label): Likewise. (ctf_dump_objts): Likewise. * ctf-labels.c (ctf_label_topmost): Likewise. (ctf_label_iter): Likewise. (ctf_label_info): Likewise. * ctf-lookup.c (ctf_func_args): Likewise. * ctf-open.c (upgrade_types): Cast to size_t where appropriate. (ctf_bufopen): Likewise. Use zlib types as needed. * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions returning int. (ctf_enum_iter): Likewise. (ctf_type_size): Likewise. (ctf_type_align): Likewise. Cast to size_t where appropriate. (ctf_type_kind_unsliced): Likewise. (ctf_type_kind): Likewise. (ctf_type_encoding): Likewise. (ctf_member_info): Likewise. (ctf_array_info): Likewise. (ctf_enum_value): Likewise. (ctf_type_rvisit): Likewise. * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and cts_offset. (ctf_simple_open): Likewise. (ctf_bfdopen_ctfsect): Likewise. Set cts_size properly. * Makefile.in: Regenerate. * aclocal.m4: Likewise. * config.h: Likewise. * configure: Likewise.
185 lines
5.4 KiB
Plaintext
185 lines
5.4 KiB
Plaintext
2019-05-29 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* Makefile.am (ZLIB): New.
|
||
(ZLIBINC): Likewise.
|
||
(AM_CFLAGS): Use them.
|
||
(libctf_a_LIBADD): New, for LIBOBJS.
|
||
* configure.ac: Check for zlib, endian.h, and qsort_r.
|
||
* ctf-endian.h: New, providing htole64 and le64toh.
|
||
* swap.h: Code style fixes.
|
||
(bswap_identity_64): New.
|
||
* qsort_r.c: New, from gnulib (with one added #include).
|
||
* ctf-decls.h: New, providing a conditional qsort_r declaration,
|
||
and unconditional definitions of MIN and MAX.
|
||
* ctf-impl.h: Use it. Do not use <sys/errno.h>.
|
||
(ctf_set_errno): Now returns unsigned long.
|
||
* ctf-util.c (ctf_set_errno): Adjust here too.
|
||
* ctf-archive.c: Use ctf-endian.h.
|
||
(ctf_arc_open_by_offset): Use memset, not bzero. Drop cts_type,
|
||
cts_flags and cts_offset.
|
||
(ctf_arc_write): Drop debugging dependent on the size of off_t.
|
||
* ctf-create.c: Provide a definition of roundup if not defined.
|
||
(ctf_create): Drop cts_type, cts_flags and cts_offset.
|
||
(ctf_add_reftype): Do not check if type IDs are below zero.
|
||
(ctf_add_slice): Likewise.
|
||
(ctf_add_typedef): Likewise.
|
||
(ctf_add_member_offset): Cast error-returning ssize_t's to size_t
|
||
when known error-free. Drop CTF_ERR usage for functions returning
|
||
int.
|
||
(ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
|
||
int.
|
||
(ctf_add_variable): Likewise.
|
||
(enumcmp): Likewise.
|
||
(enumadd): Likewise.
|
||
(membcmp): Likewise.
|
||
(ctf_add_type): Likewise. Cast error-returning ssize_t's to size_t
|
||
when known error-free.
|
||
* ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
|
||
returning int: use CTF_ERR for functions returning ctf_type_id.
|
||
(ctf_dump_label): Likewise.
|
||
(ctf_dump_objts): Likewise.
|
||
* ctf-labels.c (ctf_label_topmost): Likewise.
|
||
(ctf_label_iter): Likewise.
|
||
(ctf_label_info): Likewise.
|
||
* ctf-lookup.c (ctf_func_args): Likewise.
|
||
* ctf-open.c (upgrade_types): Cast to size_t where appropriate.
|
||
(ctf_bufopen): Likewise. Use zlib types as needed.
|
||
* ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
|
||
returning int.
|
||
(ctf_enum_iter): Likewise.
|
||
(ctf_type_size): Likewise.
|
||
(ctf_type_align): Likewise. Cast to size_t where appropriate.
|
||
(ctf_type_kind_unsliced): Likewise.
|
||
(ctf_type_kind): Likewise.
|
||
(ctf_type_encoding): Likewise.
|
||
(ctf_member_info): Likewise.
|
||
(ctf_array_info): Likewise.
|
||
(ctf_enum_value): Likewise.
|
||
(ctf_type_rvisit): Likewise.
|
||
* ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
|
||
cts_offset.
|
||
(ctf_simple_open): Likewise.
|
||
(ctf_bfdopen_ctfsect): Likewise. Set cts_size properly.
|
||
* Makefile.in: Regenerate.
|
||
* aclocal.m4: Likewise.
|
||
* config.h: Likewise.
|
||
* configure: Likewise.
|
||
|
||
2019-05-28 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* configure.in: Check for bfd_section_from_elf_index.
|
||
* configure: Regenerate.
|
||
* config.h.in [HAVE_BFD_ELF]: Likewise.
|
||
* libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
|
||
abfd is potentially unused now.
|
||
|
||
2019-05-28 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* Makefile.am: New.
|
||
* Makefile.in: Regenerated.
|
||
* config.h.in: Likewise.
|
||
* aclocal.m4: Likewise.
|
||
* configure: Likewise.
|
||
|
||
2019-05-28 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-dump.c: New.
|
||
|
||
2019-05-28 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-labels.c: New.
|
||
|
||
2019-05-28 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-impl.h (_libctf_version): New declaration.
|
||
* ctf-subr.c (_libctf_version): Define it.
|
||
(ctf_version): New.
|
||
|
||
2019-05-28 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-create.c (enumcmp): New.
|
||
(enumadd): Likewise.
|
||
(membcmp): Likewise.
|
||
(membadd): Likewise.
|
||
(ctf_add_type): Likewise.
|
||
|
||
2019-05-28 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-lookup.c (isqualifier): New.
|
||
(ctf_lookup_by_name): Likewise.
|
||
(struct ctf_lookup_var_key): Likewise.
|
||
(ctf_lookup_var): Likewise.
|
||
(ctf_lookup_variable): Likewise.
|
||
(ctf_lookup_symbol_name): Likewise.
|
||
(ctf_lookup_by_symbol): Likewise.
|
||
(ctf_func_info): Likewise.
|
||
(ctf_func_args): Likewise.
|
||
|
||
2019-05-28 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-decl.c: New file.
|
||
* ctf-types.c: Likewise.
|
||
* ctf-impl.h: New declarations.
|
||
|
||
2019-05-28 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-open-bfd.c: New file.
|
||
* ctf-open.c (ctf_close): New.
|
||
* ctf-impl.h: Include bfd.h.
|
||
(ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
|
||
(ctf_archive_internal): New members ctfi_abfd, ctfi_data,
|
||
ctfi_bfd_close.
|
||
(ctf_bfdopen_ctfsect): New declaration.
|
||
(_CTF_SECTION): likewise.
|
||
|
||
2019-05-28 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-archive.c: New.
|
||
* ctf-impl.h (ctf_archive_internal): New type.
|
||
(ctf_arc_open_internal): New declaration.
|
||
(ctf_arc_bufopen): Likewise.
|
||
(ctf_arc_close_internal): Likewise.
|
||
|
||
2019-05-28 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-open.c: New file.
|
||
* swap.h: Likewise.
|
||
|
||
2019-05-28 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-create.c: New file.
|
||
* ctf-lookup.c: New file.
|
||
|
||
2019-05-28 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-impl.h: New definitions and declarations for type creation
|
||
and lookup.
|
||
|
||
2019-05-28 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-hash.c: New file.
|
||
* ctf-impl.h: New declarations.
|
||
|
||
2019-05-28 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-error.c: New file.
|
||
|
||
2019-05-28 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-util.c: New file.
|
||
* elf.h: Likewise.
|
||
* ctf-impl.h: Include it, and add declarations.
|
||
|
||
2019-05-28 Nick Alcock <nick.alcock@oracle.com>
|
||
|
||
* ctf-impl.h: New file.
|
||
* ctf-subr.c: New file.
|
||
|
||
|
||
Local Variables:
|
||
mode: change-log
|
||
left-margin: 8
|
||
fill-column: 76
|
||
version-control: never
|
||
End:
|