mirror of
https://github.com/espressif/binutils-gdb.git
synced 2025-07-28 12:24:04 +08:00
34dc0f9596
GDB reports duplicate local vars with "<optimized out>" values for
inlined functions that are compiled with Clang.
Suppose we have
__attribute__((always_inline))
static void aFunction() {
int a = 42;
if(a > 2) {
int value = a;
value += 10; /* break here */
}
}
The "info locals" command at the "break here" line gives the following
output:
...
Breakpoint 1, aFunction () at test.c:6
6 value += 10; /* break here */
(gdb) info locals
value = 42
a = 42
value = <optimized out>
(gdb)
The reason is, inlined functions that are compiled by Clang do not
contain DW_AT_abstract_origin attributes in the DW_TAG_lexical_block
entries. See
https://bugs.llvm.org/show_bug.cgi?id=49953
E.g. the DIE of the inlined function above is
0x00000087: DW_TAG_inlined_subroutine
DW_AT_abstract_origin (0x0000002a "aFunction")
DW_AT_low_pc (0x00000000004004b2)
DW_AT_high_pc (0x00000000004004d2)
DW_AT_call_file ("/tmp/test.c")
DW_AT_call_line (11)
DW_AT_call_column (0x03)
0x0000009b: DW_TAG_variable
DW_AT_location (DW_OP_fbreg -4)
DW_AT_abstract_origin (0x00000032 "a")
0x000000a3: DW_TAG_lexical_block
DW_AT_low_pc (0x00000000004004c3)
DW_AT_high_pc (0x00000000004004d2)
0x000000b0: DW_TAG_variable
DW_AT_location (DW_OP_fbreg -8)
DW_AT_abstract_origin (0x0000003e "value")
This causes GDB to fail matching the concrete lexical scope with the
corresponding abstract entry. Hence, the local vars of the abstract
function that are contained in the lexical scope are read separately
(and thus, in addition to) the local vars of the concrete scope.
Because the abstract definitions of the vars do not contain location
information, we see the extra 'value = <optimized out>' above.
This bug is highly related to PR gdb/25695, but the root cause is not
exactly the same. In PR gdb/25695, GCC emits an extra
DW_TAG_lexical_block without an DW_AT_abstract_origin that wraps the
body of the inlined function. That is, the trees of the abstract DIE
for the function and its concrete instance are structurally not the
same. In the case of using Clang, the trees have the same structure.
To tackle the Clang case, when traversing the children of the concrete
instance root, keep a reference to the child of the abstract DIE that
corresponds to the concrete child, so that we can match the two DIEs
heuristically in case of missing DW_AT_abstract_origin attributes.
The updated gdb.opt/inline-locals.exp test has been checked with GCC
5-10 and Clang 5-11.
gdb/ChangeLog:
2021-04-14 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
* dwarf2/read.c (inherit_abstract_dies): Keep a reference to the
corresponding child of the abstract DIE when iterating the
children of the concrete DIE.
gdb/testsuite/ChangeLog:
2021-04-14 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
* gdb.opt/inline-locals.c (scoped): New function.
(main): Call 'scoped'.
* gdb.opt/inline-locals.exp: Update with "info locals" tests
for scoped variables.
* gdb.dwarf2/dw2-inline-with-lexical-scope.c: New file.
* gdb.dwarf2/dw2-inline-with-lexical-scope.exp: New file.
92 lines
1.7 KiB
C
92 lines
1.7 KiB
C
/* Copyright (C) 2008-2021 Free Software Foundation, Inc.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
/* This is only ever run if it is compiled with a new-enough GCC, but
|
|
we don't want the compilation to fail if compiled by some other
|
|
compiler. */
|
|
#ifdef __GNUC__
|
|
#define ATTR __attribute__((always_inline))
|
|
#else
|
|
#define ATTR
|
|
#endif
|
|
|
|
int x, y;
|
|
volatile int z = 0;
|
|
volatile int result;
|
|
volatile int *array_p;
|
|
|
|
void bar(void);
|
|
|
|
void
|
|
init_array (int *array, int n)
|
|
{
|
|
int i;
|
|
for (i = 0; i < n; ++i)
|
|
array[i] = 0;
|
|
}
|
|
|
|
inline ATTR int func1(int arg1)
|
|
{
|
|
int array[64];
|
|
init_array (array, 64);
|
|
array_p = array;
|
|
array[0] = result;
|
|
array[1] = arg1;
|
|
bar ();
|
|
return x * y + array_p[0] * arg1;
|
|
}
|
|
|
|
inline ATTR int func2(int arg2)
|
|
{
|
|
return x * func1 (arg2);
|
|
}
|
|
|
|
inline ATTR
|
|
void
|
|
scoped (int s)
|
|
{
|
|
int loc1 = 10;
|
|
if (s > 0)
|
|
{
|
|
int loc2 = 20;
|
|
s++; /* bp for locals 1 */
|
|
if (s > 1)
|
|
{
|
|
int loc3 = 30;
|
|
s++; /* bp for locals 2 */
|
|
}
|
|
}
|
|
s++; /* bp for locals 3 */
|
|
}
|
|
|
|
int main (void)
|
|
{
|
|
int val;
|
|
|
|
x = 7;
|
|
y = 8;
|
|
bar ();
|
|
|
|
val = func1 (result);
|
|
result = val;
|
|
|
|
val = func2 (result);
|
|
result = val;
|
|
|
|
scoped (40);
|
|
|
|
return 0;
|
|
}
|