Tom Tromey 15ce8941e7 Sign-extend non-bit-fields in unpack_bits_as_long ...

unpack_bits_as_long is documented as sign-extending its result when
the type is signed.  However, it was only doing sign-extension in the
case where the field was a bitfield -- that is, not when the "bitsize"
parameter was 0, indicating the size should be taken from the type.

Also, unpack_bits_as_long was incorrectly computing the shift for
big-endian architectures for the non-bitfield case.

This patch fixes these bugs in a straightforward way.  A new selftest
is included.

2018-02-26  Tom Tromey  <tom@tromey.com>

	* Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
	unittests/unpack-selftests.c.
	* unittests/unpack-selftests.c: New file.
	* value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.

2018-02-26 09:21:08 -07:00

..

optional

Update copyright year range in all GDB files

2018-01-02 07:38:06 +04:00

array-view-selftests.c

Update copyright year range in all GDB files

2018-01-02 07:38:06 +04:00

common-utils-selftests.c

Update copyright year range in all GDB files

2018-01-02 07:38:06 +04:00

environ-selftests.c

Update copyright year range in all GDB files

2018-01-02 07:38:06 +04:00

function-view-selftests.c

Update copyright year range in all GDB files

2018-01-02 07:38:06 +04:00

lookup_name_info-selftests.c

Update copyright year range in all GDB files

2018-01-02 07:38:06 +04:00

memory-map-selftests.c

Update copyright year range in all GDB files

2018-01-02 07:38:06 +04:00

memrange-selftests.c

Update copyright year range in all GDB files

2018-01-02 07:38:06 +04:00

offset-type-selftests.c

Update copyright year range in all GDB files

2018-01-02 07:38:06 +04:00

optional-selftests.c

Update copyright year range in all GDB files

2018-01-02 07:38:06 +04:00

ptid-selftests.c

Update copyright year range in all GDB files

2018-01-02 07:38:06 +04:00

rsp-low-selftests.c

Update copyright year range in all GDB files

2018-01-02 07:38:06 +04:00

scoped_fd-selftests.c

common: add scoped_fd

2018-02-09 14:03:18 +01:00

scoped_mmap-selftests.c

common: add scoped_mmap

2018-02-09 14:03:19 +01:00

scoped_restore-selftests.c

Update copyright year range in all GDB files

2018-01-02 07:38:06 +04:00

unpack-selftests.c

Sign-extend non-bit-fields in unpack_bits_as_long

2018-02-26 09:21:08 -07:00

xml-utils-selftests.c

Update copyright year range in all GDB files

2018-01-02 07:38:06 +04:00