mirror of
https://github.com/espressif/binutils-gdb.git
synced 2025-06-25 13:27:26 +08:00
6cade9185c
When introducing this code, I forgot that we had some macros for this.
Replace some "manual" pragma diagnostic with some DIAGNOSTIC_* macros,
provided by include/diagnostics.h.
In diagnostics.h:
- Add DIAGNOSTIC_ERROR, to enable a diagnostic at error level.
- Add DIAGNOSTIC_ERROR_SWITCH, to enable -Wswitch at error level, for
both gcc and clang.
Additionally, using DIAGNOSTIC_PUSH, DIAGNOSTIC_ERROR_SWITCH and
DIAGNOSTIC_POP seems to misbehave with g++ 4.8, where we see these
errors:
CXX ada-tasks.o
/home/smarchi/src/binutils-gdb/gdb/ada-tasks.c: In function void read_known_tasks():
/home/smarchi/src/binutils-gdb/gdb/ada-tasks.c:998:10: error: enumeration value ADA_TASKS_UNKNOWN not handled in switch [-Werror=switch]
switch (data->known_tasks_kind)
^
Because of the POP, the diagnostic should go back to being disabled,
since it was disabled in the beginning, but that's not what we see
here. Versions of GCC >= 5 compile correctly.
Work around this by making DIAGNOSTIC_ERROR_SWITCH a no-op for GCC < 5.
Note that this code (already as it exists in master today) enables
-Wswitch at the error level even if --disable-werror is passed. It
shouldn't be a problem, as it's not like a new enumerator will appear
out of nowhere and cause a build error if building with future
compilers. Still, for correctness, we would ideally want to ask the
compiler to enable -Wswitch at its default level (as if the user had
passed -Wswitch on the command-line). There doesn't seem to be a way to
do this.
Change-Id: Id33ebec3de39bd449409ea0bab59831289ffe82d
71 lines
2.2 KiB
C
71 lines
2.2 KiB
C
/* Target waitstatus implementations.
|
|
|
|
Copyright (C) 1990-2021 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "gdbsupport/common-defs.h"
|
|
#include "waitstatus.h"
|
|
|
|
/* See waitstatus.h. */
|
|
|
|
std::string
|
|
target_waitstatus::to_string () const
|
|
{
|
|
std::string str = string_printf
|
|
("status->kind = %s", target_waitkind_str (this->kind ()));
|
|
|
|
/* Make sure the compiler warns if a new TARGET_WAITKIND enumerator is added
|
|
but not handled here. */
|
|
DIAGNOSTIC_PUSH
|
|
DIAGNOSTIC_ERROR_SWITCH
|
|
switch (this->kind ())
|
|
{
|
|
case TARGET_WAITKIND_EXITED:
|
|
case TARGET_WAITKIND_THREAD_EXITED:
|
|
return string_appendf (str, ", exit_status = %d", this->exit_status ());
|
|
|
|
case TARGET_WAITKIND_STOPPED:
|
|
case TARGET_WAITKIND_SIGNALLED:
|
|
return string_appendf (str, ", sig = %s",
|
|
gdb_signal_to_symbol_string (this->sig ()));
|
|
|
|
case TARGET_WAITKIND_FORKED:
|
|
case TARGET_WAITKIND_VFORKED:
|
|
return string_appendf (str, ", child_ptid = %s",
|
|
this->child_ptid ().to_string ().c_str ());
|
|
|
|
case TARGET_WAITKIND_EXECD:
|
|
return string_appendf (str, ", execd_pathname = %s",
|
|
this->execd_pathname ());
|
|
|
|
case TARGET_WAITKIND_LOADED:
|
|
case TARGET_WAITKIND_VFORK_DONE:
|
|
case TARGET_WAITKIND_SPURIOUS:
|
|
case TARGET_WAITKIND_SYSCALL_ENTRY:
|
|
case TARGET_WAITKIND_SYSCALL_RETURN:
|
|
case TARGET_WAITKIND_IGNORE:
|
|
case TARGET_WAITKIND_NO_HISTORY:
|
|
case TARGET_WAITKIND_NO_RESUMED:
|
|
case TARGET_WAITKIND_THREAD_CREATED:
|
|
return str;
|
|
}
|
|
DIAGNOSTIC_POP
|
|
|
|
gdb_assert_not_reached ("invalid target_waitkind value: %d",
|
|
(int) this->kind ());
|
|
}
|