mirror of
https://github.com/espressif/binutils-gdb.git
synced 2025-12-19 01:19:41 +08:00
3bd0f5c4d9
With test-case gdb.dwarf2/dw2-lines.exp on arm-linux, I run into:
...
(gdb) break bar_label^M
Breakpoint 2 at 0x4004f6: file dw2-lines.c, line 29.^M
(gdb) continue^M
Continuing.^M
^M
Breakpoint 2, bar () at dw2-lines.c:29^M
29 foo (2);^M
(gdb) PASS: $exp: cv=2: cdw=32: lv=2: ldw=32: continue to breakpoint: foo \(1\)
...
The pass is incorrect because the continue lands at line 29 with "foo (2)"
instead of line line 27 with "foo (1)".
A minimal version is:
...
$ gdb -q -batch dw2-lines.cv-2-cdw-32-lv-2-ldw-32 -ex "b bar_label"
Breakpoint 1 at 0x4f6: file dw2-lines.c, line 29.
...
where:
...
000004ec <bar>:
4ec: b580 push {r7, lr}
4ee: af00 add r7, sp, #0
000004f0 <bar_label>:
4f0: 2001 movs r0, #1
4f2: f7ff fff1 bl 4d8 <foo>
000004f6 <bar_label_2>:
4f6: 2002 movs r0, #2
4f8: f7ff ffee bl 4d8 <foo>
...
So, how does this happen? In short:
- skip_prologue_sal calls arm_skip_prologue with pc == 0x4ec,
- thumb_analyze_prologue returns 0x4f2
(overshooting by 1 insn, PR tdep/31981), and
- skip_prologue_sal decides that we're mid-line, and updates to 0x4f6.
However, this is a test-case about .debug_line info, so why didn't arm_skip_prologue
use the line info to skip the prologue?
The answer is that the line info starts at bar_label, not at bar.
Fixing that allows us to work around PR tdep/31981.
Likewise in gdb.dwarf2/dw2-line-number-zero.exp.
Instead, add a new test-case gdb.arch/skip-prologue.exp that is dedicated to
checking quality of architecture-specific prologue analysis, without being
written in an architecture-specific way.
If fails on arm-linux for both marm and mthumb:
...
FAIL: gdb.arch/skip-prologue.exp: f2: $bp_addr == $prologue_end_addr (skipped too much)
FAIL: gdb.arch/skip-prologue.exp: f4: $bp_addr == $prologue_end_addr (skipped too much)
...
and passes for:
- x86_64-linux for {m64,m32}x{-fno-PIE/-no-pie,-fPIE/-pie}
- aarch64-linux.
Tested on arm-linux.
143 lines
3.1 KiB
Plaintext
143 lines
3.1 KiB
Plaintext
# Copyright 2020-2024 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
load_lib dwarf.exp
|
|
|
|
# This test can only be run on targets which support DWARF-2 and use gas.
|
|
require dwarf2_support
|
|
|
|
# The .c files use __attribute__.
|
|
require is_c_compiler_gcc
|
|
|
|
standard_testfile .c -dw.S
|
|
|
|
set asm_file [standard_output_file $srcfile2]
|
|
Dwarf::assemble $asm_file {
|
|
declare_labels Llines
|
|
global srcdir subdir srcfile
|
|
|
|
get_func_info bar1
|
|
get_func_info bar2
|
|
|
|
cu {} {
|
|
compile_unit {
|
|
{language @DW_LANG_C}
|
|
{name dw2-line-number-zero.c}
|
|
{stmt_list $Llines DW_FORM_sec_offset}
|
|
} {
|
|
subprogram {
|
|
{external 1 flag}
|
|
{MACRO_AT_func {main}}
|
|
}
|
|
subprogram {
|
|
{external 1 flag}
|
|
{MACRO_AT_func {bar1}}
|
|
}
|
|
subprogram {
|
|
{external 1 flag}
|
|
{MACRO_AT_func {bar2}}
|
|
}
|
|
}
|
|
}
|
|
|
|
lines {version 2} Llines {
|
|
include_dir "${srcdir}/${subdir}"
|
|
file_name "$srcfile" 1
|
|
|
|
program {
|
|
DW_LNE_set_address $bar1_start
|
|
line 25
|
|
DW_LNS_copy
|
|
|
|
DW_LNE_set_address bar1_label
|
|
line 27
|
|
DW_LNS_copy
|
|
|
|
DW_LNE_set_address bar1_label_2
|
|
line 29
|
|
DW_LNS_copy
|
|
|
|
DW_LNE_set_address bar1_label_3
|
|
line 0
|
|
DW_LNS_copy
|
|
|
|
DW_LNE_set_address bar1_label_4
|
|
line 33
|
|
DW_LNS_copy
|
|
|
|
DW_LNE_set_address $bar1_end
|
|
DW_LNE_end_sequence
|
|
|
|
|
|
DW_LNE_set_address $bar2_start
|
|
line 39
|
|
DW_LNS_copy
|
|
|
|
DW_LNE_set_address bar2_label
|
|
line 41
|
|
DW_LNS_copy
|
|
|
|
DW_LNE_set_address bar2_label_2
|
|
line 43
|
|
DW_LNS_copy
|
|
|
|
DW_LNE_set_address bar2_label_3
|
|
line 0
|
|
DW_LNS_negate_stmt
|
|
DW_LNS_copy
|
|
DW_LNS_negate_stmt
|
|
|
|
DW_LNE_set_address bar2_label_4
|
|
line 47
|
|
DW_LNS_copy
|
|
|
|
DW_LNE_set_address $bar2_end
|
|
DW_LNE_end_sequence
|
|
}
|
|
}
|
|
}
|
|
|
|
if { [prepare_for_testing "failed to prepare" ${testfile} \
|
|
[list $srcfile $asm_file] {nodebug}] } {
|
|
return -1
|
|
}
|
|
|
|
if ![runto_main] {
|
|
return -1
|
|
}
|
|
|
|
gdb_breakpoint "$srcfile:27"
|
|
gdb_continue_to_breakpoint "bar1" "\[^\r\n\]*:27\r\n.*"
|
|
|
|
gdb_test "n" "foo \\(2\\);" "bar1, 1st next"
|
|
gdb_test "n" "foo \\(4\\);" "bar1, 2nd next"
|
|
|
|
gdb_breakpoint "$srcfile:41"
|
|
gdb_continue_to_breakpoint "bar2" "\[^\r\n\]*:41\r\n.*"
|
|
|
|
gdb_test "n" "foo \\(2\\);" "bar2, 1st next"
|
|
gdb_test "n" "foo \\(4\\);" "bar2, 2nd next"
|
|
|
|
if ![runto_main] {
|
|
return -1
|
|
}
|
|
|
|
gdb_breakpoint "bar1_label_3"
|
|
setup_kfail "gdb/nnnnn" *-*-*
|
|
gdb_continue_to_breakpoint "bar1_label_3" "bar1 \\(\\)"
|
|
|
|
gdb_breakpoint "bar2_label_3"
|
|
setup_kfail "gdb/nnnnn" *-*-*
|
|
gdb_continue_to_breakpoint "bar2_label_3" "bar2 \\(\\)"
|