mirror of
https://github.com/espressif/binutils-gdb.git
synced 2025-12-19 01:19:41 +08:00
c2b915e2a5
While working on another patch I needed to pass -Wl,-soname,NAME as a
compiler flag. I initially looked for other tests that did this, and
found a few examples, so I copied what they did.
But when I checked the gdb.log file I noticed that we were actually
getting -Wl,-soname passed twice.
I tracked the repeated option to 'proc gdb_compile_shlib_1' in
lib/gdb.exp. It turns out that we always add -Wl,-soname when
compiling a shared library.
Here's an example of a build command from gdb.base/prelink.exp:
builtin_spawn -ignore SIGHUP gcc -fno-stack-protector \
/tmp/build/gdb/testsuite/outputs/gdb.base/prelink/prelink-lib.c.o \
-fdiagnostics-color=never -shared -g \
-Wl,-soname,prelink.so -Wl,-soname,prelink.so -lm \
-o /tmp/build/gdb/testsuite/outputs/gdb.base/prelink/prelink.so
Notice that '-Wl,-soname,prelink.so' is repeated.
I believe that all of the places where tests add '-Wl,-soname,NAME' as
a build option, are unnecessary.
In this commit I propose we remove them all.
As part of this change I've switched from calling gdb_compile_shlib
directly, to instead call build_executable and adding the 'shlib'
flag.
I've tested with gcc and clang and see no changes in the test results
after this commit. All the compile commands still have -Wl,-soname
added, but now it's only added once, from within lib/gdb.exp.
There should be no change in what is tested after this commit.
Approved-By: Tom Tromey <tom@tromey.com>
61 lines
2.0 KiB
Plaintext
61 lines
2.0 KiB
Plaintext
# Copyright 2010-2024 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
require allow_shlib_tests
|
|
|
|
# The testcase assumes the target can access the OBJDIR.
|
|
require {!is_remote target}
|
|
|
|
# We need to be able to influence the target's environment and working
|
|
# directory. Can't do that if when we connect the inferior is already
|
|
# running.
|
|
require !use_gdb_stub
|
|
|
|
set testfile "solib-nodir"
|
|
# Arbitrary file, possibly not containing main, even an empty one.
|
|
set srclibfile foo.c
|
|
# Arbitrary file containing main.
|
|
set srcfile start.c
|
|
set binlibfilebase ${testfile}.so
|
|
set binlibfiledir [standard_output_file {}]
|
|
set binlibfile ${binlibfiledir}/${binlibfilebase}
|
|
set executable ${testfile}
|
|
set objfile [standard_output_file ${executable}.o]
|
|
set binfile [standard_output_file ${executable}]
|
|
|
|
# build the first test case
|
|
if { [build_executable "build library" ${binlibfile} ${srclibfile} \
|
|
{debug shlib}] == -1
|
|
|| [gdb_gnu_strip_debug $binlibfile]
|
|
|| [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${objfile}" object {debug}] != ""
|
|
|| [gdb_compile "${objfile} ${binlibfile}" "${binfile}" executable {}] != "" } {
|
|
untested "failed to compile"
|
|
return -1
|
|
}
|
|
|
|
clean_restart $executable
|
|
gdb_load_shlib ${binlibfile}
|
|
|
|
gdb_test_no_output "set env LD_LIBRARY_PATH=:"
|
|
gdb_test_no_output "set cwd ${binlibfiledir}" \
|
|
"set cwd OBJDIR/${subdir}"
|
|
|
|
set test "library loaded"
|
|
if [runto_main] {
|
|
pass $test
|
|
} else {
|
|
fail $test
|
|
}
|