mirror of
https://github.com/espressif/binutils-gdb.git
synced 2025-08-19 03:38:40 +08:00
65706a29ba
When testing with "maint set target-non-stop on", a few threading-related tests expose an issue that requires new RSP packets. Say there are 3 threads running, 1-3. If GDB tries to stop thread 1, 2 and 3, and then waits for their stops, but meanwhile say, thread 2 exits, GDB hangs forever waiting for a stop for thread 2 that won't ever happen. This patch fixes the issue by adding support for thread exit events to the protocol. However, we don't want these always enabled, as they're useless most of the time, and would slow down remote debugging. So I made it so that GDB can enable/disable them, and then made gdb do that around the cases that need it, which currently is only infrun.c:stop_all_threads. In turn, if we have thread exit events, then the extra "thread x exited" traffic slows down attach-many-short-lived-threads.exp enough that gdb has trouble keeping up with new threads that are spawned while gdb tries to stop existing ones. To fix that I added support for the counterpart thread created events too. Enabling those when we try to stop threads ensures that new threads never get a chance to themselves start new threads, killing the race. gdb/doc/ChangeLog: 2015-11-30 Pedro Alves <palves@redhat.com> * gdb.texinfo (Remote Configuration): List "set/show remote thread-events" command in configuration table. (Stop Reply Packets): Document "T05 create" stop reason and 'w' stop reply. (General Query Packets): Document QThreadEvents packet. Document QThreadEvents qSupported feature. gdb/gdbserver/ChangeLog: 2015-11-30 Pedro Alves <palves@redhat.com> * linux-low.c (handle_extended_wait): Assert that the LWP's waitstatus is TARGET_WAITKIND_IGNORE. If GDB wants to hear about thread create events, leave the new child's status pending. (linux_low_filter_event): If GDB wants to hear about thread exit events, leave the LWP marked dead and don't delete it. (linux_wait_for_event_filtered): Don't check for thread exit. (filter_exit_event): New function. (linux_wait_1): Use it, when returning an exit event. (linux_resume_one_lwp_throw): Assert that the LWP's waitstatus is TARGET_WAITKIND_IGNORE. * remote-utils.c (prepare_resume_reply): Handle TARGET_WAITKIND_THREAD_CREATED and TARGET_WAITKIND_THREAD_EXITED. * server.c (report_thread_events): New global. (handle_general_set): Handle QThreadEvents. (handle_query) <qSupported>: Handle and report QThreadEvents+; (handle_target_event): Handle TARGET_WAITKIND_THREAD_CREATED and TARGET_WAITKIND_THREAD_EXITED. * server.h (report_thread_events): Declare. gdb/ChangeLog: 2015-11-30 Pedro Alves <palves@redhat.com> * NEWS (New commands): Mention "set/show remote thread-events" commands. (New remote packets): Mention thread created/exited stop reasons and QThreadEvents packet. * infrun.c (disable_thread_events): New function. (stop_all_threads): Disable/enable thread create/exit events. Handle TARGET_WAITKIND_THREAD_EXITED. (handle_inferior_event_1): Handle TARGET_WAITKIND_THREAD_CREATED and TARGET_WAITKIND_THREAD_EXITED. * remote.c (remove_child_of_pending_fork): Also remove threads of threads that have TARGET_WAITKIND_THREAD_EXITED events. (remote_parse_stop_reply): Handle "create" magic register. Handle 'w' stop reply. (initialize_remote): Install remote_thread_events as to_thread_events target hook. (remote_thread_events): New function. * target-delegates.c: Regenerate. * target.c (target_thread_events): New function. * target.h (struct target_ops) <to_thread_events>: New field. (target_thread_events): Declare. * target/waitstatus.c (target_waitstatus_to_string): Handle TARGET_WAITKIND_THREAD_CREATED and TARGET_WAITKIND_THREAD_EXITED. * target/waitstatus.h (enum target_waitkind) <TARGET_WAITKIND_THREAD_CREATED, TARGET_WAITKIND_THREAD_EXITED): New values.
75 lines
2.7 KiB
C
75 lines
2.7 KiB
C
/* Target waitstatus implementations.
|
|
|
|
Copyright (C) 1990-2015 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "common-defs.h"
|
|
#include "waitstatus.h"
|
|
|
|
/* Return a pretty printed form of target_waitstatus.
|
|
Space for the result is malloc'd, caller must free. */
|
|
|
|
char *
|
|
target_waitstatus_to_string (const struct target_waitstatus *ws)
|
|
{
|
|
const char *kind_str = "status->kind = ";
|
|
|
|
switch (ws->kind)
|
|
{
|
|
case TARGET_WAITKIND_EXITED:
|
|
return xstrprintf ("%sexited, status = %d",
|
|
kind_str, ws->value.integer);
|
|
case TARGET_WAITKIND_STOPPED:
|
|
return xstrprintf ("%sstopped, signal = %s",
|
|
kind_str,
|
|
gdb_signal_to_symbol_string (ws->value.sig));
|
|
case TARGET_WAITKIND_SIGNALLED:
|
|
return xstrprintf ("%ssignalled, signal = %s",
|
|
kind_str,
|
|
gdb_signal_to_symbol_string (ws->value.sig));
|
|
case TARGET_WAITKIND_LOADED:
|
|
return xstrprintf ("%sloaded", kind_str);
|
|
case TARGET_WAITKIND_FORKED:
|
|
return xstrprintf ("%sforked", kind_str);
|
|
case TARGET_WAITKIND_VFORKED:
|
|
return xstrprintf ("%svforked", kind_str);
|
|
case TARGET_WAITKIND_EXECD:
|
|
return xstrprintf ("%sexecd", kind_str);
|
|
case TARGET_WAITKIND_VFORK_DONE:
|
|
return xstrprintf ("%svfork-done", kind_str);
|
|
case TARGET_WAITKIND_SYSCALL_ENTRY:
|
|
return xstrprintf ("%sentered syscall", kind_str);
|
|
case TARGET_WAITKIND_SYSCALL_RETURN:
|
|
return xstrprintf ("%sexited syscall", kind_str);
|
|
case TARGET_WAITKIND_SPURIOUS:
|
|
return xstrprintf ("%sspurious", kind_str);
|
|
case TARGET_WAITKIND_IGNORE:
|
|
return xstrprintf ("%signore", kind_str);
|
|
case TARGET_WAITKIND_NO_HISTORY:
|
|
return xstrprintf ("%sno-history", kind_str);
|
|
case TARGET_WAITKIND_NO_RESUMED:
|
|
return xstrprintf ("%sno-resumed", kind_str);
|
|
case TARGET_WAITKIND_THREAD_CREATED:
|
|
return xstrprintf ("%sthread created", kind_str);
|
|
case TARGET_WAITKIND_THREAD_EXITED:
|
|
return xstrprintf ("%sthread exited, status = %d",
|
|
kind_str, ws->value.integer);
|
|
default:
|
|
return xstrprintf ("%sunknown???", kind_str);
|
|
}
|
|
}
|