mirror of
https://github.com/espressif/binutils-gdb.git
synced 2025-05-31 01:45:52 +08:00

Most allocation functions (if not all) return a void* pointing to the allocated memory. In C++, we need to add an explicit cast when assigning the result to a pointer to another type (which is the case more often than not). The content of this patch is taken from Pedro's branch, from commit "(mostly) auto-generated patch to insert casts needed for C++". I validated that the changes make sense and manually reflowed the code to make it respect the coding style. I also found multiple places where I could use XNEW/XNEWVEC/XRESIZEVEC/etc. Thanks a lot to whoever did that automated script to insert casts, doing it completely by hand would have taken a ridiculous amount of time. Only files built on x86 with --enable-targets=all are modified. This means that all other -nat.c files are untouched and will have to be dealt with later by using appropiate compilers. Or maybe we can try to build them with a regular g++ just to know where to add casts, I don't know. I built-tested this with --enable-targets=all and reg-tested. Here's the changelog entry, which was not too bad to make despite the size, thanks to David Malcom's script. I fixed some bits by hand, but there might be some wrong parts left (hopefully not). gdb/ChangeLog: * aarch64-linux-tdep.c (aarch64_stap_parse_special_token): Add cast to allocation result assignment. * ada-exp.y (write_object_renaming): Likewise. (write_ambiguous_var): Likewise. (ada_nget_field_index): Likewise. (write_var_or_type): Likewise. * ada-lang.c (ada_decode_symbol): Likewise. (ada_value_assign): Likewise. (value_pointer): Likewise. (cache_symbol): Likewise. (add_nonlocal_symbols): Likewise. (ada_name_for_lookup): Likewise. (symbol_completion_add): Likewise. (ada_to_fixed_type_1): Likewise. (ada_get_next_arg): Likewise. (defns_collected): Likewise. * ada-lex.l (processId): Likewise. (processString): Likewise. * ada-tasks.c (read_known_tasks_array): Likewise. (read_known_tasks_list): Likewise. * ada-typeprint.c (decoded_type_name): Likewise. * addrmap.c (addrmap_mutable_create_fixed): Likewise. * amd64-tdep.c (amd64_push_arguments): Likewise. (amd64_displaced_step_copy_insn): Likewise. (amd64_classify_insn_at): Likewise. (amd64_relocate_instruction): Likewise. * amd64obsd-tdep.c (amd64obsd_sigtramp_p): Likewise. * arch-utils.c (simple_displaced_step_copy_insn): Likewise. (initialize_current_architecture): Likewise. * arm-linux-tdep.c (arm_stap_parse_special_token): Likewise. * arm-symbian-tdep.c (arm_symbian_osabi_sniffer): Likewise. * arm-tdep.c (arm_exidx_new_objfile): Likewise. (arm_push_dummy_call): Likewise. (extend_buffer_earlier): Likewise. (arm_adjust_breakpoint_address): Likewise. (arm_skip_stub): Likewise. * auto-load.c (filename_is_in_pattern): Likewise. (maybe_add_script_file): Likewise. (maybe_add_script_text): Likewise. (auto_load_objfile_script_1): Likewise. * auxv.c (ld_so_xfer_auxv): Likewise. * ax-general.c (new_agent_expr): Likewise. (grow_expr): Likewise. (ax_reg_mask): Likewise. * bcache.c (bcache_full): Likewise. * breakpoint.c (program_breakpoint_here_p): Likewise. * btrace.c (parse_xml_raw): Likewise. * build-id.c (build_id_to_debug_bfd): Likewise. * buildsym.c (end_symtab_with_blockvector): Likewise. * c-exp.y (string_exp): Likewise. (qualified_name): Likewise. (write_destructor_name): Likewise. (operator_stoken): Likewise. (parse_number): Likewise. (scan_macro_expansion): Likewise. (yylex): Likewise. (c_print_token): Likewise. * c-lang.c (c_get_string): Likewise. (emit_numeric_character): Likewise. * charset.c (wchar_iterate): Likewise. * cli/cli-cmds.c (complete_command): Likewise. (make_command): Likewise. * cli/cli-dump.c (restore_section_callback): Likewise. (restore_binary_file): Likewise. * cli/cli-interp.c (cli_interpreter_exec): Likewise. * cli/cli-script.c (execute_control_command): Likewise. * cli/cli-setshow.c (do_set_command): Likewise. * coff-pe-read.c (add_pe_forwarded_sym): Likewise. (read_pe_exported_syms): Likewise. * coffread.c (coff_read_struct_type): Likewise. (coff_read_enum_type): Likewise. * common/btrace-common.c (btrace_data_append): Likewise. * common/buffer.c (buffer_grow): Likewise. * common/filestuff.c (gdb_fopen_cloexec): Likewise. * common/format.c (parse_format_string): Likewise. * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append): Likewise. * common/xml-utils.c (xml_escape_text): Likewise. * compile/compile-object-load.c (copy_sections): Likewise. (compile_object_load): Likewise. * compile/compile-object-run.c (compile_object_run): Likewise. * completer.c (filename_completer): Likewise. * corefile.c (read_memory_typed_address): Likewise. (write_memory_unsigned_integer): Likewise. (write_memory_signed_integer): Likewise. (complete_set_gnutarget): Likewise. * corelow.c (get_core_register_section): Likewise. * cp-name-parser.y (d_grab): Likewise. (allocate_info): Likewise. (cp_new_demangle_parse_info): Likewise. * cp-namespace.c (cp_scan_for_anonymous_namespaces): Likewise. (cp_lookup_symbol_in_namespace): Likewise. (lookup_namespace_scope): Likewise. (find_symbol_in_baseclass): Likewise. (cp_lookup_nested_symbol): Likewise. (cp_lookup_transparent_type_loop): Likewise. * cp-support.c (copy_string_to_obstack): Likewise. (make_symbol_overload_list): Likewise. (make_symbol_overload_list_namespace): Likewise. (make_symbol_overload_list_adl_namespace): Likewise. (first_component_command): Likewise. * cp-valprint.c (cp_print_value): Likewise. * ctf.c (ctf_xfer_partial): Likewise. * d-exp.y (StringExp): Likewise. * d-namespace.c (d_lookup_symbol_in_module): Likewise. (lookup_module_scope): Likewise. (find_symbol_in_baseclass): Likewise. (d_lookup_nested_symbol): Likewise. * dbxread.c (find_stab_function_addr): Likewise. (read_dbx_symtab): Likewise. (dbx_end_psymtab): Likewise. (cp_set_block_scope): Likewise. * dcache.c (dcache_alloc): Likewise. * demangle.c (_initialize_demangler): Likewise. * dicos-tdep.c (dicos_load_module_p): Likewise. * dictionary.c (dict_create_hashed_expandable): Likewise. (dict_create_linear_expandable): Likewise. (expand_hashtable): Likewise. (add_symbol_linear_expandable): Likewise. * dwarf2-frame.c (add_cie): Likewise. (add_fde): Likewise. (dwarf2_build_frame_info): Likewise. * dwarf2expr.c (dwarf_expr_grow_stack): Likewise. (dwarf_expr_fetch_address): Likewise. (add_piece): Likewise. (execute_stack_op): Likewise. * dwarf2loc.c (chain_candidate): Likewise. (dwarf_entry_parameter_to_value): Likewise. (read_pieced_value): Likewise. (write_pieced_value): Likewise. * dwarf2read.c (dwarf2_read_section): Likewise. (add_type_unit): Likewise. (read_comp_units_from_section): Likewise. (fixup_go_packaging): Likewise. (dwarf2_compute_name): Likewise. (dwarf2_physname): Likewise. (create_dwo_unit_in_dwp_v1): Likewise. (create_dwo_unit_in_dwp_v2): Likewise. (read_func_scope): Likewise. (read_call_site_scope): Likewise. (dwarf2_attach_fields_to_type): Likewise. (process_structure_scope): Likewise. (mark_common_block_symbol_computed): Likewise. (read_common_block): Likewise. (abbrev_table_read_table): Likewise. (guess_partial_die_structure_name): Likewise. (fixup_partial_die): Likewise. (add_file_name): Likewise. (dwarf2_const_value_data): Likewise. (dwarf2_const_value_attr): Likewise. (build_error_marker_type): Likewise. (guess_full_die_structure_name): Likewise. (anonymous_struct_prefix): Likewise. (typename_concat): Likewise. (dwarf2_canonicalize_name): Likewise. (dwarf2_name): Likewise. (write_constant_as_bytes): Likewise. (dwarf2_fetch_constant_bytes): Likewise. (copy_string): Likewise. (parse_macro_definition): Likewise. * elfread.c (elf_symfile_segments): Likewise. (elf_rel_plt_read): Likewise. (elf_gnu_ifunc_resolve_by_cache): Likewise. (elf_gnu_ifunc_resolve_by_got): Likewise. (elf_read_minimal_symbols): Likewise. (elf_gnu_ifunc_record_cache): Likewise. * event-top.c (top_level_prompt): Likewise. (command_line_handler): Likewise. * exec.c (resize_section_table): Likewise. * expprint.c (print_subexp_standard): Likewise. * fbsd-tdep.c (fbsd_collect_regset_section_cb): Likewise. * findcmd.c (parse_find_args): Likewise. * findvar.c (address_from_register): Likewise. * frame.c (get_prev_frame_always): Likewise. * gdb_bfd.c (gdb_bfd_ref): Likewise. (get_section_descriptor): Likewise. * gdb_obstack.c (obconcat): Likewise. (obstack_strdup): Likewise. * gdbtypes.c (lookup_function_type_with_arguments): Likewise. (create_set_type): Likewise. (lookup_unsigned_typename): Likewise. (lookup_signed_typename): Likewise. (resolve_dynamic_union): Likewise. (resolve_dynamic_struct): Likewise. (add_dyn_prop): Likewise. (copy_dynamic_prop_list): Likewise. (arch_flags_type): Likewise. (append_composite_type_field_raw): Likewise. * gdbtypes.h (INIT_FUNC_SPECIFIC): Likewise. * gnu-v3-abi.c (gnuv3_rtti_type): Likewise. * go-exp.y (string_exp): Likewise. * go-lang.c (go_demangle): Likewise. * guile/guile.c (compute_scheme_string): Likewise. * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise. (gdbscm_canonicalize_command_name): Likewise. * guile/scm-ports.c (ioscm_init_stdio_buffers): Likewise. (ioscm_init_memory_port): Likewise. (ioscm_reinit_memory_port): Likewise. * guile/scm-utils.c (gdbscm_gc_xstrdup): Likewise. (gdbscm_gc_dup_argv): Likewise. * h8300-tdep.c (h8300_push_dummy_call): Likewise. * hppa-tdep.c (internalize_unwinds): Likewise. (read_unwind_info): Likewise. * i386-cygwin-tdep.c (core_process_module_section): Likewise. (windows_core_xfer_shared_libraries): Likewise. * i386-tdep.c (i386_displaced_step_copy_insn): Likewise. (i386_stap_parse_special_token_triplet): Likewise. (i386_stap_parse_special_token_three_arg_disp): Likewise. * i386obsd-tdep.c (i386obsd_sigtramp_p): Likewise. * inf-child.c (inf_child_fileio_readlink): Likewise. * inf-ptrace.c (inf_ptrace_fetch_register): Likewise. (inf_ptrace_store_register): Likewise. * infrun.c (follow_exec): Likewise. (displaced_step_prepare_throw): Likewise. (save_stop_context): Likewise. (save_infcall_suspend_state): Likewise. * jit.c (jit_read_descriptor): Likewise. (jit_read_code_entry): Likewise. (jit_symtab_line_mapping_add_impl): Likewise. (finalize_symtab): Likewise. (jit_unwind_reg_get_impl): Likewise. * jv-exp.y (QualifiedName): Likewise. * jv-lang.c (get_java_utf8_name): Likewise. (type_from_class): Likewise. (java_demangle_type_signature): Likewise. (java_class_name_from_physname): Likewise. * jv-typeprint.c (java_type_print_base): Likewise. * jv-valprint.c (java_value_print): Likewise. * language.c (add_language): Likewise. * linespec.c (add_sal_to_sals_basic): Likewise. (add_sal_to_sals): Likewise. (decode_objc): Likewise. (find_linespec_symbols): Likewise. * linux-fork.c (fork_save_infrun_state): Likewise. * linux-nat.c (linux_nat_detach): Likewise. (linux_nat_fileio_readlink): Likewise. * linux-record.c (record_linux_sockaddr): Likewise. (record_linux_msghdr): Likewise. (Do): Likewise. * linux-tdep.c (linux_core_info_proc_mappings): Likewise. (linux_collect_regset_section_cb): Likewise. (linux_get_siginfo_data): Likewise. * linux-thread-db.c (try_thread_db_load_from_pdir_1): Likewise. (try_thread_db_load_from_dir): Likewise. (thread_db_load_search): Likewise. (info_auto_load_libthread_db): Likewise. * m32c-tdep.c (m32c_m16c_address_to_pointer): Likewise. (m32c_m16c_pointer_to_address): Likewise. * m68hc11-tdep.c (m68hc11_pseudo_register_write): Likewise. * m68k-tdep.c (m68k_get_longjmp_target): Likewise. * machoread.c (macho_check_dsym): Likewise. * macroexp.c (resize_buffer): Likewise. (gather_arguments): Likewise. (maybe_expand): Likewise. * macrotab.c (new_macro_key): Likewise. (new_source_file): Likewise. (new_macro_definition): Likewise. * mdebugread.c (parse_symbol): Likewise. (parse_type): Likewise. (parse_partial_symbols): Likewise. (psymtab_to_symtab_1): Likewise. * mem-break.c (default_memory_insert_breakpoint): Likewise. * mi/mi-cmd-break.c (mi_argv_to_format): Likewise. * mi/mi-main.c (mi_cmd_data_read_memory): Likewise. (mi_cmd_data_read_memory_bytes): Likewise. (mi_cmd_data_write_memory_bytes): Likewise. (mi_cmd_trace_frame_collected): Likewise. * mi/mi-parse.c (mi_parse_argv): Likewise. (mi_parse): Likewise. * minidebug.c (lzma_open): Likewise. (lzma_pread): Likewise. * mips-tdep.c (mips_read_fp_register_single): Likewise. (mips_print_fp_register): Likewise. * mipsnbsd-tdep.c (mipsnbsd_get_longjmp_target): Likewise. * mipsread.c (read_alphacoff_dynamic_symtab): Likewise. * mt-tdep.c (mt_register_name): Likewise. (mt_registers_info): Likewise. (mt_push_dummy_call): Likewise. * namespace.c (add_using_directive): Likewise. * nat/linux-btrace.c (perf_event_read): Likewise. (linux_enable_bts): Likewise. * nat/linux-osdata.c (linux_common_core_of_thread): Likewise. * nat/linux-ptrace.c (linux_ptrace_test_ret_to_nx): Likewise. * nto-tdep.c (nto_find_and_open_solib): Likewise. (nto_parse_redirection): Likewise. * objc-lang.c (objc_demangle): Likewise. (find_methods): Likewise. * objfiles.c (get_objfile_bfd_data): Likewise. (set_objfile_main_name): Likewise. (allocate_objfile): Likewise. (objfile_relocate): Likewise. (update_section_map): Likewise. * osabi.c (generic_elf_osabi_sniff_abi_tag_sections): Likewise. * p-exp.y (exp): Likewise. (yylex): Likewise. * p-valprint.c (pascal_object_print_value): Likewise. * parse.c (initialize_expout): Likewise. (mark_completion_tag): Likewise. (copy_name): Likewise. (parse_float): Likewise. (type_stack_reserve): Likewise. * ppc-linux-tdep.c (ppc_stap_parse_special_token): Likewise. (ppu2spu_prev_register): Likewise. * ppc-ravenscar-thread.c (supply_register_at_address): Likewise. * printcmd.c (printf_wide_c_string): Likewise. (printf_pointer): Likewise. * probe.c (parse_probes): Likewise. * python/py-cmd.c (gdbpy_parse_command_name): Likewise. (cmdpy_init): Likewise. * python/py-gdb-readline.c (gdbpy_readline_wrapper): Likewise. * python/py-symtab.c (set_sal): Likewise. * python/py-unwind.c (pyuw_sniffer): Likewise. * python/python.c (python_interactive_command): Likewise. (compute_python_string): Likewise. * ravenscar-thread.c (get_running_thread_id): Likewise. * record-full.c (record_full_exec_insn): Likewise. (record_full_core_open_1): Likewise. * regcache.c (regcache_raw_read_signed): Likewise. (regcache_raw_read_unsigned): Likewise. (regcache_cooked_read_signed): Likewise. (regcache_cooked_read_unsigned): Likewise. * remote-fileio.c (remote_fileio_func_open): Likewise. (remote_fileio_func_rename): Likewise. (remote_fileio_func_unlink): Likewise. (remote_fileio_func_stat): Likewise. (remote_fileio_func_system): Likewise. * remote-mips.c (mips_xfer_memory): Likewise. (mips_load_srec): Likewise. (pmon_end_download): Likewise. * remote.c (new_remote_state): Likewise. (map_regcache_remote_table): Likewise. (remote_register_number_and_offset): Likewise. (init_remote_state): Likewise. (get_memory_packet_size): Likewise. (remote_pass_signals): Likewise. (remote_program_signals): Likewise. (remote_start_remote): Likewise. (remote_check_symbols): Likewise. (remote_query_supported): Likewise. (extended_remote_attach): Likewise. (process_g_packet): Likewise. (store_registers_using_G): Likewise. (putpkt_binary): Likewise. (read_frame): Likewise. (compare_sections_command): Likewise. (remote_hostio_pread): Likewise. (remote_hostio_readlink): Likewise. (remote_file_put): Likewise. (remote_file_get): Likewise. (remote_pid_to_exec_file): Likewise. (_initialize_remote): Likewise. * rs6000-aix-tdep.c (rs6000_aix_ld_info_to_xml): Likewise. (rs6000_aix_core_xfer_shared_libraries_aix): Likewise. * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise. (bfd_uses_spe_extensions): Likewise. * s390-linux-tdep.c (s390_displaced_step_copy_insn): Likewise. * score-tdep.c (score7_malloc_and_get_memblock): Likewise. * solib-dsbt.c (decode_loadmap): Likewise. (fetch_loadmap): Likewise. (scan_dyntag): Likewise. (enable_break): Likewise. (dsbt_relocate_main_executable): Likewise. * solib-frv.c (fetch_loadmap): Likewise. (enable_break2): Likewise. (frv_relocate_main_executable): Likewise. * solib-spu.c (spu_relocate_main_executable): Likewise. (spu_bfd_open): Likewise. * solib-svr4.c (lm_info_read): Likewise. (read_program_header): Likewise. (find_program_interpreter): Likewise. (scan_dyntag): Likewise. (elf_locate_base): Likewise. (open_symbol_file_object): Likewise. (read_program_headers_from_bfd): Likewise. (svr4_relocate_main_executable): Likewise. * solib-target.c (solib_target_relocate_section_addresses): Likewise. * solib.c (solib_find_1): Likewise. (exec_file_find): Likewise. (solib_find): Likewise. * source.c (openp): Likewise. (print_source_lines_base): Likewise. (forward_search_command): Likewise. * sparc-ravenscar-thread.c (supply_register_at_address): Likewise. * spu-tdep.c (spu2ppu_prev_register): Likewise. (spu_get_overlay_table): Likewise. * stabsread.c (patch_block_stabs): Likewise. (define_symbol): Likewise. (again:): Likewise. (read_member_functions): Likewise. (read_one_struct_field): Likewise. (read_enum_type): Likewise. (common_block_start): Likewise. * stack.c (read_frame_arg): Likewise. (backtrace_command): Likewise. * stap-probe.c (stap_parse_register_operand): Likewise. * symfile.c (syms_from_objfile_1): Likewise. (find_separate_debug_file): Likewise. (load_command): Likewise. (load_progress): Likewise. (load_section_callback): Likewise. (reread_symbols): Likewise. (add_filename_language): Likewise. (allocate_compunit_symtab): Likewise. (read_target_long_array): Likewise. (simple_read_overlay_table): Likewise. * symtab.c (symbol_set_names): Likewise. (resize_symbol_cache): Likewise. (rbreak_command): Likewise. (completion_list_add_name): Likewise. (completion_list_objc_symbol): Likewise. (add_filename_to_list): Likewise. * target-descriptions.c (maint_print_c_tdesc_cmd): Likewise. * target-memory.c (target_write_memory_blocks): Likewise. * target.c (target_read_string): Likewise. (read_whatever_is_readable): Likewise. (target_read_alloc_1): Likewise. (simple_search_memory): Likewise. (target_fileio_read_alloc_1): Likewise. * tilegx-tdep.c (tilegx_push_dummy_call): Likewise. * top.c (command_line_input): Likewise. * tracefile-tfile.c (tfile_fetch_registers): Likewise. * tracefile.c (tracefile_fetch_registers): Likewise. * tracepoint.c (add_memrange): Likewise. (init_collection_list): Likewise. (add_aexpr): Likewise. (trace_dump_actions): Likewise. (parse_trace_status): Likewise. (parse_tracepoint_definition): Likewise. (parse_tsv_definition): Likewise. (parse_static_tracepoint_marker_definition): Likewise. * tui/tui-file.c (tui_sfileopen): Likewise. (tui_file_adjust_strbuf): Likewise. * tui/tui-io.c (tui_expand_tabs): Likewise. * tui/tui-source.c (tui_set_source_content): Likewise. * typeprint.c (find_global_typedef): Likewise. * ui-file.c (do_ui_file_xstrdup): Likewise. (ui_file_obsavestring): Likewise. (mem_file_write): Likewise. * utils.c (make_hex_string): Likewise. (get_regcomp_error): Likewise. (puts_filtered_tabular): Likewise. (gdb_realpath_keepfile): Likewise. (ldirname): Likewise. (gdb_bfd_errmsg): Likewise. (substitute_path_component): Likewise. * valops.c (search_struct_method): Likewise. (find_oload_champ_namespace_loop): Likewise. * valprint.c (print_decimal_chars): Likewise. (read_string): Likewise. (generic_emit_char): Likewise. * varobj.c (varobj_delete): Likewise. (varobj_value_get_print_value): Likewise. * vaxobsd-tdep.c (vaxobsd_sigtramp_sniffer): Likewise. * windows-tdep.c (display_one_tib): Likewise. * xcoffread.c (read_xcoff_symtab): Likewise. (process_xcoff_symbol): Likewise. (swap_sym): Likewise. (scan_xcoff_symtab): Likewise. (xcoff_initial_scan): Likewise. * xml-support.c (gdb_xml_end_element): Likewise. (xml_process_xincludes): Likewise. (xml_fetch_content_from_file): Likewise. * xml-syscall.c (xml_list_of_syscalls): Likewise. * xstormy16-tdep.c (xstormy16_push_dummy_call): Likewise. gdb/gdbserver/ChangeLog: * ax.c (gdb_parse_agent_expr): Add cast to allocation result assignment. (gdb_unparse_agent_expr): Likewise. * hostio.c (require_data): Likewise. (handle_pread): Likewise. * linux-low.c (disable_regset): Likewise. (fetch_register): Likewise. (store_register): Likewise. (get_dynamic): Likewise. (linux_qxfer_libraries_svr4): Likewise. * mem-break.c (delete_fast_tracepoint_jump): Likewise. (set_fast_tracepoint_jump): Likewise. (uninsert_fast_tracepoint_jumps_at): Likewise. (reinsert_fast_tracepoint_jumps_at): Likewise. (validate_inserted_breakpoint): Likewise. (clone_agent_expr): Likewise. * regcache.c (init_register_cache): Likewise. * remote-utils.c (putpkt_binary_1): Likewise. (decode_M_packet): Likewise. (decode_X_packet): Likewise. (look_up_one_symbol): Likewise. (relocate_instruction): Likewise. (monitor_output): Likewise. * server.c (handle_search_memory): Likewise. (handle_qxfer_exec_file): Likewise. (handle_qxfer_libraries): Likewise. (handle_qxfer): Likewise. (handle_query): Likewise. (handle_v_cont): Likewise. (handle_v_run): Likewise. (captured_main): Likewise. * target.c (write_inferior_memory): Likewise. * thread-db.c (try_thread_db_load_from_dir): Likewise. * tracepoint.c (init_trace_buffer): Likewise. (add_tracepoint_action): Likewise. (add_traceframe): Likewise. (add_traceframe_block): Likewise. (cmd_qtdpsrc): Likewise. (cmd_qtdv): Likewise. (cmd_qtstatus): Likewise. (response_source): Likewise. (response_tsv): Likewise. (cmd_qtnotes): Likewise. (gdb_collect): Likewise. (initialize_tracepoint): Likewise.
1381 lines
32 KiB
C
1381 lines
32 KiB
C
/* Remote File-I/O communications
|
||
|
||
Copyright (C) 2003-2015 Free Software Foundation, Inc.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
/* See the GDB User Guide for details of the GDB remote protocol. */
|
||
|
||
#include "defs.h"
|
||
#include "gdbcmd.h"
|
||
#include "remote.h"
|
||
#include "gdb_wait.h"
|
||
#include <sys/stat.h>
|
||
#include "remote-fileio.h"
|
||
#include "event-loop.h"
|
||
#include "target.h"
|
||
#include "filenames.h"
|
||
#include "filestuff.h"
|
||
|
||
#include <fcntl.h>
|
||
#include "gdb_sys_time.h"
|
||
#ifdef __CYGWIN__
|
||
#include <sys/cygwin.h> /* For cygwin_conv_path. */
|
||
#endif
|
||
#include <signal.h>
|
||
|
||
static struct {
|
||
int *fd_map;
|
||
int fd_map_size;
|
||
} remote_fio_data;
|
||
|
||
#define FIO_FD_INVALID -1
|
||
#define FIO_FD_CONSOLE_IN -2
|
||
#define FIO_FD_CONSOLE_OUT -3
|
||
|
||
static int remote_fio_system_call_allowed = 0;
|
||
|
||
static struct async_signal_handler *sigint_fileio_token;
|
||
|
||
static int
|
||
remote_fileio_init_fd_map (void)
|
||
{
|
||
int i;
|
||
|
||
if (!remote_fio_data.fd_map)
|
||
{
|
||
remote_fio_data.fd_map = XNEWVEC (int, 10);
|
||
remote_fio_data.fd_map_size = 10;
|
||
remote_fio_data.fd_map[0] = FIO_FD_CONSOLE_IN;
|
||
remote_fio_data.fd_map[1] = FIO_FD_CONSOLE_OUT;
|
||
remote_fio_data.fd_map[2] = FIO_FD_CONSOLE_OUT;
|
||
for (i = 3; i < 10; ++i)
|
||
remote_fio_data.fd_map[i] = FIO_FD_INVALID;
|
||
}
|
||
return 3;
|
||
}
|
||
|
||
static int
|
||
remote_fileio_resize_fd_map (void)
|
||
{
|
||
int i = remote_fio_data.fd_map_size;
|
||
|
||
if (!remote_fio_data.fd_map)
|
||
return remote_fileio_init_fd_map ();
|
||
remote_fio_data.fd_map_size += 10;
|
||
remote_fio_data.fd_map =
|
||
(int *) xrealloc (remote_fio_data.fd_map,
|
||
remote_fio_data.fd_map_size * sizeof (int));
|
||
for (; i < remote_fio_data.fd_map_size; i++)
|
||
remote_fio_data.fd_map[i] = FIO_FD_INVALID;
|
||
return remote_fio_data.fd_map_size - 10;
|
||
}
|
||
|
||
static int
|
||
remote_fileio_next_free_fd (void)
|
||
{
|
||
int i;
|
||
|
||
for (i = 0; i < remote_fio_data.fd_map_size; ++i)
|
||
if (remote_fio_data.fd_map[i] == FIO_FD_INVALID)
|
||
return i;
|
||
return remote_fileio_resize_fd_map ();
|
||
}
|
||
|
||
static int
|
||
remote_fileio_fd_to_targetfd (int fd)
|
||
{
|
||
int target_fd = remote_fileio_next_free_fd ();
|
||
|
||
remote_fio_data.fd_map[target_fd] = fd;
|
||
return target_fd;
|
||
}
|
||
|
||
static int
|
||
remote_fileio_map_fd (int target_fd)
|
||
{
|
||
remote_fileio_init_fd_map ();
|
||
if (target_fd < 0 || target_fd >= remote_fio_data.fd_map_size)
|
||
return FIO_FD_INVALID;
|
||
return remote_fio_data.fd_map[target_fd];
|
||
}
|
||
|
||
static void
|
||
remote_fileio_close_target_fd (int target_fd)
|
||
{
|
||
remote_fileio_init_fd_map ();
|
||
if (target_fd >= 0 && target_fd < remote_fio_data.fd_map_size)
|
||
remote_fio_data.fd_map[target_fd] = FIO_FD_INVALID;
|
||
}
|
||
|
||
static int
|
||
remote_fileio_oflags_to_host (long flags)
|
||
{
|
||
int hflags = 0;
|
||
|
||
if (flags & FILEIO_O_CREAT)
|
||
hflags |= O_CREAT;
|
||
if (flags & FILEIO_O_EXCL)
|
||
hflags |= O_EXCL;
|
||
if (flags & FILEIO_O_TRUNC)
|
||
hflags |= O_TRUNC;
|
||
if (flags & FILEIO_O_APPEND)
|
||
hflags |= O_APPEND;
|
||
if (flags & FILEIO_O_RDONLY)
|
||
hflags |= O_RDONLY;
|
||
if (flags & FILEIO_O_WRONLY)
|
||
hflags |= O_WRONLY;
|
||
if (flags & FILEIO_O_RDWR)
|
||
hflags |= O_RDWR;
|
||
/* On systems supporting binary and text mode, always open files in
|
||
binary mode. */
|
||
#ifdef O_BINARY
|
||
hflags |= O_BINARY;
|
||
#endif
|
||
return hflags;
|
||
}
|
||
|
||
static mode_t
|
||
remote_fileio_mode_to_host (long mode, int open_call)
|
||
{
|
||
mode_t hmode = 0;
|
||
|
||
if (!open_call)
|
||
{
|
||
if (mode & FILEIO_S_IFREG)
|
||
hmode |= S_IFREG;
|
||
if (mode & FILEIO_S_IFDIR)
|
||
hmode |= S_IFDIR;
|
||
if (mode & FILEIO_S_IFCHR)
|
||
hmode |= S_IFCHR;
|
||
}
|
||
if (mode & FILEIO_S_IRUSR)
|
||
hmode |= S_IRUSR;
|
||
if (mode & FILEIO_S_IWUSR)
|
||
hmode |= S_IWUSR;
|
||
if (mode & FILEIO_S_IXUSR)
|
||
hmode |= S_IXUSR;
|
||
#ifdef S_IRGRP
|
||
if (mode & FILEIO_S_IRGRP)
|
||
hmode |= S_IRGRP;
|
||
#endif
|
||
#ifdef S_IWGRP
|
||
if (mode & FILEIO_S_IWGRP)
|
||
hmode |= S_IWGRP;
|
||
#endif
|
||
#ifdef S_IXGRP
|
||
if (mode & FILEIO_S_IXGRP)
|
||
hmode |= S_IXGRP;
|
||
#endif
|
||
if (mode & FILEIO_S_IROTH)
|
||
hmode |= S_IROTH;
|
||
#ifdef S_IWOTH
|
||
if (mode & FILEIO_S_IWOTH)
|
||
hmode |= S_IWOTH;
|
||
#endif
|
||
#ifdef S_IXOTH
|
||
if (mode & FILEIO_S_IXOTH)
|
||
hmode |= S_IXOTH;
|
||
#endif
|
||
return hmode;
|
||
}
|
||
|
||
static int
|
||
remote_fileio_seek_flag_to_host (long num, int *flag)
|
||
{
|
||
if (!flag)
|
||
return 0;
|
||
switch (num)
|
||
{
|
||
case FILEIO_SEEK_SET:
|
||
*flag = SEEK_SET;
|
||
break;
|
||
case FILEIO_SEEK_CUR:
|
||
*flag = SEEK_CUR;
|
||
break;
|
||
case FILEIO_SEEK_END:
|
||
*flag = SEEK_END;
|
||
break;
|
||
default:
|
||
return -1;
|
||
}
|
||
return 0;
|
||
}
|
||
|
||
static int
|
||
remote_fileio_extract_long (char **buf, LONGEST *retlong)
|
||
{
|
||
char *c;
|
||
int sign = 1;
|
||
|
||
if (!buf || !*buf || !**buf || !retlong)
|
||
return -1;
|
||
c = strchr (*buf, ',');
|
||
if (c)
|
||
*c++ = '\0';
|
||
else
|
||
c = strchr (*buf, '\0');
|
||
while (strchr ("+-", **buf))
|
||
{
|
||
if (**buf == '-')
|
||
sign = -sign;
|
||
++*buf;
|
||
}
|
||
for (*retlong = 0; **buf; ++*buf)
|
||
{
|
||
*retlong <<= 4;
|
||
if (**buf >= '0' && **buf <= '9')
|
||
*retlong += **buf - '0';
|
||
else if (**buf >= 'a' && **buf <= 'f')
|
||
*retlong += **buf - 'a' + 10;
|
||
else if (**buf >= 'A' && **buf <= 'F')
|
||
*retlong += **buf - 'A' + 10;
|
||
else
|
||
return -1;
|
||
}
|
||
*retlong *= sign;
|
||
*buf = c;
|
||
return 0;
|
||
}
|
||
|
||
static int
|
||
remote_fileio_extract_int (char **buf, long *retint)
|
||
{
|
||
int ret;
|
||
LONGEST retlong;
|
||
|
||
if (!retint)
|
||
return -1;
|
||
ret = remote_fileio_extract_long (buf, &retlong);
|
||
if (!ret)
|
||
*retint = (long) retlong;
|
||
return ret;
|
||
}
|
||
|
||
static int
|
||
remote_fileio_extract_ptr_w_len (char **buf, CORE_ADDR *ptrval, int *length)
|
||
{
|
||
char *c;
|
||
LONGEST retlong;
|
||
|
||
if (!buf || !*buf || !**buf || !ptrval || !length)
|
||
return -1;
|
||
c = strchr (*buf, '/');
|
||
if (!c)
|
||
return -1;
|
||
*c++ = '\0';
|
||
if (remote_fileio_extract_long (buf, &retlong))
|
||
return -1;
|
||
*ptrval = (CORE_ADDR) retlong;
|
||
*buf = c;
|
||
if (remote_fileio_extract_long (buf, &retlong))
|
||
return -1;
|
||
*length = (int) retlong;
|
||
return 0;
|
||
}
|
||
|
||
static void
|
||
remote_fileio_to_fio_long (LONGEST num, fio_long_t fnum)
|
||
{
|
||
host_to_bigendian (num, (char *) fnum, 8);
|
||
}
|
||
|
||
static void
|
||
remote_fileio_to_fio_timeval (struct timeval *tv, struct fio_timeval *ftv)
|
||
{
|
||
host_to_fileio_time (tv->tv_sec, ftv->ftv_sec);
|
||
remote_fileio_to_fio_long (tv->tv_usec, ftv->ftv_usec);
|
||
}
|
||
|
||
static int remote_fio_ctrl_c_flag = 0;
|
||
static int remote_fio_no_longjmp = 0;
|
||
|
||
#if defined (HAVE_SIGACTION) && defined (SA_RESTART)
|
||
static struct sigaction remote_fio_sa;
|
||
static struct sigaction remote_fio_osa;
|
||
#else
|
||
static void (*remote_fio_ofunc)(int);
|
||
#endif
|
||
|
||
static void
|
||
remote_fileio_sig_init (void)
|
||
{
|
||
#if defined (HAVE_SIGACTION) && defined (SA_RESTART)
|
||
remote_fio_sa.sa_handler = SIG_IGN;
|
||
sigemptyset (&remote_fio_sa.sa_mask);
|
||
remote_fio_sa.sa_flags = 0;
|
||
sigaction (SIGINT, &remote_fio_sa, &remote_fio_osa);
|
||
#else
|
||
remote_fio_ofunc = signal (SIGINT, SIG_IGN);
|
||
#endif
|
||
}
|
||
|
||
static void
|
||
remote_fileio_sig_set (void (*sigint_func)(int))
|
||
{
|
||
#if defined (HAVE_SIGACTION) && defined (SA_RESTART)
|
||
remote_fio_sa.sa_handler = sigint_func;
|
||
sigemptyset (&remote_fio_sa.sa_mask);
|
||
remote_fio_sa.sa_flags = 0;
|
||
sigaction (SIGINT, &remote_fio_sa, NULL);
|
||
#else
|
||
signal (SIGINT, sigint_func);
|
||
#endif
|
||
}
|
||
|
||
static void
|
||
remote_fileio_sig_exit (void)
|
||
{
|
||
#if defined (HAVE_SIGACTION) && defined (SA_RESTART)
|
||
sigaction (SIGINT, &remote_fio_osa, NULL);
|
||
#else
|
||
signal (SIGINT, remote_fio_ofunc);
|
||
#endif
|
||
}
|
||
|
||
static void
|
||
async_remote_fileio_interrupt (gdb_client_data arg)
|
||
{
|
||
quit ();
|
||
}
|
||
|
||
static void
|
||
remote_fileio_ctrl_c_signal_handler (int signo)
|
||
{
|
||
remote_fileio_sig_set (SIG_IGN);
|
||
remote_fio_ctrl_c_flag = 1;
|
||
if (!remote_fio_no_longjmp)
|
||
gdb_call_async_signal_handler (sigint_fileio_token, 1);
|
||
remote_fileio_sig_set (remote_fileio_ctrl_c_signal_handler);
|
||
}
|
||
|
||
static void
|
||
remote_fileio_reply (int retcode, int error)
|
||
{
|
||
char buf[32];
|
||
|
||
remote_fileio_sig_set (SIG_IGN);
|
||
strcpy (buf, "F");
|
||
if (retcode < 0)
|
||
{
|
||
strcat (buf, "-");
|
||
retcode = -retcode;
|
||
}
|
||
sprintf (buf + strlen (buf), "%x", retcode);
|
||
if (error || remote_fio_ctrl_c_flag)
|
||
{
|
||
if (error && remote_fio_ctrl_c_flag)
|
||
error = FILEIO_EINTR;
|
||
if (error < 0)
|
||
{
|
||
strcat (buf, "-");
|
||
error = -error;
|
||
}
|
||
sprintf (buf + strlen (buf), ",%x", error);
|
||
if (remote_fio_ctrl_c_flag)
|
||
strcat (buf, ",C");
|
||
}
|
||
remote_fileio_sig_set (remote_fileio_ctrl_c_signal_handler);
|
||
putpkt (buf);
|
||
}
|
||
|
||
static void
|
||
remote_fileio_ioerror (void)
|
||
{
|
||
remote_fileio_reply (-1, FILEIO_EIO);
|
||
}
|
||
|
||
static void
|
||
remote_fileio_badfd (void)
|
||
{
|
||
remote_fileio_reply (-1, FILEIO_EBADF);
|
||
}
|
||
|
||
static void
|
||
remote_fileio_return_errno (int retcode)
|
||
{
|
||
remote_fileio_reply (retcode, retcode < 0
|
||
? host_to_fileio_error (errno) : 0);
|
||
}
|
||
|
||
static void
|
||
remote_fileio_return_success (int retcode)
|
||
{
|
||
remote_fileio_reply (retcode, 0);
|
||
}
|
||
|
||
static void
|
||
remote_fileio_func_open (char *buf)
|
||
{
|
||
CORE_ADDR ptrval;
|
||
int length;
|
||
long num;
|
||
int flags, fd;
|
||
mode_t mode;
|
||
char *pathname;
|
||
struct stat st;
|
||
|
||
/* 1. Parameter: Ptr to pathname / length incl. trailing zero. */
|
||
if (remote_fileio_extract_ptr_w_len (&buf, &ptrval, &length))
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
/* 2. Parameter: open flags */
|
||
if (remote_fileio_extract_int (&buf, &num))
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
flags = remote_fileio_oflags_to_host (num);
|
||
/* 3. Parameter: open mode */
|
||
if (remote_fileio_extract_int (&buf, &num))
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
mode = remote_fileio_mode_to_host (num, 1);
|
||
|
||
/* Request pathname. */
|
||
pathname = (char *) alloca (length);
|
||
if (target_read_memory (ptrval, (gdb_byte *) pathname, length) != 0)
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
|
||
/* Check if pathname exists and is not a regular file or directory. If so,
|
||
return an appropriate error code. Same for trying to open directories
|
||
for writing. */
|
||
if (!stat (pathname, &st))
|
||
{
|
||
if (!S_ISREG (st.st_mode) && !S_ISDIR (st.st_mode))
|
||
{
|
||
remote_fileio_reply (-1, FILEIO_ENODEV);
|
||
return;
|
||
}
|
||
if (S_ISDIR (st.st_mode)
|
||
&& ((flags & O_WRONLY) == O_WRONLY || (flags & O_RDWR) == O_RDWR))
|
||
{
|
||
remote_fileio_reply (-1, FILEIO_EISDIR);
|
||
return;
|
||
}
|
||
}
|
||
|
||
remote_fio_no_longjmp = 1;
|
||
fd = gdb_open_cloexec (pathname, flags, mode);
|
||
if (fd < 0)
|
||
{
|
||
remote_fileio_return_errno (-1);
|
||
return;
|
||
}
|
||
|
||
fd = remote_fileio_fd_to_targetfd (fd);
|
||
remote_fileio_return_success (fd);
|
||
}
|
||
|
||
static void
|
||
remote_fileio_func_close (char *buf)
|
||
{
|
||
long num;
|
||
int fd;
|
||
|
||
/* Parameter: file descriptor */
|
||
if (remote_fileio_extract_int (&buf, &num))
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
fd = remote_fileio_map_fd ((int) num);
|
||
if (fd == FIO_FD_INVALID)
|
||
{
|
||
remote_fileio_badfd ();
|
||
return;
|
||
}
|
||
|
||
remote_fio_no_longjmp = 1;
|
||
if (fd != FIO_FD_CONSOLE_IN && fd != FIO_FD_CONSOLE_OUT && close (fd))
|
||
remote_fileio_return_errno (-1);
|
||
remote_fileio_close_target_fd ((int) num);
|
||
remote_fileio_return_success (0);
|
||
}
|
||
|
||
static void
|
||
remote_fileio_func_read (char *buf)
|
||
{
|
||
long target_fd, num;
|
||
LONGEST lnum;
|
||
CORE_ADDR ptrval;
|
||
int fd, ret;
|
||
gdb_byte *buffer;
|
||
size_t length;
|
||
off_t old_offset, new_offset;
|
||
|
||
/* 1. Parameter: file descriptor */
|
||
if (remote_fileio_extract_int (&buf, &target_fd))
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
fd = remote_fileio_map_fd ((int) target_fd);
|
||
if (fd == FIO_FD_INVALID)
|
||
{
|
||
remote_fileio_badfd ();
|
||
return;
|
||
}
|
||
/* 2. Parameter: buffer pointer */
|
||
if (remote_fileio_extract_long (&buf, &lnum))
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
ptrval = (CORE_ADDR) lnum;
|
||
/* 3. Parameter: buffer length */
|
||
if (remote_fileio_extract_int (&buf, &num))
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
length = (size_t) num;
|
||
|
||
switch (fd)
|
||
{
|
||
case FIO_FD_CONSOLE_OUT:
|
||
remote_fileio_badfd ();
|
||
return;
|
||
case FIO_FD_CONSOLE_IN:
|
||
{
|
||
static char *remaining_buf = NULL;
|
||
static int remaining_length = 0;
|
||
|
||
buffer = (gdb_byte *) xmalloc (16384);
|
||
if (remaining_buf)
|
||
{
|
||
remote_fio_no_longjmp = 1;
|
||
if (remaining_length > length)
|
||
{
|
||
memcpy (buffer, remaining_buf, length);
|
||
memmove (remaining_buf, remaining_buf + length,
|
||
remaining_length - length);
|
||
remaining_length -= length;
|
||
ret = length;
|
||
}
|
||
else
|
||
{
|
||
memcpy (buffer, remaining_buf, remaining_length);
|
||
xfree (remaining_buf);
|
||
remaining_buf = NULL;
|
||
ret = remaining_length;
|
||
}
|
||
}
|
||
else
|
||
{
|
||
/* Windows (at least XP and Server 2003) has difficulty
|
||
with large reads from consoles. If a handle is
|
||
backed by a real console device, overly large reads
|
||
from the handle will fail and set errno == ENOMEM.
|
||
On a Windows Server 2003 system where I tested,
|
||
reading 26608 bytes from the console was OK, but
|
||
anything above 26609 bytes would fail. The limit has
|
||
been observed to vary on different systems. So, we
|
||
limit this read to something smaller than that - by a
|
||
safe margin, in case the limit depends on system
|
||
resources or version. */
|
||
ret = ui_file_read (gdb_stdtargin, (char *) buffer, 16383);
|
||
remote_fio_no_longjmp = 1;
|
||
if (ret > 0 && (size_t)ret > length)
|
||
{
|
||
remaining_buf = (char *) xmalloc (ret - length);
|
||
remaining_length = ret - length;
|
||
memcpy (remaining_buf, buffer + length, remaining_length);
|
||
ret = length;
|
||
}
|
||
}
|
||
}
|
||
break;
|
||
default:
|
||
buffer = (gdb_byte *) xmalloc (length);
|
||
/* POSIX defines EINTR behaviour of read in a weird way. It's allowed
|
||
for read() to return -1 even if "some" bytes have been read. It
|
||
has been corrected in SUSv2 but that doesn't help us much...
|
||
Therefore a complete solution must check how many bytes have been
|
||
read on EINTR to return a more reliable value to the target */
|
||
old_offset = lseek (fd, 0, SEEK_CUR);
|
||
remote_fio_no_longjmp = 1;
|
||
ret = read (fd, buffer, length);
|
||
if (ret < 0 && errno == EINTR)
|
||
{
|
||
new_offset = lseek (fd, 0, SEEK_CUR);
|
||
/* If some data has been read, return the number of bytes read.
|
||
The Ctrl-C flag is set in remote_fileio_reply() anyway. */
|
||
if (old_offset != new_offset)
|
||
ret = new_offset - old_offset;
|
||
}
|
||
break;
|
||
}
|
||
|
||
if (ret > 0)
|
||
{
|
||
errno = target_write_memory (ptrval, buffer, ret);
|
||
if (errno != 0)
|
||
ret = -1;
|
||
}
|
||
|
||
if (ret < 0)
|
||
remote_fileio_return_errno (-1);
|
||
else
|
||
remote_fileio_return_success (ret);
|
||
|
||
xfree (buffer);
|
||
}
|
||
|
||
static void
|
||
remote_fileio_func_write (char *buf)
|
||
{
|
||
long target_fd, num;
|
||
LONGEST lnum;
|
||
CORE_ADDR ptrval;
|
||
int fd, ret;
|
||
gdb_byte *buffer;
|
||
size_t length;
|
||
|
||
/* 1. Parameter: file descriptor */
|
||
if (remote_fileio_extract_int (&buf, &target_fd))
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
fd = remote_fileio_map_fd ((int) target_fd);
|
||
if (fd == FIO_FD_INVALID)
|
||
{
|
||
remote_fileio_badfd ();
|
||
return;
|
||
}
|
||
/* 2. Parameter: buffer pointer */
|
||
if (remote_fileio_extract_long (&buf, &lnum))
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
ptrval = (CORE_ADDR) lnum;
|
||
/* 3. Parameter: buffer length */
|
||
if (remote_fileio_extract_int (&buf, &num))
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
length = (size_t) num;
|
||
|
||
buffer = (gdb_byte *) xmalloc (length);
|
||
if (target_read_memory (ptrval, buffer, length) != 0)
|
||
{
|
||
xfree (buffer);
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
|
||
remote_fio_no_longjmp = 1;
|
||
switch (fd)
|
||
{
|
||
case FIO_FD_CONSOLE_IN:
|
||
remote_fileio_badfd ();
|
||
xfree (buffer);
|
||
return;
|
||
case FIO_FD_CONSOLE_OUT:
|
||
ui_file_write (target_fd == 1 ? gdb_stdtarg : gdb_stdtargerr,
|
||
(char *) buffer, length);
|
||
gdb_flush (target_fd == 1 ? gdb_stdtarg : gdb_stdtargerr);
|
||
ret = length;
|
||
break;
|
||
default:
|
||
ret = write (fd, buffer, length);
|
||
if (ret < 0 && errno == EACCES)
|
||
errno = EBADF; /* Cygwin returns EACCESS when writing to a
|
||
R/O file. */
|
||
break;
|
||
}
|
||
|
||
if (ret < 0)
|
||
remote_fileio_return_errno (-1);
|
||
else
|
||
remote_fileio_return_success (ret);
|
||
|
||
xfree (buffer);
|
||
}
|
||
|
||
static void
|
||
remote_fileio_func_lseek (char *buf)
|
||
{
|
||
long num;
|
||
LONGEST lnum;
|
||
int fd, flag;
|
||
off_t offset, ret;
|
||
|
||
/* 1. Parameter: file descriptor */
|
||
if (remote_fileio_extract_int (&buf, &num))
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
fd = remote_fileio_map_fd ((int) num);
|
||
if (fd == FIO_FD_INVALID)
|
||
{
|
||
remote_fileio_badfd ();
|
||
return;
|
||
}
|
||
else if (fd == FIO_FD_CONSOLE_IN || fd == FIO_FD_CONSOLE_OUT)
|
||
{
|
||
remote_fileio_reply (-1, FILEIO_ESPIPE);
|
||
return;
|
||
}
|
||
|
||
/* 2. Parameter: offset */
|
||
if (remote_fileio_extract_long (&buf, &lnum))
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
offset = (off_t) lnum;
|
||
/* 3. Parameter: flag */
|
||
if (remote_fileio_extract_int (&buf, &num))
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
if (remote_fileio_seek_flag_to_host (num, &flag))
|
||
{
|
||
remote_fileio_reply (-1, FILEIO_EINVAL);
|
||
return;
|
||
}
|
||
|
||
remote_fio_no_longjmp = 1;
|
||
ret = lseek (fd, offset, flag);
|
||
|
||
if (ret == (off_t) -1)
|
||
remote_fileio_return_errno (-1);
|
||
else
|
||
remote_fileio_return_success (ret);
|
||
}
|
||
|
||
static void
|
||
remote_fileio_func_rename (char *buf)
|
||
{
|
||
CORE_ADDR old_ptr, new_ptr;
|
||
int old_len, new_len;
|
||
char *oldpath, *newpath;
|
||
int ret, of, nf;
|
||
struct stat ost, nst;
|
||
|
||
/* 1. Parameter: Ptr to oldpath / length incl. trailing zero */
|
||
if (remote_fileio_extract_ptr_w_len (&buf, &old_ptr, &old_len))
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
|
||
/* 2. Parameter: Ptr to newpath / length incl. trailing zero */
|
||
if (remote_fileio_extract_ptr_w_len (&buf, &new_ptr, &new_len))
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
|
||
/* Request oldpath using 'm' packet */
|
||
oldpath = (char *) alloca (old_len);
|
||
if (target_read_memory (old_ptr, (gdb_byte *) oldpath, old_len) != 0)
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
|
||
/* Request newpath using 'm' packet */
|
||
newpath = (char *) alloca (new_len);
|
||
if (target_read_memory (new_ptr, (gdb_byte *) newpath, new_len) != 0)
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
|
||
/* Only operate on regular files and directories. */
|
||
of = stat (oldpath, &ost);
|
||
nf = stat (newpath, &nst);
|
||
if ((!of && !S_ISREG (ost.st_mode) && !S_ISDIR (ost.st_mode))
|
||
|| (!nf && !S_ISREG (nst.st_mode) && !S_ISDIR (nst.st_mode)))
|
||
{
|
||
remote_fileio_reply (-1, FILEIO_EACCES);
|
||
return;
|
||
}
|
||
|
||
remote_fio_no_longjmp = 1;
|
||
ret = rename (oldpath, newpath);
|
||
|
||
if (ret == -1)
|
||
{
|
||
/* Special case: newpath is a non-empty directory. Some systems
|
||
return ENOTEMPTY, some return EEXIST. We coerce that to be
|
||
always EEXIST. */
|
||
if (errno == ENOTEMPTY)
|
||
errno = EEXIST;
|
||
#ifdef __CYGWIN__
|
||
/* Workaround some Cygwin problems with correct errnos. */
|
||
if (errno == EACCES)
|
||
{
|
||
if (!of && !nf && S_ISDIR (nst.st_mode))
|
||
{
|
||
if (S_ISREG (ost.st_mode))
|
||
errno = EISDIR;
|
||
else
|
||
{
|
||
char oldfullpath[PATH_MAX];
|
||
char newfullpath[PATH_MAX];
|
||
int len;
|
||
|
||
cygwin_conv_path (CCP_WIN_A_TO_POSIX, oldpath, oldfullpath,
|
||
PATH_MAX);
|
||
cygwin_conv_path (CCP_WIN_A_TO_POSIX, newpath, newfullpath,
|
||
PATH_MAX);
|
||
len = strlen (oldfullpath);
|
||
if (IS_DIR_SEPARATOR (newfullpath[len])
|
||
&& !filename_ncmp (oldfullpath, newfullpath, len))
|
||
errno = EINVAL;
|
||
else
|
||
errno = EEXIST;
|
||
}
|
||
}
|
||
}
|
||
#endif
|
||
|
||
remote_fileio_return_errno (-1);
|
||
}
|
||
else
|
||
remote_fileio_return_success (ret);
|
||
}
|
||
|
||
static void
|
||
remote_fileio_func_unlink (char *buf)
|
||
{
|
||
CORE_ADDR ptrval;
|
||
int length;
|
||
char *pathname;
|
||
int ret;
|
||
struct stat st;
|
||
|
||
/* Parameter: Ptr to pathname / length incl. trailing zero */
|
||
if (remote_fileio_extract_ptr_w_len (&buf, &ptrval, &length))
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
/* Request pathname using 'm' packet */
|
||
pathname = (char *) alloca (length);
|
||
if (target_read_memory (ptrval, (gdb_byte *) pathname, length) != 0)
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
|
||
/* Only operate on regular files (and directories, which allows to return
|
||
the correct return code). */
|
||
if (!stat (pathname, &st) && !S_ISREG (st.st_mode) && !S_ISDIR (st.st_mode))
|
||
{
|
||
remote_fileio_reply (-1, FILEIO_ENODEV);
|
||
return;
|
||
}
|
||
|
||
remote_fio_no_longjmp = 1;
|
||
ret = unlink (pathname);
|
||
|
||
if (ret == -1)
|
||
remote_fileio_return_errno (-1);
|
||
else
|
||
remote_fileio_return_success (ret);
|
||
}
|
||
|
||
static void
|
||
remote_fileio_func_stat (char *buf)
|
||
{
|
||
CORE_ADDR statptr, nameptr;
|
||
int ret, namelength;
|
||
char *pathname;
|
||
LONGEST lnum;
|
||
struct stat st;
|
||
struct fio_stat fst;
|
||
|
||
/* 1. Parameter: Ptr to pathname / length incl. trailing zero */
|
||
if (remote_fileio_extract_ptr_w_len (&buf, &nameptr, &namelength))
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
|
||
/* 2. Parameter: Ptr to struct stat */
|
||
if (remote_fileio_extract_long (&buf, &lnum))
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
statptr = (CORE_ADDR) lnum;
|
||
|
||
/* Request pathname using 'm' packet */
|
||
pathname = (char *) alloca (namelength);
|
||
if (target_read_memory (nameptr, (gdb_byte *) pathname, namelength) != 0)
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
|
||
remote_fio_no_longjmp = 1;
|
||
ret = stat (pathname, &st);
|
||
|
||
if (ret == -1)
|
||
{
|
||
remote_fileio_return_errno (-1);
|
||
return;
|
||
}
|
||
/* Only operate on regular files and directories. */
|
||
if (!ret && !S_ISREG (st.st_mode) && !S_ISDIR (st.st_mode))
|
||
{
|
||
remote_fileio_reply (-1, FILEIO_EACCES);
|
||
return;
|
||
}
|
||
if (statptr)
|
||
{
|
||
host_to_fileio_stat (&st, &fst);
|
||
host_to_fileio_uint (0, fst.fst_dev);
|
||
|
||
errno = target_write_memory (statptr, (gdb_byte *) &fst, sizeof fst);
|
||
if (errno != 0)
|
||
{
|
||
remote_fileio_return_errno (-1);
|
||
return;
|
||
}
|
||
}
|
||
remote_fileio_return_success (ret);
|
||
}
|
||
|
||
static void
|
||
remote_fileio_func_fstat (char *buf)
|
||
{
|
||
CORE_ADDR ptrval;
|
||
int fd, ret;
|
||
long target_fd;
|
||
LONGEST lnum;
|
||
struct stat st;
|
||
struct fio_stat fst;
|
||
struct timeval tv;
|
||
|
||
/* 1. Parameter: file descriptor */
|
||
if (remote_fileio_extract_int (&buf, &target_fd))
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
fd = remote_fileio_map_fd ((int) target_fd);
|
||
if (fd == FIO_FD_INVALID)
|
||
{
|
||
remote_fileio_badfd ();
|
||
return;
|
||
}
|
||
/* 2. Parameter: Ptr to struct stat */
|
||
if (remote_fileio_extract_long (&buf, &lnum))
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
ptrval = (CORE_ADDR) lnum;
|
||
|
||
remote_fio_no_longjmp = 1;
|
||
if (fd == FIO_FD_CONSOLE_IN || fd == FIO_FD_CONSOLE_OUT)
|
||
{
|
||
host_to_fileio_uint (1, fst.fst_dev);
|
||
memset (&st, 0, sizeof (st));
|
||
st.st_mode = S_IFCHR | (fd == FIO_FD_CONSOLE_IN ? S_IRUSR : S_IWUSR);
|
||
st.st_nlink = 1;
|
||
#ifdef HAVE_GETUID
|
||
st.st_uid = getuid ();
|
||
#endif
|
||
#ifdef HAVE_GETGID
|
||
st.st_gid = getgid ();
|
||
#endif
|
||
#ifdef HAVE_STRUCT_STAT_ST_BLKSIZE
|
||
st.st_blksize = 512;
|
||
#endif
|
||
#if HAVE_STRUCT_STAT_ST_BLOCKS
|
||
st.st_blocks = 0;
|
||
#endif
|
||
if (!gettimeofday (&tv, NULL))
|
||
st.st_atime = st.st_mtime = st.st_ctime = tv.tv_sec;
|
||
else
|
||
st.st_atime = st.st_mtime = st.st_ctime = (time_t) 0;
|
||
ret = 0;
|
||
}
|
||
else
|
||
ret = fstat (fd, &st);
|
||
|
||
if (ret == -1)
|
||
{
|
||
remote_fileio_return_errno (-1);
|
||
return;
|
||
}
|
||
if (ptrval)
|
||
{
|
||
host_to_fileio_stat (&st, &fst);
|
||
|
||
errno = target_write_memory (ptrval, (gdb_byte *) &fst, sizeof fst);
|
||
if (errno != 0)
|
||
{
|
||
remote_fileio_return_errno (-1);
|
||
return;
|
||
}
|
||
}
|
||
remote_fileio_return_success (ret);
|
||
}
|
||
|
||
static void
|
||
remote_fileio_func_gettimeofday (char *buf)
|
||
{
|
||
LONGEST lnum;
|
||
CORE_ADDR ptrval;
|
||
int ret;
|
||
struct timeval tv;
|
||
struct fio_timeval ftv;
|
||
|
||
/* 1. Parameter: struct timeval pointer */
|
||
if (remote_fileio_extract_long (&buf, &lnum))
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
ptrval = (CORE_ADDR) lnum;
|
||
/* 2. Parameter: some pointer value... */
|
||
if (remote_fileio_extract_long (&buf, &lnum))
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
/* ...which has to be NULL. */
|
||
if (lnum)
|
||
{
|
||
remote_fileio_reply (-1, FILEIO_EINVAL);
|
||
return;
|
||
}
|
||
|
||
remote_fio_no_longjmp = 1;
|
||
ret = gettimeofday (&tv, NULL);
|
||
|
||
if (ret == -1)
|
||
{
|
||
remote_fileio_return_errno (-1);
|
||
return;
|
||
}
|
||
|
||
if (ptrval)
|
||
{
|
||
remote_fileio_to_fio_timeval (&tv, &ftv);
|
||
|
||
errno = target_write_memory (ptrval, (gdb_byte *) &ftv, sizeof ftv);
|
||
if (errno != 0)
|
||
{
|
||
remote_fileio_return_errno (-1);
|
||
return;
|
||
}
|
||
}
|
||
remote_fileio_return_success (ret);
|
||
}
|
||
|
||
static void
|
||
remote_fileio_func_isatty (char *buf)
|
||
{
|
||
long target_fd;
|
||
int fd;
|
||
|
||
/* Parameter: file descriptor */
|
||
if (remote_fileio_extract_int (&buf, &target_fd))
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
remote_fio_no_longjmp = 1;
|
||
fd = remote_fileio_map_fd ((int) target_fd);
|
||
remote_fileio_return_success (fd == FIO_FD_CONSOLE_IN ||
|
||
fd == FIO_FD_CONSOLE_OUT ? 1 : 0);
|
||
}
|
||
|
||
static void
|
||
remote_fileio_func_system (char *buf)
|
||
{
|
||
CORE_ADDR ptrval;
|
||
int ret, length;
|
||
char *cmdline = NULL;
|
||
|
||
/* Parameter: Ptr to commandline / length incl. trailing zero */
|
||
if (remote_fileio_extract_ptr_w_len (&buf, &ptrval, &length))
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
|
||
if (length)
|
||
{
|
||
/* Request commandline using 'm' packet */
|
||
cmdline = (char *) alloca (length);
|
||
if (target_read_memory (ptrval, (gdb_byte *) cmdline, length) != 0)
|
||
{
|
||
remote_fileio_ioerror ();
|
||
return;
|
||
}
|
||
}
|
||
|
||
/* Check if system(3) has been explicitely allowed using the
|
||
`set remote system-call-allowed 1' command. If length is 0,
|
||
indicating a NULL parameter to the system call, return zero to
|
||
indicate a shell is not available. Otherwise fail with EPERM. */
|
||
if (!remote_fio_system_call_allowed)
|
||
{
|
||
if (!length)
|
||
remote_fileio_return_success (0);
|
||
else
|
||
remote_fileio_reply (-1, FILEIO_EPERM);
|
||
return;
|
||
}
|
||
|
||
remote_fio_no_longjmp = 1;
|
||
ret = system (cmdline);
|
||
|
||
if (!length)
|
||
remote_fileio_return_success (ret);
|
||
else if (ret == -1)
|
||
remote_fileio_return_errno (-1);
|
||
else
|
||
remote_fileio_return_success (WEXITSTATUS (ret));
|
||
}
|
||
|
||
static struct {
|
||
char *name;
|
||
void (*func)(char *);
|
||
} remote_fio_func_map[] = {
|
||
{ "open", remote_fileio_func_open },
|
||
{ "close", remote_fileio_func_close },
|
||
{ "read", remote_fileio_func_read },
|
||
{ "write", remote_fileio_func_write },
|
||
{ "lseek", remote_fileio_func_lseek },
|
||
{ "rename", remote_fileio_func_rename },
|
||
{ "unlink", remote_fileio_func_unlink },
|
||
{ "stat", remote_fileio_func_stat },
|
||
{ "fstat", remote_fileio_func_fstat },
|
||
{ "gettimeofday", remote_fileio_func_gettimeofday },
|
||
{ "isatty", remote_fileio_func_isatty },
|
||
{ "system", remote_fileio_func_system },
|
||
{ NULL, NULL }
|
||
};
|
||
|
||
static int
|
||
do_remote_fileio_request (struct ui_out *uiout, void *buf_arg)
|
||
{
|
||
char *buf = buf_arg;
|
||
char *c;
|
||
int idx;
|
||
|
||
remote_fileio_sig_set (remote_fileio_ctrl_c_signal_handler);
|
||
|
||
c = strchr (++buf, ',');
|
||
if (c)
|
||
*c++ = '\0';
|
||
else
|
||
c = strchr (buf, '\0');
|
||
for (idx = 0; remote_fio_func_map[idx].name; ++idx)
|
||
if (!strcmp (remote_fio_func_map[idx].name, buf))
|
||
break;
|
||
if (!remote_fio_func_map[idx].name) /* ERROR: No such function. */
|
||
return RETURN_ERROR;
|
||
remote_fio_func_map[idx].func (c);
|
||
return 0;
|
||
}
|
||
|
||
/* Close any open descriptors, and reinitialize the file mapping. */
|
||
|
||
void
|
||
remote_fileio_reset (void)
|
||
{
|
||
int ix;
|
||
|
||
for (ix = 0; ix != remote_fio_data.fd_map_size; ix++)
|
||
{
|
||
int fd = remote_fio_data.fd_map[ix];
|
||
|
||
if (fd >= 0)
|
||
close (fd);
|
||
}
|
||
if (remote_fio_data.fd_map)
|
||
{
|
||
xfree (remote_fio_data.fd_map);
|
||
remote_fio_data.fd_map = NULL;
|
||
remote_fio_data.fd_map_size = 0;
|
||
}
|
||
}
|
||
|
||
/* Handle a file I/O request. BUF points to the packet containing the
|
||
request. CTRLC_PENDING_P should be nonzero if the target has not
|
||
acknowledged the Ctrl-C sent asynchronously earlier. */
|
||
|
||
void
|
||
remote_fileio_request (char *buf, int ctrlc_pending_p)
|
||
{
|
||
int ex;
|
||
|
||
remote_fileio_sig_init ();
|
||
|
||
if (ctrlc_pending_p)
|
||
{
|
||
/* If the target hasn't responded to the Ctrl-C sent
|
||
asynchronously earlier, take this opportunity to send the
|
||
Ctrl-C synchronously. */
|
||
remote_fio_ctrl_c_flag = 1;
|
||
remote_fio_no_longjmp = 0;
|
||
remote_fileio_reply (-1, FILEIO_EINTR);
|
||
}
|
||
else
|
||
{
|
||
remote_fio_ctrl_c_flag = 0;
|
||
remote_fio_no_longjmp = 0;
|
||
|
||
ex = catch_exceptions (current_uiout,
|
||
do_remote_fileio_request, (void *)buf,
|
||
RETURN_MASK_ALL);
|
||
switch (ex)
|
||
{
|
||
case RETURN_ERROR:
|
||
remote_fileio_reply (-1, FILEIO_ENOSYS);
|
||
break;
|
||
case RETURN_QUIT:
|
||
remote_fileio_reply (-1, FILEIO_EINTR);
|
||
break;
|
||
default:
|
||
break;
|
||
}
|
||
}
|
||
|
||
remote_fileio_sig_exit ();
|
||
}
|
||
|
||
|
||
/* Unpack an fio_uint_t. */
|
||
|
||
static unsigned int
|
||
remote_fileio_to_host_uint (fio_uint_t fnum)
|
||
{
|
||
return extract_unsigned_integer ((gdb_byte *) fnum, 4,
|
||
BFD_ENDIAN_BIG);
|
||
}
|
||
|
||
/* Unpack an fio_ulong_t. */
|
||
|
||
static ULONGEST
|
||
remote_fileio_to_host_ulong (fio_ulong_t fnum)
|
||
{
|
||
return extract_unsigned_integer ((gdb_byte *) fnum, 8,
|
||
BFD_ENDIAN_BIG);
|
||
}
|
||
|
||
/* Unpack an fio_mode_t. */
|
||
|
||
static mode_t
|
||
remote_fileio_to_host_mode (fio_mode_t fnum)
|
||
{
|
||
return remote_fileio_mode_to_host (remote_fileio_to_host_uint (fnum),
|
||
0);
|
||
}
|
||
|
||
/* Unpack an fio_time_t. */
|
||
|
||
static time_t
|
||
remote_fileio_to_host_time (fio_time_t fnum)
|
||
{
|
||
return remote_fileio_to_host_uint (fnum);
|
||
}
|
||
|
||
|
||
/* See remote-fileio.h. */
|
||
|
||
void
|
||
remote_fileio_to_host_stat (struct fio_stat *fst, struct stat *st)
|
||
{
|
||
memset (st, 0, sizeof (struct stat));
|
||
|
||
st->st_dev = remote_fileio_to_host_uint (fst->fst_dev);
|
||
st->st_ino = remote_fileio_to_host_uint (fst->fst_ino);
|
||
st->st_mode = remote_fileio_to_host_mode (fst->fst_mode);
|
||
st->st_nlink = remote_fileio_to_host_uint (fst->fst_nlink);
|
||
st->st_uid = remote_fileio_to_host_uint (fst->fst_uid);
|
||
st->st_gid = remote_fileio_to_host_uint (fst->fst_gid);
|
||
st->st_rdev = remote_fileio_to_host_uint (fst->fst_rdev);
|
||
st->st_size = remote_fileio_to_host_ulong (fst->fst_size);
|
||
#ifdef HAVE_STRUCT_STAT_ST_BLKSIZE
|
||
st->st_blksize = remote_fileio_to_host_ulong (fst->fst_blksize);
|
||
#endif
|
||
#if HAVE_STRUCT_STAT_ST_BLOCKS
|
||
st->st_blocks = remote_fileio_to_host_ulong (fst->fst_blocks);
|
||
#endif
|
||
st->st_atime = remote_fileio_to_host_time (fst->fst_atime);
|
||
st->st_mtime = remote_fileio_to_host_time (fst->fst_mtime);
|
||
st->st_ctime = remote_fileio_to_host_time (fst->fst_ctime);
|
||
}
|
||
|
||
|
||
static void
|
||
set_system_call_allowed (char *args, int from_tty)
|
||
{
|
||
if (args)
|
||
{
|
||
char *arg_end;
|
||
int val = strtoul (args, &arg_end, 10);
|
||
|
||
if (*args && *arg_end == '\0')
|
||
{
|
||
remote_fio_system_call_allowed = !!val;
|
||
return;
|
||
}
|
||
}
|
||
error (_("Illegal argument for \"set remote system-call-allowed\" command"));
|
||
}
|
||
|
||
static void
|
||
show_system_call_allowed (char *args, int from_tty)
|
||
{
|
||
if (args)
|
||
error (_("Garbage after \"show remote "
|
||
"system-call-allowed\" command: `%s'"), args);
|
||
printf_unfiltered ("Calling host system(3) call from target is %sallowed\n",
|
||
remote_fio_system_call_allowed ? "" : "not ");
|
||
}
|
||
|
||
void
|
||
initialize_remote_fileio (struct cmd_list_element *remote_set_cmdlist,
|
||
struct cmd_list_element *remote_show_cmdlist)
|
||
{
|
||
sigint_fileio_token =
|
||
create_async_signal_handler (async_remote_fileio_interrupt, NULL);
|
||
|
||
add_cmd ("system-call-allowed", no_class,
|
||
set_system_call_allowed,
|
||
_("Set if the host system(3) call is allowed for the target."),
|
||
&remote_set_cmdlist);
|
||
add_cmd ("system-call-allowed", no_class,
|
||
show_system_call_allowed,
|
||
_("Show if the host system(3) call is allowed for the target."),
|
||
&remote_show_cmdlist);
|
||
}
|