Files
binutils-gdb/gdb/cli/cli-setshow.c
Lancelot SIX 1d7fe7f01b gdb: Introduce setting construct within cmd_list_element
cmd_list_element can contain a pointer to data that can be set and / or
shown.  This is achieved with the void* VAR member which points to the
data that can be accessed, while the VAR_TYPE member (of type enum
var_types) indicates how to interpret the data pointed to.

With this pattern, the user of the cmd_list_element needs to know what
is the storage type associated with a given VAR_TYPES in order to do
the proper casting.  No automatic safeguard is available to prevent
miss-use of the pointer.  Client code typically looks something like:

	switch (c->var_type)
	{
	  case var_zuinteger:
	    unsigned int v = *(unsigned int*) c->var;
	    ...
	    break;
	  case var_boolean:
	    bool v = *(bool *) c->var;
	    ...
	    break;
	  ...
	}

This patch proposes to add an abstraction around the var_types and void*
pointer pair.  The abstraction is meant to prevent the user from having
to handle the cast and verify that the data is read or written as a type
that is coherent with the setting's var_type.  This is achieved by
introducing the struct setting which exposes a set of templated get /
set member functions.  The template parameter is the type of the
variable that holds the referred variable.

Using those accessors allows runtime checks to be inserted in order to
ensure that the data pointed to has the expected type.  For example,
instantiating the member functions with bool will yield something
similar to:

	const bool &get<bool> () const
	{
	  gdb_assert (m_var_type == var_boolean);
	  gdb_assert (m_var != nullptr);
	  return *static_cast<bool *> (m_var);
	}
	void set<bool> (const bool &var)
	{
	  gdb_assert (m_var_type == var_boolean);
	  gdb_assert (m_var != nullptr);
	  *static_cast<bool *> (m_var) = var;
	}

Using the new abstraction, our initial example becomes:

	switch (c->var_type)
	{
	  case var_zuinteger:
	    unsigned int v = c->var->get<unsigned int> ();
	    ...
	    break;
	  case var_boolean:
	    bool v = c->var->get<bool> ();
	    ...
	    break;
	  ...
	}

While the call site is still similar, the introduction of runtime checks
help ensure correct usage of the data.

In order to avoid turning the bulk of add_setshow_cmd_full into a
templated function, and following a suggestion from Pedro Alves, a
setting can be constructed from a pre validated type erased reference to
a variable.  This is what setting::erased_args is used for.

Introducing an opaque abstraction to describe a setting will also make
it possible to use callbacks to retrieve or set the value of the setting
on the fly instead of pointing to a static chunk of memory.  This will
be done added in a later commit.

Given that a cmd_list_element may or may not reference a setting, the
VAR and VAR_TYPES members of the struct are replaced with a
gdb::optional<setting> named VAR.

Few internal function signatures have been modified to take into account
this new abstraction:

-The functions value_from_setting, str_value_from_setting and
 get_setshow_command_value_string used to have a 'cmd_list_element *'
 parameter but only used it for the VAR and VAR_TYPE member. They now
 take a 'const setting &' parameter instead.
- Similarly, the 'void *' and a 'enum var_types' parameters of
  pascm_param_value and gdbpy_parameter_value have been replaced with a
  'const setting &' parameter.

No user visible change is expected after this patch.

Tested on GNU/Linux x86_64, with no regression noticed.

Co-authored-by: Simon Marchi <simon.marchi@polymtl.ca>
Change-Id: Ie1d08c3ceb8b30b3d7bf1efe036eb8acffcd2f34
2021-10-03 17:53:16 +01:00

821 lines
19 KiB
C
Raw Blame History

This file contains invisible Unicode characters

This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

/* Handle set and show GDB commands.
Copyright (C) 2000-2021 Free Software Foundation, Inc.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "defs.h"
#include "readline/tilde.h"
#include "value.h"
#include <ctype.h>
#include "arch-utils.h"
#include "observable.h"
#include "ui-out.h"
#include "cli/cli-decode.h"
#include "cli/cli-cmds.h"
#include "cli/cli-setshow.h"
#include "cli/cli-utils.h"
/* Return true if the change of command parameter should be notified. */
static bool
notify_command_param_changed_p (bool param_changed, struct cmd_list_element *c)
{
if (!param_changed)
return false;
if (c->theclass == class_maintenance || c->theclass == class_deprecated
|| c->theclass == class_obscure)
return false;
return true;
}
static enum auto_boolean
parse_auto_binary_operation (const char *arg)
{
if (arg != NULL && *arg != '\0')
{
int length = strlen (arg);
while (isspace (arg[length - 1]) && length > 0)
length--;
/* Note that "o" is ambiguous. */
if ((length == 2 && strncmp (arg, "on", length) == 0)
|| strncmp (arg, "1", length) == 0
|| strncmp (arg, "yes", length) == 0
|| strncmp (arg, "enable", length) == 0)
return AUTO_BOOLEAN_TRUE;
else if ((length >= 2 && strncmp (arg, "off", length) == 0)
|| strncmp (arg, "0", length) == 0
|| strncmp (arg, "no", length) == 0
|| strncmp (arg, "disable", length) == 0)
return AUTO_BOOLEAN_FALSE;
else if (strncmp (arg, "auto", length) == 0
|| (length > 1 && strncmp (arg, "-1", length) == 0))
return AUTO_BOOLEAN_AUTO;
}
error (_("\"on\", \"off\" or \"auto\" expected."));
return AUTO_BOOLEAN_AUTO; /* Pacify GCC. */
}
/* See cli-setshow.h. */
int
parse_cli_boolean_value (const char **arg)
{
const char *p = skip_to_space (*arg);
size_t length = p - *arg;
/* Note that "o" is ambiguous. */
if ((length == 2 && strncmp (*arg, "on", length) == 0)
|| strncmp (*arg, "1", length) == 0
|| strncmp (*arg, "yes", length) == 0
|| strncmp (*arg, "enable", length) == 0)
{
*arg = skip_spaces (*arg + length);
return 1;
}
else if ((length >= 2 && strncmp (*arg, "off", length) == 0)
|| strncmp (*arg, "0", length) == 0
|| strncmp (*arg, "no", length) == 0
|| strncmp (*arg, "disable", length) == 0)
{
*arg = skip_spaces (*arg + length);
return 0;
}
else
return -1;
}
/* See cli-setshow.h. */
int
parse_cli_boolean_value (const char *arg)
{
if (!arg || !*arg)
return 1;
int b = parse_cli_boolean_value (&arg);
if (b >= 0 && *arg != '\0')
return -1;
return b;
}
void
deprecated_show_value_hack (struct ui_file *ignore_file,
int ignore_from_tty,
struct cmd_list_element *c,
const char *value)
{
/* If there's no command or value, don't try to print it out. */
if (c == NULL || value == NULL)
return;
/* Print doc minus "Show " at start. Tell print_doc_line that
this is for a 'show value' prefix. */
print_doc_line (gdb_stdout, c->doc + 5, true);
gdb_assert (c->var.has_value ());
switch (c->var->type ())
{
case var_string:
case var_string_noescape:
case var_optional_filename:
case var_filename:
case var_enum:
printf_filtered ((" is \"%s\".\n"), value);
break;
default:
printf_filtered ((" is %s.\n"), value);
break;
}
}
/* Returns true if ARG is "unlimited". */
static bool
is_unlimited_literal (const char **arg, bool expression)
{
*arg = skip_spaces (*arg);
const char *unl_start = *arg;
const char *p = skip_to_space (*arg);
size_t len = p - *arg;
if (len > 0 && strncmp ("unlimited", *arg, len) == 0)
{
*arg += len;
/* If parsing an expression (i.e., parsing for a "set" command),
anything after "unlimited" is junk. For options, anything
after "unlimited" might be a command argument or another
option. */
if (expression)
{
const char *after = skip_spaces (*arg);
if (*after != '\0')
error (_("Junk after \"%.*s\": %s"),
(int) len, unl_start, after);
}
return true;
}
return false;
}
/* See cli-setshow.h. */
unsigned int
parse_cli_var_uinteger (var_types var_type, const char **arg,
bool expression)
{
LONGEST val;
if (*arg == nullptr || **arg == '\0')
{
if (var_type == var_uinteger)
error_no_arg (_("integer to set it to, or \"unlimited\"."));
else
error_no_arg (_("integer to set it to."));
}
if (var_type == var_uinteger && is_unlimited_literal (arg, expression))
val = 0;
else if (expression)
val = parse_and_eval_long (*arg);
else
val = get_ulongest (arg);
if (var_type == var_uinteger && val == 0)
val = UINT_MAX;
else if (val < 0
/* For var_uinteger, don't let the user set the value
to UINT_MAX directly, as that exposes an
implementation detail to the user interface. */
|| (var_type == var_uinteger && val >= UINT_MAX)
|| (var_type == var_zuinteger && val > UINT_MAX))
error (_("integer %s out of range"), plongest (val));
return val;
}
/* See cli-setshow.h. */
int
parse_cli_var_zuinteger_unlimited (const char **arg, bool expression)
{
LONGEST val;
if (*arg == nullptr || **arg == '\0')
error_no_arg (_("integer to set it to, or \"unlimited\"."));
if (is_unlimited_literal (arg, expression))
val = -1;
else if (expression)
val = parse_and_eval_long (*arg);
else
val = get_ulongest (arg);
if (val > INT_MAX)
error (_("integer %s out of range"), plongest (val));
else if (val < -1)
error (_("only -1 is allowed to set as unlimited"));
return val;
}
/* See cli-setshow.h. */
const char *
parse_cli_var_enum (const char **args, const char *const *enums)
{
/* If no argument was supplied, print an informative error
message. */
if (args == NULL || *args == NULL || **args == '\0')
{
std::string msg;
for (size_t i = 0; enums[i]; i++)
{
if (i != 0)
msg += ", ";
msg += enums[i];
}
error (_("Requires an argument. Valid arguments are %s."),
msg.c_str ());
}
const char *p = skip_to_space (*args);
size_t len = p - *args;
int nmatches = 0;
const char *match = NULL;
for (size_t i = 0; enums[i]; i++)
if (strncmp (*args, enums[i], len) == 0)
{
if (enums[i][len] == '\0')
{
match = enums[i];
nmatches = 1;
break; /* Exact match. */
}
else
{
match = enums[i];
nmatches++;
}
}
if (nmatches == 0)
error (_("Undefined item: \"%.*s\"."), (int) len, *args);
if (nmatches > 1)
error (_("Ambiguous item \"%.*s\"."), (int) len, *args);
*args += len;
return match;
}
/* Do a "set" command. ARG is NULL if no argument, or the
text of the argument, and FROM_TTY is nonzero if this command is
being entered directly by the user (i.e. these are just like any
other command). C is the command list element for the command. */
void
do_set_command (const char *arg, int from_tty, struct cmd_list_element *c)
{
/* A flag to indicate the option is changed or not. */
bool option_changed = false;
gdb_assert (c->type == set_cmd);
if (arg == NULL)
arg = "";
gdb_assert (c->var.has_value ());
switch (c->var->type ())
{
case var_string:
{
char *newobj;
const char *p;
char *q;
int ch;
newobj = (char *) xmalloc (strlen (arg) + 2);
p = arg;
q = newobj;
while ((ch = *p++) != '\000')
{
if (ch == '\\')
{
/* \ at end of argument is used after spaces
so they won't be lost. */
/* This is obsolete now that we no longer strip
trailing whitespace and actually, the backslash
didn't get here in my test, readline or
something did something funky with a backslash
right before a newline. */
if (*p == 0)
break;
ch = parse_escape (get_current_arch (), &p);
if (ch == 0)
break; /* C loses */
else if (ch > 0)
*q++ = ch;
}
else
*q++ = ch;
}
#if 0
if (*(p - 1) != '\\')
*q++ = ' ';
#endif
*q++ = '\0';
newobj = (char *) xrealloc (newobj, q - newobj);
char * const var = c->var->get<char *> ();
if (var == nullptr
|| strcmp (var, newobj) != 0)
{
xfree (var);
c->var->set<char *> (newobj);
option_changed = true;
}
else
xfree (newobj);
}
break;
case var_string_noescape:
{
char * const var = c->var->get<char *> ();
if (var == nullptr
|| strcmp (var, arg) != 0)
{
xfree (var);
c->var->set<char *> (xstrdup (arg));
option_changed = true;
}
}
break;
case var_filename:
if (*arg == '\0')
error_no_arg (_("filename to set it to."));
/* FALLTHROUGH */
case var_optional_filename:
{
char *val = NULL;
if (*arg != '\0')
{
/* Clear trailing whitespace of filename. */
const char *ptr = arg + strlen (arg) - 1;
char *copy;
while (ptr >= arg && (*ptr == ' ' || *ptr == '\t'))
ptr--;
copy = xstrndup (arg, ptr + 1 - arg);
val = tilde_expand (copy);
xfree (copy);
}
else
val = xstrdup ("");
char * const var = c->var->get<char *> ();
if (var == nullptr
|| strcmp (var, val) != 0)
{
xfree (var);
c->var->set<char *> (val);
option_changed = true;
}
else
xfree (val);
}
break;
case var_boolean:
{
int val = parse_cli_boolean_value (arg);
if (val < 0)
error (_("\"on\" or \"off\" expected."));
if (val != c->var->get<bool> ())
{
c->var->set<bool> (val);
option_changed = true;
}
}
break;
case var_auto_boolean:
{
enum auto_boolean val = parse_auto_binary_operation (arg);
if (c->var->get<enum auto_boolean> () != val)
{
c->var->set<enum auto_boolean> (val);
option_changed = true;
}
}
break;
case var_uinteger:
case var_zuinteger:
{
unsigned int val
= parse_cli_var_uinteger (c->var->type (), &arg, true);
if (c->var->get<unsigned int> () != val)
{
c->var->set<unsigned int> (val);
option_changed = true;
}
}
break;
case var_integer:
case var_zinteger:
{
LONGEST val;
if (*arg == '\0')
{
if (c->var->type () == var_integer)
error_no_arg (_("integer to set it to, or \"unlimited\"."));
else
error_no_arg (_("integer to set it to."));
}
if (c->var->type () == var_integer && is_unlimited_literal (&arg, true))
val = 0;
else
val = parse_and_eval_long (arg);
if (val == 0 && c->var->type () == var_integer)
val = INT_MAX;
else if (val < INT_MIN
/* For var_integer, don't let the user set the value
to INT_MAX directly, as that exposes an
implementation detail to the user interface. */
|| (c->var->type () == var_integer && val >= INT_MAX)
|| (c->var->type () == var_zinteger && val > INT_MAX))
error (_("integer %s out of range"), plongest (val));
if (c->var->get<int> () != val)
{
c->var->set<int> (val);
option_changed = true;
}
}
break;
case var_enum:
{
const char *end_arg = arg;
const char *match = parse_cli_var_enum (&end_arg, c->enums);
int len = end_arg - arg;
const char *after = skip_spaces (end_arg);
if (*after != '\0')
error (_("Junk after item \"%.*s\": %s"), len, arg, after);
if (c->var->get<const char *> () != match)
{
c->var->set<const char *> (match);
option_changed = true;
}
}
break;
case var_zuinteger_unlimited:
{
int val = parse_cli_var_zuinteger_unlimited (&arg, true);
if (c->var->get<int> () != val)
{
c->var->set<int> (val);
option_changed = true;
}
}
break;
default:
error (_("gdb internal error: bad var_type in do_setshow_command"));
}
c->func (NULL, from_tty, c);
if (notify_command_param_changed_p (option_changed, c))
{
char *name, *cp;
struct cmd_list_element **cmds;
struct cmd_list_element *p;
int i;
int length = 0;
/* Compute the whole multi-word command options. If user types command
'set foo bar baz on', c->name is 'baz', and GDB can't pass "bar" to
command option change notification, because it is confusing. We can
trace back through field 'prefix' to compute the whole options,
and pass "foo bar baz" to notification. */
for (i = 0, p = c; p != NULL; i++)
{
length += strlen (p->name);
length++;
p = p->prefix;
}
cp = name = (char *) xmalloc (length);
cmds = XNEWVEC (struct cmd_list_element *, i);
/* Track back through filed 'prefix' and cache them in CMDS. */
for (i = 0, p = c; p != NULL; i++)
{
cmds[i] = p;
p = p->prefix;
}
/* Don't trigger any observer notification if subcommands is not
setlist. */
i--;
if (cmds[i]->subcommands != &setlist)
{
xfree (cmds);
xfree (name);
return;
}
/* Traverse them in the reversed order, and copy their names into
NAME. */
for (i--; i >= 0; i--)
{
memcpy (cp, cmds[i]->name, strlen (cmds[i]->name));
cp += strlen (cmds[i]->name);
if (i != 0)
{
cp[0] = ' ';
cp++;
}
}
cp[0] = 0;
xfree (cmds);
switch (c->var->type ())
{
case var_string:
case var_string_noescape:
case var_filename:
case var_optional_filename:
case var_enum:
{
const char *var;
if (c->var->type () == var_enum)
var = c->var->get<const char *> ();
else
var = c->var->get<char *> ();
gdb::observers::command_param_changed.notify (name, var);
}
break;
case var_boolean:
{
const char *opt = c->var->get<bool> () ? "on" : "off";
gdb::observers::command_param_changed.notify (name, opt);
}
break;
case var_auto_boolean:
{
const char *s
= auto_boolean_enums[c->var->get<enum auto_boolean> ()];
gdb::observers::command_param_changed.notify (name, s);
}
break;
case var_uinteger:
case var_zuinteger:
{
char s[64];
xsnprintf (s, sizeof s, "%u", c->var->get<unsigned int> ());
gdb::observers::command_param_changed.notify (name, s);
}
break;
case var_integer:
case var_zinteger:
case var_zuinteger_unlimited:
{
char s[64];
xsnprintf (s, sizeof s, "%d", c->var->get<int> ());
gdb::observers::command_param_changed.notify (name, s);
}
break;
}
xfree (name);
}
}
/* See cli/cli-setshow.h. */
std::string
get_setshow_command_value_string (const setting &var)
{
string_file stb;
switch (var.type ())
{
case var_string:
{
char *value = var.get<char *> ();
if (value != nullptr)
stb.putstr (value, '"');
}
break;
case var_string_noescape:
case var_optional_filename:
case var_filename:
case var_enum:
{
const char *value;
if (var.type () == var_enum)
value = var.get<const char *> ();
else
value = var.get<char *> ();
if (value != nullptr)
stb.puts (value);
}
break;
case var_boolean:
stb.puts (var.get<bool> () ? "on" : "off");
break;
case var_auto_boolean:
switch (var.get<enum auto_boolean> ())
{
case AUTO_BOOLEAN_TRUE:
stb.puts ("on");
break;
case AUTO_BOOLEAN_FALSE:
stb.puts ("off");
break;
case AUTO_BOOLEAN_AUTO:
stb.puts ("auto");
break;
default:
gdb_assert_not_reached ("invalid var_auto_boolean");
break;
}
break;
case var_uinteger:
case var_zuinteger:
{
const unsigned int value = var.get<unsigned int> ();
if (var.type () == var_uinteger
&& value == UINT_MAX)
stb.puts ("unlimited");
else
stb.printf ("%u", value);
}
break;
case var_integer:
case var_zinteger:
{
const int value = var.get<int> ();
if (var.type () == var_integer
&& value == INT_MAX)
stb.puts ("unlimited");
else
stb.printf ("%d", value);
}
break;
case var_zuinteger_unlimited:
{
const int value = var.get<int> ();
if (value == -1)
stb.puts ("unlimited");
else
stb.printf ("%d", value);
}
break;
default:
gdb_assert_not_reached ("bad var_type");
}
return std::move (stb.string ());
}
/* Do a "show" command. ARG is NULL if no argument, or the
text of the argument, and FROM_TTY is nonzero if this command is
being entered directly by the user (i.e. these are just like any
other command). C is the command list element for the command. */
void
do_show_command (const char *arg, int from_tty, struct cmd_list_element *c)
{
struct ui_out *uiout = current_uiout;
gdb_assert (c->type == show_cmd);
gdb_assert (c->var.has_value ());
std::string val = get_setshow_command_value_string (*c->var);
/* FIXME: cagney/2005-02-10: There should be MI and CLI specific
versions of code to print the value out. */
if (uiout->is_mi_like_p ())
uiout->field_string ("value", val);
else
{
if (c->show_value_func != NULL)
c->show_value_func (gdb_stdout, from_tty, c, val.c_str ());
else
deprecated_show_value_hack (gdb_stdout, from_tty, c, val.c_str ());
}
c->func (NULL, from_tty, c);
}
/* Show all the settings in a list of show commands. */
void
cmd_show_list (struct cmd_list_element *list, int from_tty)
{
struct ui_out *uiout = current_uiout;
ui_out_emit_tuple tuple_emitter (uiout, "showlist");
for (; list != NULL; list = list->next)
{
/* We skip show command aliases to avoid showing duplicated values. */
/* If we find a prefix, run its list, prefixing our output by its
prefix (with "show " skipped). */
if (list->is_prefix () && !list->is_alias ())
{
ui_out_emit_tuple optionlist_emitter (uiout, "optionlist");
std::string prefixname = list->prefixname ();
const char *new_prefix = strstr (prefixname.c_str (), "show ") + 5;
if (uiout->is_mi_like_p ())
uiout->field_string ("prefix", new_prefix);
cmd_show_list (*list->subcommands, from_tty);
}
else if (list->theclass != no_set_class && !list->is_alias ())
{
ui_out_emit_tuple option_emitter (uiout, "option");
if (list->prefix != nullptr)
{
/* If we find a prefix, output it (with "show " skipped). */
std::string prefixname = list->prefix->prefixname ();
prefixname = (!list->prefix->is_prefix () ? ""
: strstr (prefixname.c_str (), "show ") + 5);
uiout->text (prefixname);
}
uiout->field_string ("name", list->name);
uiout->text (": ");
if (list->type == show_cmd)
do_show_command (NULL, from_tty, list);
else
cmd_func (list, NULL, from_tty);
}
}
}