Tom Tromey 1a3389079d Don't steal references in the gdb Python code ...

Some Python APIs steal references from their caller, and the refcount
checker supports this via an attribute.

However, in gdb with C++ we have a better idiom available: we can use
std::move on a gdbpy_ref<> instead.  This makes the semantics obvious
at the point of call, and is safer at runtime as well, because the
callee's gdbpy_ref<> will be emptied.

This patch changes the reference-stealing code in gdb to use rvalue
references instead.

Tested on x86-64 Fedora 28.

gdb/ChangeLog
2018-09-16  Tom Tromey  <tom@tromey.com>

	* python/python-internal.h (CPYCHECKER_STEALS_REFERENCE_TO_ARG):
	Remove.
	* python/py-varobj.c (py_varobj_iter_ctor): Change pyiter to
	rvalue reference.  Remove CPYCHECKER_STEALS_REFERENCE_TO_ARG.
	(py_varobj_iter_new): Likewise.
	(py_varobj_get_iterator): Use gdbpy_ref.

2018-09-16 23:48:21 -06:00

..

lib/gdb

Add more methods to gdb.Progspace

2018-09-16 06:52:37 -06:00

py-all-events.def

…

py-arch.c

…

py-auto-load.c

…

py-block.c

Add more methods to gdb.Progspace

2018-09-16 06:52:37 -06:00

py-bpevent.c

gdb/python: Use copy-initialization more when possible

2018-08-24 22:57:16 +01:00

py-breakpoint.c

Simple unused variable removals

2018-07-22 13:20:01 -06:00

py-cmd.c

Change Python code to use new_reference

2018-04-30 11:33:12 -06:00

py-continueevent.c

Change thread_to_thread_object to return a new reference

2018-09-16 07:25:57 -06:00

py-event-types.def

…

py-event.c

…

py-event.h

Change thread_to_thread_object to return a new reference

2018-09-16 07:25:57 -06:00

py-events.h

…

py-evtregistry.c

…

py-evts.c

…

py-exitedevent.c

gdb/python: Use copy-initialization more when possible

2018-08-24 22:57:16 +01:00

py-finishbreakpoint.c

Use thread_info and inferior pointers more throughout

2018-06-21 17:09:31 +01:00

py-frame.c

…

py-framefilter.c

MI: Fix printing of frame architecture with Python frame filters enabled

2018-08-27 17:12:41 -04:00

py-function.c

…

py-gdb-readline.c

Remove "repeat" argument from command_line_input

2018-08-17 16:39:06 -06:00

py-inferior.c

Simplify uses of thread_to_thread_object

2018-09-16 23:36:54 -06:00

py-infevents.c

gdb/python: Use copy-initialization more when possible

2018-08-24 22:57:16 +01:00

py-infthread.c

Change thread_to_thread_object to return a new reference

2018-09-16 07:25:57 -06:00

py-instruction.c

…

py-instruction.h

…

py-lazy-string.c

…

py-linetable.c

…

py-newobjfileevent.c

Change objfile_to_objfile_object to return a new reference

2018-09-16 07:25:56 -06:00

py-objfile.c

Change objfile_to_objfile_object to return a new reference

2018-09-16 07:25:56 -06:00

py-param.c

Fix a memory leak in py-param.c

2018-06-20 21:10:10 -06:00

py-prettyprint.c

Change objfile_to_objfile_object to return a new reference

2018-09-16 07:25:56 -06:00

py-progspace.c

Change objfile_to_objfile_object to return a new reference

2018-09-16 07:25:56 -06:00

py-record-btrace.c

Use thread_info and inferior pointers more throughout

2018-06-21 17:09:31 +01:00

py-record-btrace.h

…

py-record-full.c

…

py-record-full.h

…

py-record.c

Use thread_info and inferior pointers more throughout

2018-06-21 17:09:31 +01:00

py-record.h

Use thread_info and inferior pointers more throughout

2018-06-21 17:09:31 +01:00

py-ref.h

…

py-signalevent.c

gdb/python: Use copy-initialization more when possible

2018-08-24 22:57:16 +01:00

py-stopevent.c

Change thread_to_thread_object to return a new reference

2018-09-16 07:25:57 -06:00

py-stopevent.h

…

py-symbol.c

…

py-symtab.c

Change objfile_to_objfile_object to return a new reference

2018-09-16 07:25:56 -06:00

py-threadevent.c

Simplify uses of thread_to_thread_object

2018-09-16 23:36:54 -06:00

py-type.c

Remove a static buffer from cp-name-parser.y

2018-06-01 10:46:47 -06:00

py-unwind.c

Simple unused variable removals

2018-07-22 13:20:01 -06:00

py-utils.c

…

py-value.c

Use unique_xmalloc_ptr for read_string

2018-06-18 12:51:02 -06:00

py-varobj.c

Don't steal references in the gdb Python code

2018-09-16 23:48:21 -06:00

py-xmethods.c

Change objfile_to_objfile_object to return a new reference

2018-09-16 07:25:56 -06:00

python-config.py

configure uses incorrect link order when testing libpython

2018-05-04 10:08:09 -04:00

python-internal.h

Don't steal references in the gdb Python code

2018-09-16 23:48:21 -06:00

python.c

Change objfile_to_objfile_object to return a new reference

2018-09-16 07:25:56 -06:00

python.h

…