espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-20 01:50:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

-Wimplicit-fallthrough dodgy fixes

Browse Source 
The comment logically belongs inside the preprocessor conditional,
but gcc's -Wimplicit-fallthrough loses track of it.  Revert when/if
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77817 is fixed.

	* app.c (do_scrub_chars): Move fall through comment.
	* expr.c (operand): Likewise.
This commit is contained in:
Alan Modra
2016-10-06 22:49:08 +10:30
parent b781683b71
commit fcddde94ee
3 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gas/ChangeLog
View File

@ -1,3 +1,8 @@
2016-10-06 Alan Modra <amodra@gmail.com>
* app.c (do_scrub_chars): Move fall through comment.
* expr.c (operand): Likewise.
2016-10-06 Matthew Fortune <matthew.fortune@imgtec.com> 2016-10-06 Matthew Fortune <matthew.fortune@imgtec.com>
PR gas/20648 PR gas/20648

2
gas/app.c
View File

@ -1322,8 +1322,8 @@ do_scrub_chars (size_t (*get) (char *, size_t), char *tostart, size_t tolen)
else else
UNGET (quot); UNGET (quot);
} }
/* FALL THROUGH */
#endif #endif
/* Fall through. */
case LEX_IS_SYMBOL_COMPONENT: case LEX_IS_SYMBOL_COMPONENT:
if (state == 10) if (state == 10)

6
gas/expr.c
View File

@ -949,8 +949,8 @@ operand (expressionS *expressionP, enum expr_mode mode)
if (md_need_index_operator()) if (md_need_index_operator())
goto de_fault; goto de_fault;
# endif # endif
/* FALLTHROUGH */
#endif #endif
/* Fall through. */
case '(': case '(':
/* Didn't begin with digit & not a name. */ /* Didn't begin with digit & not a name. */
segment = expr (0, expressionP, mode); segment = expr (0, expressionP, mode);
@ -980,8 +980,8 @@ operand (expressionS *expressionP, enum expr_mode mode)
if (! flag_m68k_mri || *input_line_pointer != '\'') if (! flag_m68k_mri || *input_line_pointer != '\'')
goto de_fault; goto de_fault;
++input_line_pointer; ++input_line_pointer;
/* Fall through. */
#endif #endif
/* Fall through. */
case '\'': case '\'':
if (! flag_m68k_mri) if (! flag_m68k_mri)
{ {
@ -1002,8 +1002,8 @@ operand (expressionS *expressionP, enum expr_mode mode)
/* Double quote is the bitwise not operator in MRI mode. */ /* Double quote is the bitwise not operator in MRI mode. */
if (! flag_m68k_mri) if (! flag_m68k_mri)
goto de_fault; goto de_fault;
/* Fall through. */
#endif #endif
/* Fall through. */
case '~': case '~':
/* '~' is permitted to start a label on the Delta. */ /* '~' is permitted to start a label on the Delta. */
if (is_name_beginner (c)) if (is_name_beginner (c))