espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-05-29 07:10:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

gdb: revert one array_view copy change in ada-lang.c

Browse Source 
Commit 4bce7cdaf481 ("gdbsupport: add array_view copy function") caused
an internal error when running gdb.ada/packed_array_assign.exp:

    print pra(1) := pr^M
    /home/smarchi/src/binutils-gdb/gdb/../gdbsupport/array-view.h:217: internal-error: copy: Assertion `dest.size () == src.size ()' failed.^M

I am not sure what's the root cause of this, whether it is a GDB bug
exposed by using the array_view copy function or not.  Back out the
change that triggers the internal error for now, while we investigate
it.

Change-Id: I055ab14143e4cfd3ca7ce8f4855c6c3c05db52a7
This commit is contained in:
Simon Marchi
2021-12-03 20:39:57 -05:00
committed by Simon Marchi
parent 17ebe20800
commit fb2a515fd0
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/ada-lang.c
View File

@ -2586,7 +2586,9 @@ ada_value_assign (struct value *toval, struct value *fromval)
write_memory_with_notification (to_addr, buffer, len); write_memory_with_notification (to_addr, buffer, len);
val = value_copy (toval); val = value_copy (toval);
copy (value_contents (fromval), value_contents_raw (val)); memcpy (value_contents_raw (val).data (),
value_contents (fromval).data (),
TYPE_LENGTH (type));
deprecated_set_value_type (val, type); deprecated_set_value_type (val, type);
return val; return val;