Change objfile::has_partial_symbols to return bool

This changes objfile::has_partial_symbols and
quick_symbol_functions::has_symbols to return bool.

gdb/ChangeLog
2021-03-20  Tom Tromey  <tom@tromey.com>

	* objfiles.h (struct objfile) <has_partial_symbols>: Return bool.
	* symfile.h (struct quick_symbol_functions) <has_symbols>: Return
	bool.
	* symfile-debug.c (debug_qf_has_symbols): Return bool.
	* psymtab.c (psym_has_symbols): Return bool.
	* objfiles.c (objfile::has_partial_symbols): Return bool.
	* dwarf2/read.c (dw2_has_symbols): Return bool.
This commit is contained in:
Tom Tromey
2021-03-20 17:23:40 -06:00
parent a8ad4f3c17
commit fae2120ba0
7 changed files with 20 additions and 10 deletions

View File

@ -1,3 +1,13 @@
2021-03-20 Tom Tromey <tom@tromey.com>
* objfiles.h (struct objfile) <has_partial_symbols>: Return bool.
* symfile.h (struct quick_symbol_functions) <has_symbols>: Return
bool.
* symfile-debug.c (debug_qf_has_symbols): Return bool.
* psymtab.c (psym_has_symbols): Return bool.
* objfiles.c (objfile::has_partial_symbols): Return bool.
* dwarf2/read.c (dw2_has_symbols): Return bool.
2021-03-20 Tom Tromey <tom@tromey.com> 2021-03-20 Tom Tromey <tom@tromey.com>
* symfile.c (read_symbols): Update. * symfile.c (read_symbols): Update.

View File

@ -4872,10 +4872,10 @@ dw2_map_symbol_filenames (struct objfile *objfile, symbol_filename_ftype *fun,
}); });
} }
static int static bool
dw2_has_symbols (struct objfile *objfile) dw2_has_symbols (struct objfile *objfile)
{ {
return 1; return true;
} }
const struct quick_symbol_functions dwarf2_gdb_index_functions = const struct quick_symbol_functions dwarf2_gdb_index_functions =

View File

@ -812,11 +812,11 @@ objfile_rebase (struct objfile *objfile, CORE_ADDR slide)
/* See objfiles.h. */ /* See objfiles.h. */
int bool
objfile::has_partial_symbols () objfile::has_partial_symbols ()
{ {
if (!sf) if (!sf)
return 0; return false;
/* If we have not read psymbols, but we have a function capable of reading /* If we have not read psymbols, but we have a function capable of reading
them, then that is an indication that they are in fact available. Without them, then that is an indication that they are in fact available. Without
@ -824,7 +824,7 @@ objfile::has_partial_symbols ()
not be present in this objfile. */ not be present in this objfile. */
if ((flags & OBJF_PSYMTABS_READ) == 0 if ((flags & OBJF_PSYMTABS_READ) == 0
&& sf->sym_read_psymbols != NULL) && sf->sym_read_psymbols != NULL)
return 1; return true;
return sf->qf->has_symbols (this); return sf->qf->has_symbols (this);
} }

View File

@ -550,7 +550,7 @@ public:
/* Return true if OBJFILE has partial symbols. */ /* Return true if OBJFILE has partial symbols. */
int has_partial_symbols (); bool has_partial_symbols ();
/* The object file's original name as specified by the user, /* The object file's original name as specified by the user,
made absolute, and tilde-expanded. However, it is not canonicalized made absolute, and tilde-expanded. However, it is not canonicalized

View File

@ -1334,7 +1334,7 @@ psym_expand_symtabs_matching
/* Psymtab version of has_symbols. See its definition in /* Psymtab version of has_symbols. See its definition in
the definition of quick_symbol_functions in symfile.h. */ the definition of quick_symbol_functions in symfile.h. */
static int static bool
psym_has_symbols (struct objfile *objfile) psym_has_symbols (struct objfile *objfile)
{ {
return objfile->partial_symtabs->psymtabs != NULL; return objfile->partial_symtabs->psymtabs != NULL;

View File

@ -70,12 +70,12 @@ debug_symtab_name (struct symtab *symtab)
/* Debugging version of struct quick_symbol_functions. */ /* Debugging version of struct quick_symbol_functions. */
static int static bool
debug_qf_has_symbols (struct objfile *objfile) debug_qf_has_symbols (struct objfile *objfile)
{ {
const struct debug_sym_fns_data *debug_data const struct debug_sym_fns_data *debug_data
= symfile_debug_objfile_data_key.get (objfile); = symfile_debug_objfile_data_key.get (objfile);
int retval; bool retval;
retval = debug_data->real_sf->qf->has_symbols (objfile); retval = debug_data->real_sf->qf->has_symbols (objfile);

View File

@ -150,7 +150,7 @@ struct quick_symbol_functions
{ {
/* Return true if this objfile has any "partial" symbols /* Return true if this objfile has any "partial" symbols
available. */ available. */
int (*has_symbols) (struct objfile *objfile); bool (*has_symbols) (struct objfile *objfile);
/* Return the symbol table for the "last" file appearing in /* Return the symbol table for the "last" file appearing in
OBJFILE. */ OBJFILE. */