espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-23 03:29:47 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix buglets in gdb.trace/tspeed.{exp,c}

Browse Source 
When trying to run gdb.trace/tspeed.exp, I get:

ERROR: can't read "ipalib": no such variable
    while executing
"gdb_load_shlib $ipalib"
    (procedure "prepare_for_trace_test" line 5)

This problem seems to come from commit

    c708f4d256f ("gdb: Don't call gdb_load_shlib unless GDB is running")

which moved the gdb_load_shlib call in prepare_for_trace_test.  In order
to access the ipalib variable, we need to declare "global ipalib" first.

Then, this test uses nowarnings, for no good reason I could find.  We
can remove that and fix the two trivial warnings that appear:

/home/emaisin/src/binutils-gdb/gdb/testsuite/gdb.trace/tspeed.c: In function 'main':
/home/emaisin/src/binutils-gdb/gdb/testsuite/gdb.trace/tspeed.c:87:16: warning: too many arguments for format [-Wformat-extra-args]
        printf ("Negative times, giving up\n", max_iters);
                ^
/home/emaisin/src/binutils-gdb/gdb/testsuite/gdb.trace/tspeed.c:99:7: warning: implicit declaration of function 'sleep' [-Wimplicit-function-declaration]
       sleep (1);  /* set post-run breakpoint here */
       ^

gdb/testsuite/ChangeLog:

	* gdb.trace/tspeed.exp: Remove nowarnings.
	(prepare_for_trace_test): Declare "global ipalib".
	* gdb.trace/tspeed.c: Include unistd.h.
	(main): Remove superfluous printf argument.
This commit is contained in:
Simon Marchi
2018-10-12 16:27:29 -04:00
parent fe4ba87324
commit f9c49bffe6
3 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,10 @@
2018-10-12 Simon Marchi <simon.marchi@ericsson.com>
* gdb.trace/tspeed.exp: Remove nowarnings.
(prepare_for_trace_test): Declare "global ipalib".
* gdb.trace/tspeed.c: Include unistd.h.
(main): Remove superfluous printf argument.
2018-10-11 Sandra Loosemore <sandra@codesourcery.com> 2018-10-11 Sandra Loosemore <sandra@codesourcery.com>
* gdb.base/solib-vanish.exp: Fix regexp not to require a POSIX * gdb.base/solib-vanish.exp: Fix regexp not to require a POSIX

3
gdb/testsuite/gdb.trace/tspeed.c
View File

@ -28,6 +28,7 @@
#include <time.h> #include <time.h>
#include <sys/time.h> #include <sys/time.h>
#include <sys/resource.h> #include <sys/resource.h>
#include <unistd.h>
int trace_speed_test (void); int trace_speed_test (void);
@ -84,7 +85,7 @@ main(int argc, char **argv)
} }
if (problem < 0) if (problem < 0)
{ {
printf ("Negative times, giving up\n", max_iters); printf ("Negative times, giving up\n");
break; break;
} }

3
gdb/testsuite/gdb.trace/tspeed.exp
View File

@ -21,7 +21,7 @@ set executable $testfile
set ipalib [get_in_proc_agent] set ipalib [get_in_proc_agent]
if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \ if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \
executable [concat {debug nowarnings c} shlib=$ipalib]] != "" } { executable [concat {debug c} shlib=$ipalib]] != "" } {
untested "failed to compile" untested "failed to compile"
return -1 return -1
} }
@ -38,6 +38,7 @@ set cr "\[\r\n\]+"
proc prepare_for_trace_test {} { proc prepare_for_trace_test {} {
global executable global executable
global ipalib
clean_restart $executable clean_restart $executable
gdb_load_shlib $ipalib gdb_load_shlib $ipalib