espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-28 15:18:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

asan: readelf: memory leaks

Browse Source 
* readelf.c (dump_section_as_strings): Free memory on error exit.
	(dump_section_as_bytes, process_notes_at): Likewise.
	(get_build_id): Free enote.
This commit is contained in:
Alan Modra
2020-03-14 11:11:28 +10:30
parent 02a8180e6f
commit f761cb13a9
2 changed files with 36 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
binutils/ChangeLog
View File

@ -1,3 +1,9 @@
2020-03-14 Alan Modra <amodra@gmail.com>
* readelf.c (dump_section_as_strings): Free memory on error exit.
(dump_section_as_bytes, process_notes_at): Likewise.
(get_build_id): Free enote.
2020-03-13 Kamil Rytarowski <n54@gmx.com> 2020-03-13 Kamil Rytarowski <n54@gmx.com>
* readelf.c (get_netbsd_elfcore_note_type): Add support for * readelf.c (get_netbsd_elfcore_note_type): Add support for

38
binutils/readelf.c
View File

@ -13682,7 +13682,7 @@ dump_section_as_strings (Elf_Internal_Shdr * section, Filedata * filedata)
{ {
warn (_("section '%s' has unsupported compress type: %d\n"), warn (_("section '%s' has unsupported compress type: %d\n"),
printable_section_name (filedata, section), chdr.ch_type); printable_section_name (filedata, section), chdr.ch_type);
return FALSE; goto error_out;
} }
uncompressed_size = chdr.ch_size; uncompressed_size = chdr.ch_size;
start += compression_header_size; start += compression_header_size;
@ -13714,7 +13714,7 @@ dump_section_as_strings (Elf_Internal_Shdr * section, Filedata * filedata)
{ {
error (_("Unable to decompress section %s\n"), error (_("Unable to decompress section %s\n"),
printable_section_name (filedata, section)); printable_section_name (filedata, section));
return FALSE; goto error_out;
} }
} }
else else
@ -13850,6 +13850,10 @@ dump_section_as_strings (Elf_Internal_Shdr * section, Filedata * filedata)
putchar ('\n'); putchar ('\n');
return TRUE; return TRUE;
error_out:
free (real_start);
return FALSE;
} }
static bfd_boolean static bfd_boolean
@ -13889,7 +13893,7 @@ dump_section_as_bytes (Elf_Internal_Shdr * section,
{ {
warn (_("section '%s' has unsupported compress type: %d\n"), warn (_("section '%s' has unsupported compress type: %d\n"),
printable_section_name (filedata, section), chdr.ch_type); printable_section_name (filedata, section), chdr.ch_type);
return FALSE; goto error_out;
} }
uncompressed_size = chdr.ch_size; uncompressed_size = chdr.ch_size;
start += compression_header_size; start += compression_header_size;
@ -13924,7 +13928,7 @@ dump_section_as_bytes (Elf_Internal_Shdr * section,
error (_("Unable to decompress section %s\n"), error (_("Unable to decompress section %s\n"),
printable_section_name (filedata, section)); printable_section_name (filedata, section));
/* FIXME: Print the section anyway ? */ /* FIXME: Print the section anyway ? */
return FALSE; goto error_out;
} }
} }
else else
@ -13934,7 +13938,7 @@ dump_section_as_bytes (Elf_Internal_Shdr * section,
if (relocate) if (relocate)
{ {
if (! apply_relocations (filedata, section, start, section_size, NULL, NULL)) if (! apply_relocations (filedata, section, start, section_size, NULL, NULL))
return FALSE; goto error_out;
} }
else else
{ {
@ -14004,6 +14008,10 @@ dump_section_as_bytes (Elf_Internal_Shdr * section,
putchar ('\n'); putchar ('\n');
return TRUE; return TRUE;
error_out:
free (real_start);
return FALSE;
} }
static ctf_sect_t * static ctf_sect_t *
@ -14317,7 +14325,10 @@ get_build_id (void * data)
if (align < 4) if (align < 4)
align = 4; align = 4;
else if (align != 4 && align != 8) else if (align != 4 && align != 8)
continue; {
free (enote);
continue;
}
end = (char *) enote + length; end = (char *) enote + length;
data_remaining = end - (char *) enote; data_remaining = end - (char *) enote;
@ -14330,6 +14341,7 @@ get_build_id (void * data)
warn (_("\ warn (_("\
malformed note encountered in section %s whilst scanning for build-id note\n"), malformed note encountered in section %s whilst scanning for build-id note\n"),
printable_section_name (filedata, shdr)); printable_section_name (filedata, shdr));
free (enote);
continue; continue;
} }
data_remaining -= min_notesz; data_remaining -= min_notesz;
@ -14356,6 +14368,7 @@ malformed note encountered in section %s whilst scanning for build-id note\n"),
warn (_("\ warn (_("\
malformed note encountered in section %s whilst scanning for build-id note\n"), malformed note encountered in section %s whilst scanning for build-id note\n"),
printable_section_name (filedata, shdr)); printable_section_name (filedata, shdr));
free (enote);
continue; continue;
} }
data_remaining -= min_notesz; data_remaining -= min_notesz;
@ -14380,6 +14393,7 @@ malformed note encountered in section %s whilst scanning for build-id note\n"),
warn (_("\ warn (_("\
malformed note encountered in section %s whilst scanning for build-id note\n"), malformed note encountered in section %s whilst scanning for build-id note\n"),
printable_section_name (filedata, shdr)); printable_section_name (filedata, shdr));
free (enote);
continue; continue;
} }
@ -14394,14 +14408,19 @@ malformed note encountered in section %s whilst scanning for build-id note\n"),
build_id = malloc (inote.descsz * 2 + 1); build_id = malloc (inote.descsz * 2 + 1);
if (build_id == NULL) if (build_id == NULL)
return NULL; {
free (enote);
return NULL;
}
for (j = 0; j < inote.descsz; ++j) for (j = 0; j < inote.descsz; ++j)
sprintf (build_id + (j * 2), "%02x", inote.descdata[j] & 0xff); sprintf (build_id + (j * 2), "%02x", inote.descdata[j] & 0xff);
build_id[inote.descsz * 2] = '\0'; build_id[inote.descsz * 2] = '\0';
free (enote);
return (unsigned char *) build_id; return (unsigned char *) build_id;
} }
free (enote);
} }
return NULL; return NULL;
@ -19425,7 +19444,10 @@ process_notes_at (Filedata * filedata,
if (pnotes) if (pnotes)
{ {
if (! apply_relocations (filedata, section, (unsigned char *) pnotes, length, NULL, NULL)) if (! apply_relocations (filedata, section, (unsigned char *) pnotes, length, NULL, NULL))
return FALSE; {
free (pnotes);
return FALSE;
}
} }
} }
else else