espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-21 10:34:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

Constify parse_and_eval_type

Browse Source 
I noticed that the argumen to parse_and_eval_type could be "const".
This patch implements this change.

I wonder if this could be removed.  It's only called via
check_stub_method_group, which seems questionable to me.  However, I
didn't look into doing this.

gdb/ChangeLog
2020-12-13  Tom Tromey  <tom@tromey.com>

	* gdbtypes.c (safe_parse_type): Make argument const.
	* value.h (parse_and_eval_type): Make argument const.
	* eval.c (parse_and_eval_type): Make argument const.
This commit is contained in:
Tom Tromey
2020-12-13 09:51:42 -07:00
parent 862fcbd8f0
commit f5756acc15
4 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2020-12-13 Tom Tromey <tom@tromey.com>
* gdbtypes.c (safe_parse_type): Make argument const.
* value.h (parse_and_eval_type): Make argument const.
* eval.c (parse_and_eval_type): Make argument const.
2020-12-13 Andrew Burgess <andrew.burgess@embecosm.com> 2020-12-13 Andrew Burgess <andrew.burgess@embecosm.com>
* NEWS: Mention new commands. * NEWS: Mention new commands.

2
gdb/eval.c
View File

@ -3096,7 +3096,7 @@ evaluate_subexp_for_cast (expression *exp, int *pos,
/* Parse a type expression in the string [P..P+LENGTH). */ /* Parse a type expression in the string [P..P+LENGTH). */
struct type * struct type *
parse_and_eval_type (char *p, int length) parse_and_eval_type (const char *p, int length)
{ {
char *tmp = (char *) alloca (length + 4); char *tmp = (char *) alloca (length + 4);

2
gdb/gdbtypes.c
View File

@ -3002,7 +3002,7 @@ check_typedef (struct type *type)
occurs, silently return a void type. */ occurs, silently return a void type. */
static struct type * static struct type *
safe_parse_type (struct gdbarch *gdbarch, char *p, int length) safe_parse_type (struct gdbarch *gdbarch, const char *p, int length)
{ {
struct ui_file *saved_gdb_stderr; struct ui_file *saved_gdb_stderr;
struct type *type = NULL; /* Initialize to keep gcc happy. */ struct type *type = NULL; /* Initialize to keep gcc happy. */

2
gdb/value.h
View File

@ -939,7 +939,7 @@ extern struct value *parse_and_eval (const char *exp);
extern struct value *parse_to_comma_and_eval (const char **expp); extern struct value *parse_to_comma_and_eval (const char **expp);
extern struct type *parse_and_eval_type (char *p, int length); extern struct type *parse_and_eval_type (const char *p, int length);
extern CORE_ADDR parse_and_eval_address (const char *exp); extern CORE_ADDR parse_and_eval_address (const char *exp);