espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-24 20:28:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

Re: gdb: Improve formatting of 'show architecture' messages

Browse Source 
Commit ccb9eba6a25 updated the testsuite for some targets without
running the testsuite on those targets.  This patch corrects the
update, in most cases just adding the expected full-stop.

On powerpc64le-linux, fixes these:
FAIL: gdb.arch/powerpc-d128-regs.exp: checking for PPC arch
FAIL: gdb.arch/powerpc-disassembler-options.exp: set architecture powerpc:common64
FAIL: gdb.arch/powerpc-disassembler-options.exp: set architecture rs6000:6000
FAIL: gdb.arch/ppc64-symtab-cordic.exp: show architecture

I also verified that arm-linuxeabi and s390x-linux cross-builds now
pass their disassembler-options.exp tests.

	* gdb.arch/arm-disassembler-options.exp: Adjust expected
	"target architecture" output.
	* gdb.arch/powerpc-d128-regs.exp: Likewise.
	* gdb.arch/powerpc-disassembler-options.exp: Likewise.
	* gdb.arch/ppc64-symtab-cordic.exp: Likewise.
	* gdb.arch/s390-disassembler-options.exp: Likewise.
This commit is contained in:
Alan Modra
2020-10-12 11:32:21 +10:30
parent 87a37e5e07
commit f4a0f710ae
6 changed files with 18 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,12 @@
2020-10-13 Alan Modra <amodra@gmail.com>
* gdb.arch/arm-disassembler-options.exp: Adjust expected
"target architecture" output.
* gdb.arch/powerpc-d128-regs.exp: Likewise.
* gdb.arch/powerpc-disassembler-options.exp: Likewise.
* gdb.arch/ppc64-symtab-cordic.exp: Likewise.
* gdb.arch/s390-disassembler-options.exp: Likewise.
2020-10-12 Pedro Alves <pedro@palves.net>
PR exp/26602

4
gdb/testsuite/gdb.arch/arm-disassembler-options.exp
View File

@ -31,7 +31,7 @@ set arch1 "armv2"
set arch2 "armv5"
gdb_test "set architecture $arch1" \
"The target architecture is set to \"$arch1\"" \
"The target architecture is set to \"$arch1\"\." \
"set architecture $arch1"
gdb_test_no_output "set disassembler-options"
@ -47,7 +47,7 @@ gdb_test "show disassembler-options" \
# Change architectures and verify the disassembler options have been preserved.
gdb_test "set architecture $arch2" \
"The target architecture is set to \"$arch2\"" \
"The target architecture is set to \"$arch2\"\." \
"set architecture $arch2"
gdb_test "show disassembler-options" \

2
gdb/testsuite/gdb.arch/powerpc-d128-regs.exp
View File

@ -44,7 +44,7 @@ if { ![runto main] } then {
return
}
if [gdb_test "show arch" ".*currently powerpc:common.*" "checking for PPC arch"] {
if [gdb_test "show arch" ".*powerpc:common.*" "checking for PPC arch"] {
return -1
}

4
gdb/testsuite/gdb.arch/powerpc-disassembler-options.exp
View File

@ -31,7 +31,7 @@ set arch1 "rs6000:6000"
set arch2 "powerpc:common64"
gdb_test "set architecture $arch1" \
"The target architecture is set to \"$arch1\"" \
"The target architecture is set to \"$arch1\"\." \
"set architecture $arch1"
gdb_test_no_output "set disassembler-options"
@ -47,7 +47,7 @@ gdb_test "show disassembler-options" \
# Change architectures and verify the disassembler options have been preserved.
gdb_test "set architecture $arch2" \
"The target architecture is set to \"$arch2\"" \
"The target architecture is set to \"$arch2\"\." \
"set architecture $arch2"
gdb_test "show disassembler-options" \

4
gdb/testsuite/gdb.arch/ppc64-symtab-cordic.exp
View File

@ -47,10 +47,10 @@ gdb_load ${kofile}
set test "show architecture"
gdb_test_multiple $test $test {
-re "\r\nThe target architecture is set to \"auto\" \\(currently \"powerpc:common64\"\\)\r\n$gdb_prompt $" {
-re "\r\nThe target architecture is set to \"auto\" \\(currently \"powerpc:common64\"\\)\.\r\n$gdb_prompt $" {
pass $test
}
-re "\r\nThe target architecture is set to \"auto\" \\(currently \".*\"\\)\r\n$gdb_prompt $" {
-re "\r\nThe target architecture is set to \"auto\" \\(currently \".*\"\\)\.\r\n$gdb_prompt $" {
untested "powerpc:common64 is not supported"
}
}

4
gdb/testsuite/gdb.arch/s390-disassembler-options.exp
View File

@ -31,7 +31,7 @@ set arch1 "s390:64-bit"
set arch2 "s390:31-bit"
gdb_test "set architecture $arch1" \
"The target architecture is set to \"$arch1\"" \
"The target architecture is set to \"$arch1\"\." \
"set architecture $arch1"
gdb_test_no_output "set disassembler-options"
@ -47,7 +47,7 @@ gdb_test "show disassembler-options" \
# Change architectures and verify the disassembler options have been preserved.
gdb_test "set architecture $arch2" \
"The target architecture is set to \"$arch2\"" \
"The target architecture is set to \"$arch2\"\." \
"set architecture $arch2"
gdb_test "show disassembler-options" \