espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-20 01:50:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix buffer underrun bug in the TI C30 disassembler.

Browse Source 
PR 24961
	* tic30-dis.c (get_indirect_operand): Check for bufcnt being
	greater than zero before indexing via (bufcnt -1).
This commit is contained in:
Nick Clifton
2019-09-03 15:37:12 +01:00
parent 1e4b5e7d35
commit f44b758d31
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
opcodes/ChangeLog
View File

@ -1,3 +1,9 @@
2019-09-03 Nick Clifton <nickc@redhat.com>
PR 24961
* tic30-dis.c (get_indirect_operand): Check for bufcnt being
greater than zero before indexing via (bufcnt -1).
2019-09-03 Nick Clifton <nickc@redhat.com> 2019-09-03 Nick Clifton <nickc@redhat.com>
PR 24958 PR 24958

4
opcodes/tic30-dis.c
View File

@ -253,7 +253,9 @@ get_indirect_operand (unsigned short fragment,
for (i = 0, bufcnt = 0; i < len; i++, bufcnt++) for (i = 0, bufcnt = 0; i < len; i++, bufcnt++)
{ {
buffer[bufcnt] = current_ind->syntax[i]; buffer[bufcnt] = current_ind->syntax[i];
if (buffer[bufcnt - 1] == 'a' && buffer[bufcnt] == 'r') if (bufcnt > 0
&& buffer[bufcnt - 1] == 'a'
&& buffer[bufcnt] == 'r')
buffer[++bufcnt] = arnum + '0'; buffer[++bufcnt] = arnum + '0';
if (buffer[bufcnt] == '(' if (buffer[bufcnt] == '('
&& current_ind->displacement == DISP_REQUIRED) && current_ind->displacement == DISP_REQUIRED)