espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-01 20:12:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove const from many struct objfile *

Browse Source 
I am just not sure if we should go the route of
        struct objfile * -> const struct objfile *
or the other way of:
        const struct objfile * -> struct objfile *

Normally const adding is better but here I do not see much useful to have any
struct objfile * const and then it just causes pointer compatibility problems.

On Wed, 03 Dec 2014 18:18:44 +0100, Doug Evans wrote:
struct objfile is one case where I've decided to just leave the const
out and not worry about it.

gdb/ChangeLog
2014-12-05  Jan Kratochvil  <jan.kratochvil@redhat.com>

	Remove const from struct objfile *.
	* solib-darwin.c, solib-spu.c, solib-svr4.c, solib.c, solist.h,
	symtab.c, symtab.h: In these files.
This commit is contained in:
Jan Kratochvil
2014-12-05 19:11:53 +01:00
parent 069bb7eced
commit efad9b6a7a
8 changed files with 17 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2014-12-05 Jan Kratochvil <jan.kratochvil@redhat.com>
Remove const from struct objfile *.
* solib-darwin.c, solib-spu.c, solib-svr4.c, solib.c, solist.h,
symtab.c, symtab.h: In these files.
2014-12-05 Andreas From <andreas.from@ericsson.com> 2014-12-05 Andreas From <andreas.from@ericsson.com>
* MAINTAINERS (Write After Approval): Add "Andreas From" * MAINTAINERS (Write After Approval): Add "Andreas From"

2
gdb/solib-darwin.c
View File

@ -570,7 +570,7 @@ darwin_relocate_section_addresses (struct so_list *so,
} }
static struct symbol * static struct symbol *
darwin_lookup_lib_symbol (const struct objfile *objfile, darwin_lookup_lib_symbol (struct objfile *objfile,
const char *name, const char *name,
const domain_enum domain) const domain_enum domain)
{ {

2
gdb/solib-spu.c
View File

@ -389,7 +389,7 @@ spu_bfd_open (char *pathname)
/* Lookup global symbol in a SPE executable. */ /* Lookup global symbol in a SPE executable. */
static struct symbol * static struct symbol *
spu_lookup_lib_symbol (const struct objfile *objfile, spu_lookup_lib_symbol (struct objfile *objfile,
const char *name, const char *name,
const domain_enum domain) const domain_enum domain)
{ {

2
gdb/solib-svr4.c
View File

@ -3195,7 +3195,7 @@ struct target_so_ops svr4_so_ops;
the main executable. */ the main executable. */
static struct symbol * static struct symbol *
elf_lookup_lib_symbol (const struct objfile *objfile, elf_lookup_lib_symbol (struct objfile *objfile,
const char *name, const char *name,
const domain_enum domain) const domain_enum domain)
{ {

2
gdb/solib.c
View File

@ -1404,7 +1404,7 @@ show_auto_solib_add (struct ui_file *file, int from_tty,
the library-specific handler if it is installed for the current target. */ the library-specific handler if it is installed for the current target. */
struct symbol * struct symbol *
solib_global_lookup (const struct objfile *objfile, solib_global_lookup (struct objfile *objfile,
const char *name, const char *name,
const domain_enum domain) const domain_enum domain)
{ {

4
gdb/solist.h
View File

@ -137,7 +137,7 @@ struct target_so_ops
unsigned o_flags, char **temp_pathname); unsigned o_flags, char **temp_pathname);
/* Hook for looking up global symbols in a library-specific way. */ /* Hook for looking up global symbols in a library-specific way. */
struct symbol * (*lookup_lib_global_symbol) (const struct objfile *objfile, struct symbol * (*lookup_lib_global_symbol) (struct objfile *objfile,
const char *name, const char *name,
const domain_enum domain); const domain_enum domain);
@ -189,7 +189,7 @@ extern bfd *solib_bfd_open (char *in_pathname);
extern struct target_so_ops *current_target_so_ops; extern struct target_so_ops *current_target_so_ops;
/* Handler for library-specific global symbol lookup in solib.c. */ /* Handler for library-specific global symbol lookup in solib.c. */
struct symbol *solib_global_lookup (const struct objfile *objfile, struct symbol *solib_global_lookup (struct objfile *objfile,
const char *name, const char *name,
const domain_enum domain); const domain_enum domain);

9
gdb/symtab.c
View File

@ -1536,11 +1536,11 @@ lookup_symbol_in_block (const char *name, const struct block *block,
/* See symtab.h. */ /* See symtab.h. */
struct symbol * struct symbol *
lookup_global_symbol_from_objfile (const struct objfile *main_objfile, lookup_global_symbol_from_objfile (struct objfile *main_objfile,
const char *name, const char *name,
const domain_enum domain) const domain_enum domain)
{ {
const struct objfile *objfile; struct objfile *objfile;
for (objfile = main_objfile; for (objfile = main_objfile;
objfile; objfile;
@ -1561,12 +1561,11 @@ lookup_global_symbol_from_objfile (const struct objfile *main_objfile,
if (sym) if (sym)
{ {
block_found = block; block_found = block;
return fixup_symbol_section (sym, (struct objfile *)objfile); return fixup_symbol_section (sym, objfile);
} }
} }
sym = lookup_symbol_via_quick_fns ((struct objfile *) objfile, sym = lookup_symbol_via_quick_fns (objfile, GLOBAL_BLOCK, name, domain);
GLOBAL_BLOCK, name, domain);
if (sym) if (sym)
return sym; return sym;
} }

2
gdb/symtab.h
View File

@ -1475,7 +1475,7 @@ extern enum language main_language (void);
if necessary. */ if necessary. */
extern struct symbol * extern struct symbol *
lookup_global_symbol_from_objfile (const struct objfile *main_objfile, lookup_global_symbol_from_objfile (struct objfile *main_objfile,
const char *name, const char *name,
const domain_enum domain); const domain_enum domain);