mirror of
https://github.com/espressif/binutils-gdb.git
synced 2025-08-05 21:50:21 +08:00
gdb/
* NEWS: Document inlined function support. * Makefile.in (SFILES): Add inline-frame.c. (COMMON_OBS): Add inline-frame.o. * block.c (contained_in): Rewrite to use lexical nesting. (block_linkage_function): Skip inlined function blocks. (block_inlined_p): New. * block.h (struct block): Update comment. (block_inlined_p): New prototype. * blockframe.c (get_frame_block): Handle inlined functions. (get_frame_function): Do not use block_linkage_function. (block_innermost_frame): Use get_frame_block and contained_in. * breakpoint.c (watchpoint_check): Remove extra reinit_frame_cache. Skip over inlined functions. Simplify epilogue check. (bpstat_check_breakpoint_conditions): Use get_stack_frame_id. Update comments. (set_momentary_breakpoint): Only accept non-inlined frames. (watch_command_1): Use frame_unwind_caller_pc and frame_unwind_caller_id instead of get_prev_frame. (until_break_command): Likewise. Use get_stack_frame_id. * buildsym.c (end_symtab): Set SYMBOL_SYMTAB for block functions. * dwarf2loc.c (dwarf_expr_frame_base): Use block_linkage_function. * dwarf2read.c (process_die): Handle DW_TAG_inlined_subroutine. (read_func_scope, new_symbol): Likewise. Handle arguments specially for inlined functions without call site information. (inherit_abstract_dies): Allow tag mismatch for inlined subroutines. (die_specification): Treat DW_AT_abstract_origin as a specification. (read_type_die): Handle DW_TAG_inlined_subroutine. * frame-unwind.c (frame_unwind_init): Add inline_frame_unwind. * frame.c (fprint_frame_id): Print inline depth. (fprint_frame_type): Handle INLINE_FRAME and SENTINEL_FRAME. (skip_inlined_frames, get_stack_frame_id): New. (frame_unwind_caller_id): Use skip_inlined_frames. (frame_id_inlined_p): New. (frame_id_eq): Make the logic match the comments. Add inline_depth check. (frame_id_inner): Handle inlined functions. (frame_unwind_pc): New function, copied from frame_unwind_caller_pc. (frame_unwind_caller_pc): Use skip_inlined_frames and frame_unwind_pc. (get_prev_frame_1): Check for inline frames. Split out frame allocation to get_prev_frame_raw. (get_prev_frame_raw): New function. (get_prev_frame): Handle inline frames. (get_frame_pc): Use frame_unwind_pc. (get_frame_address_in_block): Skip inlined frames on both sides. (pc_notcurrent): Delete. (find_frame_sal): Rewrite to handle inline call sites. Use get_frame_address_in_block. (deprecated_update_frame_pc_hack): Make static. * frame.h: Update comments. (struct frame_id): Add inline_depth. (enum frame_type): Add INLINE_FRAME. (frame_id_inlined_p, get_stack_frame_id): New prototypes. * gdbthread.h (struct thread_info): Add step_stack_frame_id field. * infcmd.c (set_step_frame): New function. (step_once): Use set_step_frame. Handle inlined functions. (until_next_command): Use set_step_frame. (finish_backward), finish_forward): Use get_stack_frame_id. (finish_command): Support inlined functions. * inferior.h (set_step_info): New prototype. * infrun.c (RESUME_ALL): Use minus_one_ptid. (clear_proceed_status): Clear step_stack_frame_id. (init_wait_for_inferior): Call clear_inline_frame_state. (init_execution_control_state): Make static. (set_step_info): New function. (init_thread_stepping_state): Do not set the symtab or line here. (stepped_in_from): New function. (handle_inferior_event): Handle inlined functions. Use set_step_info. (insert_step_resume_breakpoint_at_frame): Use get_stack_frame_id. (struct inferior_status): Add step_stack_frame_id. (save_inferior_status, restore_inferior_status): Save and restore step_stack_frame_id. * inline-frame.c, inline-frame.h: New files. * minsyms.c (prim_record_minimal_symbol_and_info): Use XCALLOC. * regcache.c (regcache_write_pc): Call reinit_frame_cache. * s390-tdep.c (s390_prologue_frame_unwind_cache): Handle INLINE_FRAME. * stack.c (frame_show_address): New. (print_frame_info, print_frame): Use it. (find_frame_funname): Use get_frame_function. Handle inlined blocks. (frame_info): Mark inlined functions. (backtrace_command_1): Use get_current_user_frame. (print_frame_local_vars, print_frame_label_vars): Update comments. (return_command): Refuse inlined functions. * symtab.c (lookup_symbol_aux_local): Stop at inlined function boundaries. (find_function_start_sal): Avoid inlined functions. (completion_list_add_fields): New function. (default_make_symbol_completion_list): Use it. Use block_static_block and block_global_block. Check for inlined functions. (skip_prologue_using_sal): Avoid line number comparison across inlining. * symtab.h (struct symbol): Add is_inlined. (SYMBOL_INLINED): New. * target.c (target_resume): Call clear_inline_frame_state. * valops.c (value_of_variable): Check block_inlined_p. gdb/doc/ * gdb.texinfo (Debugging Optimized Code): New chapter. (Compiling for Debugging): Reference it. Move some text to the new section. gdb/testsuite/ * gdb.base/break.exp: Add an XFAIL for gcc/36748. * gdb.cp/annota2.exp: Accept frames-invalid in more places. * gdb.opt/Makefile.in (EXECUTABLES): Update. * gdb.opt/clobbered-registers-O2.exp: Update to GPL v3. * gdb.opt/inline-bt.c, gdb.opt/inline-bt.exp, gdb.opt/inline-cmds.c, gdb.opt/inline-cmds.exp, gdb.opt/inline-locals.c, gdb.opt/inline-locals.exp, gdb.opt/inline-markers.c: New files. * lib/gdb.exp (skip_inline_frame_tests): New function. (skip_inline_var_tests): New function.
This commit is contained in:
71
gdb/infcmd.c
71
gdb/infcmd.c
@ -52,6 +52,7 @@
|
||||
#include "cli/cli-decode.h"
|
||||
#include "gdbthread.h"
|
||||
#include "valprint.h"
|
||||
#include "inline-frame.h"
|
||||
|
||||
/* Functions exported for general use, in inferior.h: */
|
||||
|
||||
@ -758,6 +759,17 @@ Can't resume all threads and specify proceed count simultaneously."));
|
||||
continue_1 (all_threads);
|
||||
}
|
||||
|
||||
/* Record the starting point of a "step" or "next" command. */
|
||||
|
||||
static void
|
||||
set_step_frame (void)
|
||||
{
|
||||
struct symtab_and_line sal;
|
||||
|
||||
find_frame_sal (get_current_frame (), &sal);
|
||||
set_step_info (get_current_frame (), sal);
|
||||
}
|
||||
|
||||
/* Step until outside of current statement. */
|
||||
|
||||
static void
|
||||
@ -926,7 +938,7 @@ step_1_continuation (void *args)
|
||||
static void
|
||||
step_once (int skip_subroutines, int single_inst, int count, int thread)
|
||||
{
|
||||
struct frame_info *frame;
|
||||
struct frame_info *frame = get_current_frame ();
|
||||
|
||||
if (count > 0)
|
||||
{
|
||||
@ -936,23 +948,32 @@ step_once (int skip_subroutines, int single_inst, int count, int thread)
|
||||
THREAD is set. */
|
||||
struct thread_info *tp = inferior_thread ();
|
||||
clear_proceed_status ();
|
||||
|
||||
frame = get_current_frame ();
|
||||
tp->step_frame_id = get_frame_id (frame);
|
||||
set_step_frame ();
|
||||
|
||||
if (!single_inst)
|
||||
{
|
||||
CORE_ADDR pc;
|
||||
|
||||
/* Step at an inlined function behaves like "down". */
|
||||
if (!skip_subroutines && !single_inst
|
||||
&& inline_skipped_frames (inferior_ptid))
|
||||
{
|
||||
step_into_inline_frame (inferior_ptid);
|
||||
if (count > 1)
|
||||
step_once (skip_subroutines, single_inst, count - 1, thread);
|
||||
else
|
||||
/* Pretend that we've stopped. */
|
||||
normal_stop ();
|
||||
return;
|
||||
}
|
||||
|
||||
pc = get_frame_pc (frame);
|
||||
find_pc_line_pc_range (pc,
|
||||
&tp->step_range_start, &tp->step_range_end);
|
||||
|
||||
/* If we have no line info, switch to stepi mode. */
|
||||
if (tp->step_range_end == 0 && step_stop_if_no_debug)
|
||||
{
|
||||
tp->step_range_start = tp->step_range_end = 1;
|
||||
}
|
||||
tp->step_range_start = tp->step_range_end = 1;
|
||||
else if (tp->step_range_end == 0)
|
||||
{
|
||||
char *name;
|
||||
@ -1188,6 +1209,7 @@ until_next_command (int from_tty)
|
||||
struct thread_info *tp = inferior_thread ();
|
||||
|
||||
clear_proceed_status ();
|
||||
set_step_frame ();
|
||||
|
||||
frame = get_current_frame ();
|
||||
|
||||
@ -1217,7 +1239,6 @@ until_next_command (int from_tty)
|
||||
}
|
||||
|
||||
tp->step_over_calls = STEP_OVER_ALL;
|
||||
tp->step_frame_id = get_frame_id (frame);
|
||||
|
||||
tp->step_multi = 0; /* Only one call to proceed */
|
||||
|
||||
@ -1443,7 +1464,7 @@ finish_backward (struct symbol *function)
|
||||
/* Set breakpoint and continue. */
|
||||
breakpoint =
|
||||
set_momentary_breakpoint (sal,
|
||||
get_frame_id (get_selected_frame (NULL)),
|
||||
get_stack_frame_id (get_selected_frame (NULL)),
|
||||
bp_breakpoint);
|
||||
/* Tell the breakpoint to keep quiet. We won't be done
|
||||
until we've done another reverse single-step. */
|
||||
@ -1481,7 +1502,7 @@ finish_forward (struct symbol *function, struct frame_info *frame)
|
||||
sal = find_pc_line (get_frame_pc (frame), 0);
|
||||
sal.pc = get_frame_pc (frame);
|
||||
|
||||
breakpoint = set_momentary_breakpoint (sal, get_frame_id (frame),
|
||||
breakpoint = set_momentary_breakpoint (sal, get_stack_frame_id (frame),
|
||||
bp_finish);
|
||||
|
||||
old_chain = make_cleanup_delete_breakpoint (breakpoint);
|
||||
@ -1544,6 +1565,36 @@ finish_command (char *arg, int from_tty)
|
||||
|
||||
clear_proceed_status ();
|
||||
|
||||
/* Finishing from an inline frame is completely different. We don't
|
||||
try to show the "return value" - no way to locate it. So we do
|
||||
not need a completion. */
|
||||
if (get_frame_type (get_selected_frame (_("No selected frame.")))
|
||||
== INLINE_FRAME)
|
||||
{
|
||||
/* Claim we are stepping in the calling frame. An empty step
|
||||
range means that we will stop once we aren't in a function
|
||||
called by that frame. We don't use the magic "1" value for
|
||||
step_range_end, because then infrun will think this is nexti,
|
||||
and not step over the rest of this inlined function call. */
|
||||
struct thread_info *tp = inferior_thread ();
|
||||
struct symtab_and_line empty_sal;
|
||||
init_sal (&empty_sal);
|
||||
set_step_info (frame, empty_sal);
|
||||
tp->step_range_start = tp->step_range_end = get_frame_pc (frame);
|
||||
tp->step_over_calls = STEP_OVER_ALL;
|
||||
|
||||
/* Print info on the selected frame, including level number but not
|
||||
source. */
|
||||
if (from_tty)
|
||||
{
|
||||
printf_filtered (_("Run till exit from "));
|
||||
print_stack_frame (get_selected_frame (NULL), 1, LOCATION);
|
||||
}
|
||||
|
||||
proceed ((CORE_ADDR) -1, TARGET_SIGNAL_DEFAULT, 1);
|
||||
return;
|
||||
}
|
||||
|
||||
/* Find the function we will return from. */
|
||||
|
||||
function = find_pc_function (get_frame_pc (get_selected_frame (NULL)));
|
||||
|
Reference in New Issue
Block a user