espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-24 04:00:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

PE linker segmentation fault with MALLOC_PERTURB_=1

Browse Source 
PR 24596
	* emultempl/pe.em (gld_${EMULATION_NAME}_after_open): Check that
	the output is coff before accessing coff tdata.
	* emultempl/pep.em (gld_${EMULATION_NAME}_after_open): Likewise.
This commit is contained in:
Alan Modra
2019-05-28 20:12:32 +09:30
parent 65f381e729
commit eabf307f1d
3 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
ld/ChangeLog
View File

@ -1,3 +1,10 @@
2019-05-28 Alan Modra <amodra@gmail.com>
PR 24596
* emultempl/pe.em (gld_${EMULATION_NAME}_after_open): Check that
the output is coff before accessing coff tdata.
* emultempl/pep.em (gld_${EMULATION_NAME}_after_open): Likewise.
2019-05-28 Szabolcs Nagy <szabolcs.nagy@arm.com> 2019-05-28 Szabolcs Nagy <szabolcs.nagy@arm.com>
* testsuite/ld-aarch64/variant_pcs-now.d: Use --hash-style=sysv. * testsuite/ld-aarch64/variant_pcs-now.d: Use --hash-style=sysv.

3
ld/emultempl/pe.em
View File

@ -1360,7 +1360,8 @@ gld_${EMULATION_NAME}_after_open (void)
FIXME: This should be done via a function, rather than by FIXME: This should be done via a function, rather than by
including an internal BFD header. */ including an internal BFD header. */
if (coff_data (link_info.output_bfd) == NULL if (bfd_get_flavour (link_info.output_bfd) != bfd_target_coff_flavour
|| coff_data (link_info.output_bfd) == NULL
|| coff_data (link_info.output_bfd)->pe == 0) || coff_data (link_info.output_bfd)->pe == 0)
einfo (_("%F%P: cannot perform PE operations on non PE output file '%pB'\n"), einfo (_("%F%P: cannot perform PE operations on non PE output file '%pB'\n"),
link_info.output_bfd); link_info.output_bfd);

3
ld/emultempl/pep.em
View File

@ -1348,7 +1348,8 @@ gld_${EMULATION_NAME}_after_open (void)
FIXME: This should be done via a function, rather than by FIXME: This should be done via a function, rather than by
including an internal BFD header. */ including an internal BFD header. */
if (coff_data (link_info.output_bfd) == NULL if (bfd_get_flavour (link_info.output_bfd) != bfd_target_coff_flavour
|| coff_data (link_info.output_bfd) == NULL
|| coff_data (link_info.output_bfd)->pe == 0) || coff_data (link_info.output_bfd)->pe == 0)
einfo (_("%F%P: cannot perform PE operations on non PE output file '%pB'\n"), einfo (_("%F%P: cannot perform PE operations on non PE output file '%pB'\n"),
link_info.output_bfd); link_info.output_bfd);