espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-08-06 14:49:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

libctf: drop error-prone ctf_strerror

Browse Source 
This utility function is almost useless (all it does is casts the result
of a strerror) but has a seriously confusing name.  Over and over again
I have accidentally called it instead of ctf_errmsg, and hidden a
time-bomb for myself in a hard-to-test error-handling path: since
ctf_strerror is just a strerror wrapper, it cannot handle CTF errnos,
unlike ctf_errmsg.  It's astonishingly lucky that none of these errors
have crept into any commits to date.

Fuse it into ctf_errmsg and drop it.

libctf/
	* ctf-impl.h (ctf_strerror): Delete.
	* ctf-subr.c (ctf_strerror): Likewise.
	* ctf-error.c (ctf_errmsg): Stop using ctf_strerror: just use
	strerror directly.
This commit is contained in:
Nick Alcock
2020-06-04 18:07:38 +01:00
parent 1fa7a0c24e
commit e148b73013
4 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
libctf/ctf-error.c
View File

@ -19,6 +19,7 @@
#include <ctf-impl.h>
#include <stddef.h>
#include <string.h>
/* This construct is due to Bruno Haible: much thanks. */
@ -67,7 +68,7 @@ ctf_errmsg (int error)
if (error >= ECTF_BASE && (error - ECTF_BASE) < ECTF_NERR)
str = _ctf_errlist.str + _ctf_erridx[error - ECTF_BASE];
else
str = ctf_strerror (error);
str = (const char *) strerror (error);
return (str ? str : "Unknown error");
}