espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-17 07:53:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

PR python/19293 - invalidate frame cache when unwinders change

Browse Source 
PR python/19293 notes that when a Python unwinder is disabled, the
frame cache is not invalidated.  This means that disabling an unwinder
doesn't have any immediate effect -- but in my experience it's often
the case that I want to enable or disable an unwinder in order to see
what happens.

This patch adds a new gdb.invalidate_cached_frames function and
arranges for the relevant bits of library code to call it.  I've only
partially documented this function, considering a warning sufficient
without going into all the reasons ordinary code should not call it.
The name of the new function was taken from a comment in frame.h next
to reinit_frame_cache.

No new test as I think the updates to the existing test are sufficient
to show that the code is working as intended.

Built and regtested on x86-64 Fedora 23.

2016-07-12  Tom Tromey  <tom@tromey.com>

	PR python/19293:
	* python/lib/gdb/command/unwinders.py (do_enable_unwinder): Call
	gdb.invalidate_cached_frames.
	* python/lib/gdb/unwinder.py (register_unwinder): Call
	gdb.invalidate_cached_frames.
	* python/python.c (gdbpy_invalidate_cached_frames): New function.
	(python_GdbMethods): Add entry for invalidate_cached_frames.

2016-07-12  Tom Tromey  <tom@tromey.com>

	PR python/19293:
	* python.texi (Frames In Python): Document
	gdb.invalidate_cached_frames.

2016-07-12  Tom Tromey  <tom@tromey.com>

	PR python/19293:
	* gdb.python/py-unwind-maint.exp: Update tests.
This commit is contained in:
Tom Tromey
2016-06-09 15:20:09 -06:00
parent cf143069f3
commit e0f3fd7c44
8 changed files with 57 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
gdb/testsuite/gdb.python/py-unwind-maint.exp
View File

@ -34,7 +34,11 @@ if ![runto_main ] then {
return -1
}
gdb_test "source ${pyfile}" "Python script imported" "import python scripts"
gdb_test_sequence "source ${pyfile}" "import python scripts" {
"Python script imported"
"py_unwind_maint_ps_unwinder called"
"global_unwinder called"
}
gdb_test_sequence "info unwinder" "Show all unwinders" {
"Global:"
@ -50,7 +54,10 @@ gdb_test_sequence "continue" "Unwinders called" {
"global_unwinder called"
}
gdb_test "disable unwinder global .*" "1 unwinder disabled" "Unwinder disabled"
gdb_test_sequence "disable unwinder global .*" "Unwinder disabled" {
"1 unwinder disabled"
"py_unwind_maint_ps_unwinder called"
}
gdb_test_sequence "info unwinder" "Show with global unwinder disabled" {
"Global:"