espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-19 09:14:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove most calls to fixup_symbol_section

Browse Source 
Nearly every call to fixup_symbol_section in gdb is incorrect, and if
any such call has an effect, it's purely by happenstance.

fixup_section has a long comment explaining that the call should only
be made before runtime section offsets are applied.  And, the loop in
this code (the fallback loop -- the minsym lookup code is "ok") is
careful to remove these offsets before comparing addresses.

However, aside from a single call in dwarf2/read.c, every call in gdb
is actually done after section offsets have been applied.  So, these
calls are incorrect.

Now, these calls could be made when the symbol is created.  I
considered this approach, but I reasoned that the code has been this
way for many years, seemingly without ill effect.  So, instead I chose
to simply remove the offending calls.
This commit is contained in:
Tom Tromey
2023-01-13 09:27:54 -07:00
parent 5abbfa9822
commit dae58e0444
5 changed files with 10 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
gdb/ada-lang.c
View File

@ -5389,9 +5389,7 @@ match_data::operator() (struct block_symbol *bsym)
if (sym == NULL)
{
if (!found_sym && arg_sym != NULL)
add_defn_to_vec (*resultp,
fixup_symbol_section (arg_sym, objfile),
block);
add_defn_to_vec (*resultp, arg_sym, block);
found_sym = false;
arg_sym = NULL;
}
@ -5404,9 +5402,7 @@ match_data::operator() (struct block_symbol *bsym)
else
{
found_sym = true;
add_defn_to_vec (*resultp,
fixup_symbol_section (sym, objfile),
block);
add_defn_to_vec (*resultp, sym, block);
}
}
return true;
@ -5808,9 +5804,7 @@ ada_lookup_symbol (const char *name, const struct block *block0,
if (candidates.empty ())
return {};
block_symbol info = candidates[0];
info.symbol = fixup_symbol_section (info.symbol, NULL);
return info;
return candidates[0];
}
@ -6098,9 +6092,7 @@ ada_add_block_symbols (std::vector<struct block_symbol> &result,
else
{
found_sym = true;
add_defn_to_vec (result,
fixup_symbol_section (sym, objfile),
block);
add_defn_to_vec (result, sym, block);
}
}
}
@ -6113,9 +6105,7 @@ ada_add_block_symbols (std::vector<struct block_symbol> &result,
if (!found_sym && arg_sym != NULL)
{
add_defn_to_vec (result,
fixup_symbol_section (arg_sym, objfile),
block);
add_defn_to_vec (result, arg_sym, block);
}
if (!lookup_name.ada ().wild_match_p ())
@ -6152,9 +6142,7 @@ ada_add_block_symbols (std::vector<struct block_symbol> &result,
else
{
found_sym = true;
add_defn_to_vec (result,
fixup_symbol_section (sym, objfile),
block);
add_defn_to_vec (result, sym, block);
}
}
}
@ -6165,9 +6153,7 @@ ada_add_block_symbols (std::vector<struct block_symbol> &result,
They aren't parameters, right? */
if (!found_sym && arg_sym != NULL)
{
add_defn_to_vec (result,
fixup_symbol_section (arg_sym, objfile),
block);
add_defn_to_vec (result, arg_sym, block);
}
}
}