espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-08-06 14:49:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

Change add_target_sections_of_objfile to method on program_space

Browse Source 
This changes add_target_sections_of_objfile to be a method on
program_space.  It is renamed to be another overload of
add_target_sections, because they are semantically equivalent in a
sense.

gdb/ChangeLog
2020-10-29  Tom Tromey  <tom@tromey.com>

	* symfile.c (add_symbol_file_command): Update.
	* exec.c (program_space::add_target_sections): Rename.
	* symfile-mem.c (symbol_file_add_from_memory): Update.
	* progspace.h (struct program_space) <add_target_sections>:
	Declare new overload.
	* exec.h (add_target_sections_of_objfile): Don't declare.
This commit is contained in:
Tom Tromey
2020-10-29 15:04:33 -06:00
parent 3769e2277d
commit d9eebde018
6 changed files with 19 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
gdb/ChangeLog
View File

@ -1,3 +1,12 @@
2020-10-29 Tom Tromey <tom@tromey.com>
* symfile.c (add_symbol_file_command): Update.
* exec.c (program_space::add_target_sections): Rename.
* symfile-mem.c (symbol_file_add_from_memory): Update.
* progspace.h (struct program_space) <add_target_sections>:
Declare new overload.
* exec.h (add_target_sections_of_objfile): Don't declare.
2020-10-29 Tom Tromey <tom@tromey.com> 2020-10-29 Tom Tromey <tom@tromey.com>
* solib.c (solib_map_sections): Update. * solib.c (solib_map_sections): Update.

5
gdb/exec.c
View File

@ -628,9 +628,8 @@ program_space::add_target_sections (void *owner,
/* Add the sections of OBJFILE to the current set of target sections. */ /* Add the sections of OBJFILE to the current set of target sections. */
void void
add_target_sections_of_objfile (struct objfile *objfile) program_space::add_target_sections (struct objfile *objfile)
{ {
target_section_table *table = &current_program_space->target_sections;
struct obj_section *osect; struct obj_section *osect;
gdb_assert (objfile != nullptr); gdb_assert (objfile != nullptr);
@ -641,7 +640,7 @@ add_target_sections_of_objfile (struct objfile *objfile)
if (bfd_section_size (osect->the_bfd_section) == 0) if (bfd_section_size (osect->the_bfd_section) == 0)
continue; continue;
table->emplace_back (obj_section_addr (osect), target_sections.emplace_back (obj_section_addr (osect),
obj_section_endaddr (osect), obj_section_endaddr (osect),
osect->the_bfd_section, (void *) objfile); osect->the_bfd_section, (void *) objfile);
} }

5
gdb/exec.h
View File

@ -92,11 +92,6 @@ extern enum target_xfer_status
/* Set the loaded address of a section. */ /* Set the loaded address of a section. */
extern void exec_set_section_address (const char *, int, CORE_ADDR); extern void exec_set_section_address (const char *, int, CORE_ADDR);
/* Add the sections of OBJFILE to the current set of target sections.
* OBJFILE owns the new target sections. */
extern void add_target_sections_of_objfile (struct objfile *objfile);
/* Prints info about all sections defined in the TABLE. ABFD is /* Prints info about all sections defined in the TABLE. ABFD is
special cased --- it's filename is omitted; if it is the executable special cased --- it's filename is omitted; if it is the executable
file, its entry point is printed. */ file, its entry point is printed. */

4
gdb/progspace.h
View File

@ -305,6 +305,10 @@ struct program_space
void add_target_sections (void *owner, void add_target_sections (void *owner,
const target_section_table &sections); const target_section_table &sections);
/* Add the sections of OBJFILE to the current set of target
sections. They are given OBJFILE as the "owner". */
void add_target_sections (struct objfile *objfile);
/* Unique ID number. */ /* Unique ID number. */
int num = 0; int num = 0;

2
gdb/symfile-mem.c
View File

@ -122,7 +122,7 @@ symbol_file_add_from_memory (struct bfd *templ, CORE_ADDR addr,
objf = symbol_file_add_from_bfd (nbfd, bfd_get_filename (nbfd), objf = symbol_file_add_from_bfd (nbfd, bfd_get_filename (nbfd),
add_flags, &sai, OBJF_SHARED, NULL); add_flags, &sai, OBJF_SHARED, NULL);
add_target_sections_of_objfile (objf); current_program_space->add_target_sections (objf);
/* This might change our ideas about frames already looked at. */ /* This might change our ideas about frames already looked at. */
reinit_frame_cache (); reinit_frame_cache ();

2
gdb/symfile.c
View File

@ -2323,7 +2323,7 @@ add_symbol_file_command (const char *args, int from_tty)
if (seen_offset) if (seen_offset)
set_objfile_default_section_offset (objf, section_addrs, offset); set_objfile_default_section_offset (objf, section_addrs, offset);
add_target_sections_of_objfile (objf); current_program_space->add_target_sections (objf);
/* Getting new symbols may change our opinion about what is /* Getting new symbols may change our opinion about what is
frameless. */ frameless. */