mirror of
https://github.com/espressif/binutils-gdb.git
synced 2025-06-23 03:29:47 +08:00
This is a simple bug. target_disable_btrace and target_teardown_btrace,
both from gdb/target.c, do a "return" calling another function. But both are marked as void. Despite the fact that the functions being called are void as well, this is wrong. This patch fixes this by calling the functions and then returning in the next line. 2013-10-16 Sergio Durigan Junior <sergiodj@redhat.com> PR gdb/16042 * target.c (target_disable_btrace): Fix invalid return value for void function. (target_teardown_btrace): Likewise.
This commit is contained in:
10
gdb/target.c
10
gdb/target.c
@ -4165,7 +4165,10 @@ target_disable_btrace (struct btrace_target_info *btinfo)
|
||||
|
||||
for (t = current_target.beneath; t != NULL; t = t->beneath)
|
||||
if (t->to_disable_btrace != NULL)
|
||||
return t->to_disable_btrace (btinfo);
|
||||
{
|
||||
t->to_disable_btrace (btinfo);
|
||||
return;
|
||||
}
|
||||
|
||||
tcomplain ();
|
||||
}
|
||||
@ -4179,7 +4182,10 @@ target_teardown_btrace (struct btrace_target_info *btinfo)
|
||||
|
||||
for (t = current_target.beneath; t != NULL; t = t->beneath)
|
||||
if (t->to_teardown_btrace != NULL)
|
||||
return t->to_teardown_btrace (btinfo);
|
||||
{
|
||||
t->to_teardown_btrace (btinfo);
|
||||
return;
|
||||
}
|
||||
|
||||
tcomplain ();
|
||||
}
|
||||
|
Reference in New Issue
Block a user