espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-25 21:41:47 +08:00
Code Issues Packages Projects Releases Wiki Activity

avoid unwarranted assumption in gdb.ada/fixed_points/fixed_points.adb

Browse Source 
The test program being used declares a fixed-point type
(Base_Fixed_Point_Type) Base_Fixed_Point_Type whose (scaled) range
is System.Min_Int .. System.Max_Int. is an unwarranted assumption because
the range is implementation-defined. It means the compiler is therefore
free to reject that declaration.

We noticed this while one of my coworkers was working on enhancing
GNAT to support 128bit integers. The bulk of the work has been done,
but one side-effect is that there is a small gap in this particular
area where the compiler is now rejecting this code. We will eventually
plug that gap, but in meantime, since the testcase itself doesn't really
need such a large range, this commit simply adjusts the test program
to use hard-coded bounds for the range whose value are more reasonable.

gdb/testsuite/ChangeLog:

        * gdb.ada/fixed_points/fixed_points.adb: Replace use of
        System.Min_Int and System.Max_Int with smaller hardcoded
        constants.
This commit is contained in:
Joel Brobecker
2020-11-01 15:37:41 +04:00
parent 60bd1d53a0
commit d77c922455
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,9 @@
2020-11-01 Joel Brobecker <brobecker@adacore.com>
* gdb.ada/fixed_points/fixed_points.adb: Replace use of
System.Min_Int and System.Max_Int with smaller hardcoded
constants.
2020-10-31 Simon Marchi <simon.marchi@polymtl.ca> 2020-10-31 Simon Marchi <simon.marchi@polymtl.ca>
* configure.ac: Split AC_INIT into AC_INIT and AC_CONFIG_SRCDIR. * configure.ac: Split AC_INIT into AC_INIT and AC_CONFIG_SRCDIR.

3
gdb/testsuite/gdb.ada/fixed_points/fixed_points.adb
View File

@ -25,8 +25,7 @@ procedure Fixed_Points is
type Base_Fixed_Point_Type is type Base_Fixed_Point_Type is
delta 1.0 / 16.0 delta 1.0 / 16.0
range (System.Min_Int / 2) * 1.0 / 16.0 .. range -2147483648 * 1.0 / 16.0 .. 2147483647 * 1.0 / 16.0;
(System.Max_Int / 2) * 1.0 / 16.0;
subtype Fixed_Point_Subtype is subtype Fixed_Point_Subtype is
Base_Fixed_Point_Type range -50.0 .. 50.0; Base_Fixed_Point_Type range -50.0 .. 50.0;