espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-21 02:24:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

PR29255, memory leak in make_tempdir

Browse Source 
PR 29255
	* bucomm.c (make_tempdir, make_tempname): Free template on all
	failure paths.
This commit is contained in:
Alan Modra
2022-06-17 09:13:38 +09:30
parent 0ebc886149
commit d6e1d48c83
1 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
binutils/bucomm.c
View File

@ -537,7 +537,8 @@ make_tempname (const char *filename, int *ofd)
#else #else
tmpname = mktemp (tmpname); tmpname = mktemp (tmpname);
if (tmpname == NULL) if (tmpname == NULL)
return NULL; fd = -1;
else
fd = open (tmpname, O_RDWR | O_CREAT | O_EXCL, 0600); fd = open (tmpname, O_RDWR | O_CREAT | O_EXCL, 0600);
#endif #endif
if (fd == -1) if (fd == -1)
@ -556,22 +557,23 @@ char *
make_tempdir (const char *filename) make_tempdir (const char *filename)
{ {
char *tmpname = template_in_dir (filename); char *tmpname = template_in_dir (filename);
char *ret;
#ifdef HAVE_MKDTEMP #ifdef HAVE_MKDTEMP
return mkdtemp (tmpname); ret = mkdtemp (tmpname);
#else #else
tmpname = mktemp (tmpname); ret = mktemp (tmpname);
if (tmpname == NULL)
return NULL;
#if defined (_WIN32) && !defined (__CYGWIN32__) #if defined (_WIN32) && !defined (__CYGWIN32__)
if (mkdir (tmpname) != 0) if (mkdir (tmpname) != 0)
return NULL; ret = NULL;
#else #else
if (mkdir (tmpname, 0700) != 0) if (mkdir (tmpname, 0700) != 0)
return NULL; ret = NULL;
#endif #endif
return tmpname;
#endif #endif
if (ret == NULL)
free (tmpname);
return ret;
} }
/* Parse a string into a VMA, with a fatal error if it can't be /* Parse a string into a VMA, with a fatal error if it can't be