espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-20 09:58:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

PR29255, memory leak in make_tempdir

Browse Source 
PR 29255
	* bucomm.c (make_tempdir, make_tempname): Free template on all
	failure paths.
This commit is contained in:
Alan Modra
2022-06-17 09:13:38 +09:30
parent 0ebc886149
commit d6e1d48c83
1 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
binutils/bucomm.c
View File

@ -537,8 +537,9 @@ make_tempname (const char *filename, int *ofd)
#else
tmpname = mktemp (tmpname);
if (tmpname == NULL)
return NULL;
fd = open (tmpname, O_RDWR | O_CREAT | O_EXCL, 0600);
fd = -1;
else
fd = open (tmpname, O_RDWR | O_CREAT | O_EXCL, 0600);
#endif
if (fd == -1)
{
@ -556,22 +557,23 @@ char *
make_tempdir (const char *filename)
{
char *tmpname = template_in_dir (filename);
char *ret;
#ifdef HAVE_MKDTEMP
return mkdtemp (tmpname);
ret = mkdtemp (tmpname);
#else
tmpname = mktemp (tmpname);
if (tmpname == NULL)
return NULL;
ret = mktemp (tmpname);
#if defined (_WIN32) && !defined (__CYGWIN32__)
if (mkdir (tmpname) != 0)
return NULL;
ret = NULL;
#else
if (mkdir (tmpname, 0700) != 0)
return NULL;
ret = NULL;
#endif
return tmpname;
#endif
if (ret == NULL)
free (tmpname);
return ret;
}
/* Parse a string into a VMA, with a fatal error if it can't be