espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-19 00:59:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

Uniquify test names from gdb.python/{py-objfile.exp,py-pp-registration.exp}

Browse Source 
While running some regression tests, I noticed that the two Python
tests mentioned in the $SUBJECT contain non-unique names.  This is a
violation of our guidelines:

  <https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Make_sure_test_messages_are_unique>

And also makes things harder for BuildBot.  So I hacked both testcases
and made every test name unique.  I guess this could be considered an
obvious patch, but I decided to post it before pushing because others
may have different opinions about the names.

OK to apply?

gdb/testsuite/ChangeLog:
2015-07-28  Sergio Durigan Junior  <sergiodj@redhat.com>

	* gdb.python/py-objfile.exp: Make some tests have unique names.
	* gdb.python/py-pp-registration.exp: Likewise.
This commit is contained in:
Sergio Durigan Junior
2015-07-28 17:38:14 -04:00
parent bde40b8f56
commit d60a92216e
3 changed files with 22 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2015-07-28 Sergio Durigan Junior <sergiodj@redhat.com>
* gdb.python/py-objfile.exp: Make some tests have unique names.
* gdb.python/py-pp-registration.exp: Likewise.
2015-07-28 Pedro Alves <palves@redhat.com> 2015-07-28 Pedro Alves <palves@redhat.com>
* gdb.server/server-exec-info.exp: Issue a "disconnect". * gdb.server/server-exec-info.exp: Issue a "disconnect".

15
gdb/testsuite/gdb.python/py-objfile.exp
View File

@ -46,7 +46,7 @@ gdb_test "python print (objfile.username)" "${testfile}" \
"Get objfile user name" "Get objfile user name"
gdb_test "python print (gdb.lookup_objfile (\"${testfile}\").filename)" \ gdb_test "python print (gdb.lookup_objfile (\"${testfile}\").filename)" \
"${testfile}" "${testfile}" "print lookup_objfile filename"
gdb_test "python print (gdb.lookup_objfile (\"junk\"))" \ gdb_test "python print (gdb.lookup_objfile (\"junk\"))" \
"Objfile not found\\.\r\n${python_error_text}" "Objfile not found\\.\r\n${python_error_text}"
@ -56,7 +56,7 @@ if [string compare $binfile_build_id ""] {
gdb_test "python print (objfile.build_id)" "$binfile_build_id" \ gdb_test "python print (objfile.build_id)" "$binfile_build_id" \
"Get objfile build id" "Get objfile build id"
gdb_test "python print (gdb.lookup_objfile (\"$binfile_build_id\", by_build_id=True).filename)" \ gdb_test "python print (gdb.lookup_objfile (\"$binfile_build_id\", by_build_id=True).filename)" \
"${testfile}" "${testfile}" "print lookup_objfile filename by build-id"
} else { } else {
unsupported "build-id is not supported by the compiler" unsupported "build-id is not supported by the compiler"
} }
@ -64,9 +64,11 @@ if [string compare $binfile_build_id ""] {
# Other lookup_objfile_by_build_id tests we can do, even if compiler doesn't # Other lookup_objfile_by_build_id tests we can do, even if compiler doesn't
# support them. # support them.
gdb_test "python print (gdb.lookup_objfile (\"foo\", by_build_id=True))" \ gdb_test "python print (gdb.lookup_objfile (\"foo\", by_build_id=True))" \
"Not a valid build id\\.\r\n${python_error_text}" "Not a valid build id\\.\r\n${python_error_text}" \
"print invalid file lookup_objfile by build-id"
gdb_test "python print (gdb.lookup_objfile (\"1234abcdef\", by_build_id=True))" \ gdb_test "python print (gdb.lookup_objfile (\"1234abcdef\", by_build_id=True))" \
"Objfile not found\\.\r\n${python_error_text}" "Objfile not found\\.\r\n${python_error_text}" \
"print invalid file lookup_objfile by build-id 2"
gdb_test "python print (objfile.progspace)" "<gdb\.Progspace object at .*>" \ gdb_test "python print (objfile.progspace)" "<gdb\.Progspace object at .*>" \
"Get objfile program space" "Get objfile program space"
@ -104,7 +106,7 @@ if ![runto_main] {
return 0 return 0
} }
gdb_py_test_silent_cmd "python objfile = gdb.objfiles()\[0\]" \ gdb_py_test_silent_cmd "python objfile = gdb.s()\[0\]" \
"Get no-debug objfile file" 1 "Get no-debug objfile file" 1
gdb_test "python print (objfile.owner)" "None" \ gdb_test "python print (objfile.owner)" "None" \
@ -131,7 +133,8 @@ gdb_test "p main" "= {int \\(\\)} $hex <main>" \
# Separate debug files are not findable. # Separate debug files are not findable.
if { [get_python_valueof "sep_objfile.build_id" "None"] != "None" } { if { [get_python_valueof "sep_objfile.build_id" "None"] != "None" } {
gdb_test "python print (gdb.lookup_objfile (sep_objfile.build_id, by_build_id=True))" \ gdb_test "python print (gdb.lookup_objfile (sep_objfile.build_id, by_build_id=True))" \
"Objfile not found\\.\r\n${python_error_text}" "Objfile not found\\.\r\n${python_error_text}" \
"print lookup_objfile of separate debug file"
} }
# An objfile that was a symlink to a differently named file is still # An objfile that was a symlink to a differently named file is still

7
gdb/testsuite/gdb.python/py-pp-registration.exp
View File

@ -46,7 +46,8 @@ proc prepare_test { } {
return 0 return 0
} }
gdb_test_no_output "python exec (open ('${remote_python_file}').read ())" gdb_test_no_output "python exec (open ('${remote_python_file}').read ())" \
"read file"
gdb_test_no_output "py progspace = gdb.current_progspace()" gdb_test_no_output "py progspace = gdb.current_progspace()"
gdb_test_no_output "py my_pretty_printer1 = build_pretty_printer1()" gdb_test_no_output "py my_pretty_printer1 = build_pretty_printer1()"
@ -108,9 +109,13 @@ with_test_prefix "replace" {
gdb_test "py gdb.printing.register_pretty_printer(progspace, my_pretty_printer2, replace=False)" \ gdb_test "py gdb.printing.register_pretty_printer(progspace, my_pretty_printer2, replace=False)" \
"RuntimeError: pretty-printer already registered: pp-test\r\nError while executing Python code." "RuntimeError: pretty-printer already registered: pp-test\r\nError while executing Python code."
with_test_prefix "test printers 1" {
test_printers "s1" test_printers "s1"
}
gdb_test_no_output "py gdb.printing.register_pretty_printer(progspace, my_pretty_printer2, replace=True)" gdb_test_no_output "py gdb.printing.register_pretty_printer(progspace, my_pretty_printer2, replace=True)"
with_test_prefix "test printers 2" {
test_printers "s2" test_printers "s2"
} }
}