gdb: add gdb_argv::as_array_view method

Introduce the gdb_argv::as_array_view method, as a way to easily pass
the parsed arguments array to a function taking an array view.  There is
currently one caller where we can use this (which prompted the
suggestion to implement this method).

Add some selftests for the new method, which at the same time test a
little bit gdb_argv.  As far as I know, it's not tested currently.

gdb/ChangeLog:

	* utils.h (class gdb_argv) <as_array_view>: New method.
	* utils.c (gdb_argv_as_array_view_test): New.
	(_initialize_utils): Register selftest.
	* maint.c (maintenance_selftest): Use the new method.

Change-Id: I0645037613ed6549aabe60f14a36f3494513b177
This commit is contained in:
Simon Marchi
2020-08-14 12:27:22 -04:00
committed by Simon Marchi
parent 19bddbe95c
commit d369b608a1
4 changed files with 42 additions and 1 deletions

View File

@ -22,6 +22,7 @@
#define UTILS_H
#include "exceptions.h"
#include "gdbsupport/array-view.h"
#include "gdbsupport/scoped_restore.h"
#include <chrono>
@ -210,6 +211,13 @@ public:
return m_argv[arg];
}
/* Return the arguments array as an array view. */
gdb::array_view<char *> as_array_view ()
{
return gdb::array_view<char *> (this->get (), this->count ());
}
/* The iterator type. */
typedef char **iterator;