espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-18 00:32:30 +08:00
Code Issues Packages Projects Releases Wiki Activity

bfd: avoid infinite loop when static linking XCOFF

Browse Source 
git commit b95a0a3177bc changed a "return FALSE" to "continue", and
missed updating the while loop iterator.

	* xcofflink.c (xcoff_link_check_ar_symbols): Update esym earlier.
This commit is contained in:
Clément Chigot
2021-04-13 08:32:55 +02:00
committed by Alan Modra
parent 1cfc6f00e4
commit d2f1139ef0
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
bfd/ChangeLog
View File

@ -1,3 +1,7 @@
2021-04-13 Clément Chigot <clement.chigot@atos.net>
* xcofflink.c (xcoff_link_check_ar_symbols): Update esym earlier.
2021-04-13 Nelson Chu <nelson.chu@sifive.com> 2021-04-13 Nelson Chu <nelson.chu@sifive.com>
* elfnn-riscv.c (riscv_version_mismatch): Do not report the warning * elfnn-riscv.c (riscv_version_mismatch): Do not report the warning

3
bfd/xcofflink.c
View File

@ -2349,6 +2349,7 @@ xcoff_link_check_ar_symbols (bfd *abfd,
struct internal_syment sym; struct internal_syment sym;
bfd_coff_swap_sym_in (abfd, (void *) esym, (void *) &sym); bfd_coff_swap_sym_in (abfd, (void *) esym, (void *) &sym);
esym += (sym.n_numaux + 1) * symesz;
if (EXTERN_SYM_P (sym.n_sclass) && sym.n_scnum != N_UNDEF) if (EXTERN_SYM_P (sym.n_sclass) && sym.n_scnum != N_UNDEF)
{ {
@ -2382,8 +2383,6 @@ xcoff_link_check_ar_symbols (bfd *abfd,
return true; return true;
} }
} }
esym += (sym.n_numaux + 1) * symesz;
} }
/* We do not need this object file. */ /* We do not need this object file. */