espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-20 01:50:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix ridiculously small memory leak.

Browse Source 
PR 24001
	* objcopy.c (copy_object): Free dhandle after writing out the
	debug information.
	* objdump.c (dump_bfd): Free dhandle after printing out the debug
	information.
This commit is contained in:
Nick Clifton
2019-01-04 12:11:51 +00:00
parent 677bd4c69d
commit cf0ad5bbf2
3 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
binutils/ChangeLog
View File

@ -1,3 +1,11 @@
2019-01-04 Nick Clifton <nickc@redhat.com>
PR 24001
* objcopy.c (copy_object): Free dhandle after writing out the
debug information.
* objdump.c (dump_bfd): Free dhandle after printing out the debug
information.
2019-01-01 Alan Modra <amodra@gmail.com> 2019-01-01 Alan Modra <amodra@gmail.com>
Update year range in copyright notice of all files. Update year range in copyright notice of all files.

9
binutils/objcopy.c
View File

@ -3087,7 +3087,14 @@ copy_object (bfd *ibfd, bfd *obfd, const bfd_arch_info_type *input_arch)
if (convert_debugging && dhandle != NULL) if (convert_debugging && dhandle != NULL)
{ {
if (! write_debugging_info (obfd, dhandle, &symcount, &osympp)) bfd_boolean res;
res = write_debugging_info (obfd, dhandle, &symcount, &osympp);
free (dhandle);
dhandle = NULL; /* Paranoia... */
if (! res)
{ {
status = 1; status = 1;
return FALSE; return FALSE;

2
binutils/objdump.c
View File

@ -3692,6 +3692,8 @@ dump_bfd (bfd *abfd)
bfd_get_filename (abfd)); bfd_get_filename (abfd));
exit_status = 1; exit_status = 1;
} }
free (dhandle);
} }
/* PR 6483: If there was no STABS debug info in the file, try /* PR 6483: If there was no STABS debug info in the file, try
DWARF instead. */ DWARF instead. */