espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-20 01:50:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

PR29613, use of uninitialized value in objcopy

Browse Source 
PR 29613
	* elf.c (_bfd_elf_write_secondary_reloc_section): Trim sh_size
	back to relocs written.  Use better types for vars.
This commit is contained in:
Alan Modra
2022-09-26 18:25:24 +09:30
parent c21736aed1
commit c7afb87bea
1 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
bfd/elf.c
View File

@ -13482,9 +13482,9 @@ _bfd_elf_write_secondary_reloc_section (bfd *abfd, asection *sec)
{ {
asymbol * last_sym; asymbol * last_sym;
int last_sym_idx; int last_sym_idx;
unsigned int reloc_count; size_t reloc_count;
unsigned int idx; size_t idx;
unsigned int entsize; bfd_size_type entsize;
arelent * src_irel; arelent * src_irel;
bfd_byte * dst_rela; bfd_byte * dst_rela;
@ -13525,7 +13525,8 @@ _bfd_elf_write_secondary_reloc_section (bfd *abfd, asection *sec)
} }
reloc_count = hdr->sh_size / entsize; reloc_count = hdr->sh_size / entsize;
if (reloc_count <= 0) hdr->sh_size = entsize * reloc_count;
if (reloc_count == 0)
{ {
_bfd_error_handler _bfd_error_handler
/* xgettext:c-format */ /* xgettext:c-format */
@ -13572,7 +13573,7 @@ _bfd_elf_write_secondary_reloc_section (bfd *abfd, asection *sec)
{ {
_bfd_error_handler _bfd_error_handler
/* xgettext:c-format */ /* xgettext:c-format */
(_("%pB(%pA): error: reloc table entry %u is empty"), (_("%pB(%pA): error: reloc table entry %zu is empty"),
abfd, relsec, idx); abfd, relsec, idx);
bfd_set_error (bfd_error_bad_value); bfd_set_error (bfd_error_bad_value);
result = false; result = false;
@ -13597,7 +13598,7 @@ _bfd_elf_write_secondary_reloc_section (bfd *abfd, asection *sec)
{ {
_bfd_error_handler _bfd_error_handler
/* xgettext:c-format */ /* xgettext:c-format */
(_("%pB(%pA): error: secondary reloc %u" (_("%pB(%pA): error: secondary reloc %zu"
" references a missing symbol"), " references a missing symbol"),
abfd, relsec, idx); abfd, relsec, idx);
bfd_set_error (bfd_error_bad_value); bfd_set_error (bfd_error_bad_value);
@ -13615,7 +13616,7 @@ _bfd_elf_write_secondary_reloc_section (bfd *abfd, asection *sec)
{ {
_bfd_error_handler _bfd_error_handler
/* xgettext:c-format */ /* xgettext:c-format */
(_("%pB(%pA): error: secondary reloc %u" (_("%pB(%pA): error: secondary reloc %zu"
" references a deleted symbol"), " references a deleted symbol"),
abfd, relsec, idx); abfd, relsec, idx);
bfd_set_error (bfd_error_bad_value); bfd_set_error (bfd_error_bad_value);
@ -13629,7 +13630,7 @@ _bfd_elf_write_secondary_reloc_section (bfd *abfd, asection *sec)
{ {
_bfd_error_handler _bfd_error_handler
/* xgettext:c-format */ /* xgettext:c-format */
(_("%pB(%pA): error: secondary reloc %u" (_("%pB(%pA): error: secondary reloc %zu"
" is of an unknown type"), " is of an unknown type"),
abfd, relsec, idx); abfd, relsec, idx);
bfd_set_error (bfd_error_bad_value); bfd_set_error (bfd_error_bad_value);