espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-21 18:39:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

[gdb/testsuite] Don't require gold for gdb.base/morestack.exp

Browse Source 
While working on PR26935 I noticed that the test-case requires the gold
linker, but doesn't really need it.

The -fuse-ld=gold was added to support the printf in the test-case, which
prints some information but is not otherwise needed for the test-case.

Fix this by removing the printf and the corresponding -fuse-ld=gold.

Tested on x86_64-linux.

Also checked that the test still fails when the fix from the commit that added
the test-case is reverted.

gdb/testsuite/ChangeLog:

2021-01-04  Tom de Vries  <tdevries@suse.de>

	* gdb.base/morestack.c: Remove printf.
	* gdb.base/morestack.exp: Don't use -fuse-ld=gold.
This commit is contained in:
Tom de Vries
2021-01-04 16:48:48 +01:00
parent 098caef485
commit c5e71b3332
3 changed files with 7 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2021-01-04 Tom de Vries <tdevries@suse.de>
* gdb.base/morestack.c: Remove printf.
* gdb.base/morestack.exp: Don't use -fuse-ld=gold.
2020-12-31 Tom Tromey <tom@tromey.com> 2020-12-31 Tom Tromey <tom@tromey.com>
* gdb.rust/simple.exp: Update output for Rust 1.49. * gdb.rust/simple.exp: Update output for Rust 1.49.

5
gdb/testsuite/gdb.base/morestack.c
View File

@ -62,10 +62,7 @@ down (int i)
static void *last; static void *last;
if (last && last < (void *) buf) if (last && last < (void *) buf)
{ marker_hit ();
printf ("%d: %p < %p\n", i, last, buf);
marker_hit ();
}
last = buf; last = buf;
if (i == 500) if (i == 500)

8
gdb/testsuite/gdb.base/morestack.exp
View File

@ -21,17 +21,11 @@ if {$gcc_compiled == 0} {
return -1 return -1
} }
if { [have_fuse_ld_gold] == 0} {
return -1
}
standard_testfile standard_testfile
# -fuse-ld=gold is used for calling printf code built without -fsplit-stack
# which could crash otherwise. See GCC documentation of -fsplit-stack.
set opts "additional_flags=-fsplit-stack" set opts "additional_flags=-fsplit-stack"
if { [prepare_for_testing "failed to prepare" ${testfile} $srcfile \ if { [prepare_for_testing "failed to prepare" ${testfile} $srcfile \
[list $opts additional_flags=-fuse-ld=gold]] } { [list $opts]] } {
return -1 return -1
} }