espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-27 14:39:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

tfile_target::close: trace_fd can't be -1

Browse Source 
It's not possible to open a tfile target with an invalid trace_fd, and
it's not possible to close a closed target, so this early return is dead.

gdb/ChangeLog:
2020-01-10  Pedro Alves  <palves@redhat.com>

	* tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
	not -1.
This commit is contained in:
Pedro Alves
2020-01-10 20:05:50 +00:00
parent ab1ddbcf11
commit c17e02e1b5
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2020-01-10 Pedro Alves <palves@redhat.com>
* tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
not -1.
2020-01-10 Pedro Alves <palves@redhat.com> 2020-01-10 Pedro Alves <palves@redhat.com>
* break-catch-sig.c (signal_catchpoint_print_it): Don't pass a * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a

3
gdb/tracefile-tfile.c
View File

@ -616,8 +616,7 @@ tfile_interp_line (char *line, struct uploaded_tp **utpp,
void void
tfile_target::close () tfile_target::close ()
{ {
if (trace_fd < 0) gdb_assert (trace_fd != -1);
return;
inferior_ptid = null_ptid; /* Avoid confusion from thread stuff. */ inferior_ptid = null_ptid; /* Avoid confusion from thread stuff. */
exit_inferior_silent (current_inferior ()); exit_inferior_silent (current_inferior ());