2001-02-28 Michael Snyder <msnyder@mvstp600e.cygnus.com>

* printcmd.c (print_address_numeric): Update comments to refer
	to sizeof addr, not sizeof pointer.
	(x_command): Remove needless whitespace (shorten long line).
This commit is contained in:
Michael Snyder
2001-03-01 03:56:45 +00:00
parent d85310f71a
commit c0d8fd9a10
2 changed files with 11 additions and 5 deletions

View File

@ -1,5 +1,9 @@
2001-02-28 Michael Snyder <msnyder@mvstp600e.cygnus.com> 2001-02-28 Michael Snyder <msnyder@mvstp600e.cygnus.com>
* printcmd.c (print_address_numeric): Update comments to refer
to sizeof addr, not sizeof pointer.
(x_command): Remove needless whitespace (shorten long line).
* breakpoint.c (print_one_breakpoint): Formatting clean-up. * breakpoint.c (print_one_breakpoint): Formatting clean-up.
(read_memory_nobpt): Ditto. (read_memory_nobpt): Ditto.
(ep_is_catchpoint): Ditto. (ep_is_catchpoint): Ditto.

View File

@ -718,15 +718,17 @@ build_address_symbolic (CORE_ADDR addr, /* IN */
void void
print_address_numeric (CORE_ADDR addr, int use_local, struct ui_file *stream) print_address_numeric (CORE_ADDR addr, int use_local, struct ui_file *stream)
{ {
/* Truncate address to the size of a target pointer, avoiding shifts /* Truncate address to the size of a target address, avoiding shifts
larger or equal than the width of a CORE_ADDR. The local larger or equal than the width of a CORE_ADDR. The local
variable PTR_BIT stops the compiler reporting a shift overflow variable ADDR_BIT stops the compiler reporting a shift overflow
when it won't occure. */ when it won't occur. */
/* NOTE: This assumes that the significant address information is /* NOTE: This assumes that the significant address information is
kept in the least significant bits of ADDR - the upper bits were kept in the least significant bits of ADDR - the upper bits were
either zero or sign extended. Should ADDRESS_TO_POINTER() or either zero or sign extended. Should ADDRESS_TO_POINTER() or
some ADDRESS_TO_PRINTABLE() be used to do the conversion? */ some ADDRESS_TO_PRINTABLE() be used to do the conversion? */
int addr_bit = TARGET_ADDR_BIT; int addr_bit = TARGET_ADDR_BIT;
if (addr_bit < (sizeof (CORE_ADDR) * HOST_CHAR_BIT)) if (addr_bit < (sizeof (CORE_ADDR) * HOST_CHAR_BIT))
addr &= ((CORE_ADDR) 1 << addr_bit) - 1; addr &= ((CORE_ADDR) 1 << addr_bit) - 1;
print_longest (stream, 'x', use_local, (ULONGEST) addr); print_longest (stream, 'x', use_local, (ULONGEST) addr);
@ -1334,8 +1336,8 @@ x_command (char *exp, int from_tty)
val = value_ind (val); val = value_ind (val);
/* In rvalue contexts, such as this, functions are coerced into /* In rvalue contexts, such as this, functions are coerced into
pointers to functions. This makes "x/i main" work. */ pointers to functions. This makes "x/i main" work. */
if ( /* last_format == 'i' if (/* last_format == 'i' && */
&& */ TYPE_CODE (VALUE_TYPE (val)) == TYPE_CODE_FUNC TYPE_CODE (VALUE_TYPE (val)) == TYPE_CODE_FUNC
&& VALUE_LVAL (val) == lval_memory) && VALUE_LVAL (val) == lval_memory)
next_address = VALUE_ADDRESS (val); next_address = VALUE_ADDRESS (val);
else else