espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-26 13:56:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove an abort in the bfd library and add a check for an integer overflow when mapping sections to segments.

Browse Source 
PR 23932
	* elf.c (IS_CONTAINED_BY_LMA): Add a check for a negative section
	size.
	(rewrite_elf_program_header): If no sections are mapped into a
	segment return an error.
This commit is contained in:
Nick Clifton
2018-11-30 11:43:12 +00:00
parent ba85c15dab
commit beab453223
2 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
bfd/ChangeLog
View File

@ -1,3 +1,11 @@
2018-11-30 Nick Clifton <nickc@redhat.com>
PR 23932
* elf.c (IS_CONTAINED_BY_LMA): Add a check for a negative section
size.
(rewrite_elf_program_header): If no sections are mapped into a
segment return an error.
2018-11-30 Alan Modra <amodra@gmail.com> 2018-11-30 Alan Modra <amodra@gmail.com>
PR 23937 PR 23937

11
bfd/elf.c
View File

@ -6644,6 +6644,7 @@ rewrite_elf_program_header (bfd *ibfd, bfd *obfd)
the given segment. LMA addresses are compared. */ the given segment. LMA addresses are compared. */
#define IS_CONTAINED_BY_LMA(section, segment, base) \ #define IS_CONTAINED_BY_LMA(section, segment, base) \
(section->lma >= base \ (section->lma >= base \
&& (section->lma + SECTION_SIZE (section, segment) >= section->lma) \
&& (section->lma + SECTION_SIZE (section, segment) \ && (section->lma + SECTION_SIZE (section, segment) \
<= SEGMENT_END (segment, base))) <= SEGMENT_END (segment, base)))
@ -7167,7 +7168,15 @@ rewrite_elf_program_header (bfd *ibfd, bfd *obfd)
suggested_lma = output_section; suggested_lma = output_section;
} }
BFD_ASSERT (map->count > 0); /* PR 23932. A corrupt input file may contain sections that cannot
be assigned to any segment - because for example they have a
negative size - or segments that do not contain any sections. */
if (map->count == 0)
{
bfd_set_error (bfd_error_bad_value);
free (sections);
return FALSE;
}
/* Add the current segment to the list of built segments. */ /* Add the current segment to the list of built segments. */
*pointer_to_map = map; *pointer_to_map = map;