espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-21 10:34:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

aarch64-pe can't fill 16 bytes in section .text

Browse Source 
Without commit b66e671854, this:
 .p2align 4
 nop
 .p2align 3
 nop
results in an error when coff_frob_section attempts to pad out the
section to a 16-byte boundary.  Due to miscalculating the pad pattern
repeat count, write.c:write_contents attempts to shove 16 bytes of
padding into the remaining 4 bytes of the .text section.

	* config/obj-coff.c (coff_frob_section): Correct fill count.
	Don't pad after errors.
This commit is contained in:
Alan Modra
2022-11-15 18:43:43 +10:30
parent 02dbc2b9e7
commit bc8f3910c0
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gas/config/obj-coff.c
View File

@ -1725,7 +1725,8 @@ coff_frob_section (segT sec)
bfd_vma align_power = (bfd_vma) sec->alignment_power + OCTETS_PER_BYTE_POWER; bfd_vma align_power = (bfd_vma) sec->alignment_power + OCTETS_PER_BYTE_POWER;
bfd_vma mask = ((bfd_vma) 1 << align_power) - 1; bfd_vma mask = ((bfd_vma) 1 << align_power) - 1;
if (size & mask) if (!do_not_pad_sections_to_alignment
&& (size & mask) != 0)
{ {
bfd_vma new_size; bfd_vma new_size;
fragS *last; fragS *last;
@ -1740,7 +1741,10 @@ coff_frob_section (segT sec)
while (fragp->fr_next != last) while (fragp->fr_next != last)
fragp = fragp->fr_next; fragp = fragp->fr_next;
last->fr_address = size; last->fr_address = size;
fragp->fr_offset += new_size - size; if ((new_size - size) % fragp->fr_var == 0)
fragp->fr_offset += (new_size - size) / fragp->fr_var;
else
abort ();
} }
#endif #endif