espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-30 17:31:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix buffer underflow in add_path

Browse Source 
Address sanitizer pointed out a buglet in source.c:add_path.
In this test, from gdb.base/source-dir.exp:

    (gdb) set directories :/foo:/bar

... 'p[-1]' will result in a buffer underflow.
This patch fixes the bug by introducing a new check.

2021-05-17  Tom Tromey  <tromey@adacore.com>

	* source.c (add_path): Check 'p' before using 'p[-1]'.
This commit is contained in:
Tom Tromey
2021-05-17 12:55:18 -06:00
parent 473ab96443
commit baea2f9d52
2 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/ChangeLog
View File

@ -1,3 +1,7 @@
2021-05-17 Tom Tromey <tromey@adacore.com>
* source.c (add_path): Check 'p' before using 'p[-1]'.
2021-05-17 Tom Tromey <tromey@adacore.com> 2021-05-17 Tom Tromey <tromey@adacore.com>
* dwarf2/read.h (struct dwarf2_per_cu_data_deleter: New. * dwarf2/read.h (struct dwarf2_per_cu_data_deleter: New.

1
gdb/source.c
View File

@ -537,6 +537,7 @@ add_path (const char *dirname, char **which_path, int parse_separators)
/* On MS-DOS and MS-Windows, h:\ is different from h: */ /* On MS-DOS and MS-Windows, h:\ is different from h: */
&& !(p == name + 3 && name[1] == ':') /* "d:/" */ && !(p == name + 3 && name[1] == ':') /* "d:/" */
#endif #endif
&& p > name
&& IS_DIR_SEPARATOR (p[-1])) && IS_DIR_SEPARATOR (p[-1]))
/* Sigh. "foo/" => "foo" */ /* Sigh. "foo/" => "foo" */
--p; --p;