espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-25 04:49:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix the race in gdb.threads/staticthreads.exp

Browse Source 
The code in gdb.threads/staticthreads.exp about checking the value of
tlsvar in main thread is racy, because when child thread hits
breakpoint, the main thread may not go into pthread_join yet, and
may not be unwind to main.

This patch is to move the line setting breakpoint on after sem_wait,
so that the child thread will hit breakpoint after main thread calls
sem_post.  IOW, when child thread hits breakpoint, the main thread is
in either sem_post or pthread_join.  "up 10" can unwind main thread to
main.

gdb/testsuite:

2014-06-06  Yao Qi  <yao@codesourcery.com>

	* gdb.threads/staticthreads.c (thread_function): Move the line
	setting breakpoint on forward.
	* gdb.threads/staticthreads.exp: Update comments.
This commit is contained in:
Yao Qi
2014-06-05 15:07:47 +08:00
parent 872a9dd881
commit b8b91e982e
3 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,9 @@
2014-06-06 Yao Qi <yao@codesourcery.com>
* gdb.threads/staticthreads.c (thread_function): Move the line
setting breakpoint on forward.
* gdb.threads/staticthreads.exp: Update comments.
2014-06-05 Ludovic Courtès <ludo@gnu.org> 2014-06-05 Ludovic Courtès <ludo@gnu.org>
* gdb.guile/scm-value.exp (test_value_in_inferior): Add test * gdb.guile/scm-value.exp (test_value_in_inferior): Add test

2
gdb/testsuite/gdb.threads/staticthreads.c
View File

@ -38,7 +38,6 @@ thread_function (void *arg)
#ifdef HAVE_TLS #ifdef HAVE_TLS
tlsvar = 2; tlsvar = 2;
#endif #endif
printf ("Thread executing\n"); /* tlsvar-is-set */
while (sem_wait (&semaphore) != 0) while (sem_wait (&semaphore) != 0)
{ {
if (errno != EINTR) if (errno != EINTR)
@ -47,6 +46,7 @@ thread_function (void *arg)
return NULL; return NULL;
} }
} }
printf ("Thread executing\n"); /* tlsvar-is-set */
return NULL; return NULL;
} }

2
gdb/testsuite/gdb.threads/staticthreads.exp
View File

@ -105,7 +105,7 @@ if { "$have_tls" != "" } {
gdb_continue_to_breakpoint "tlsvar-is-set" ".* tlsvar-is-set .*" gdb_continue_to_breakpoint "tlsvar-is-set" ".* tlsvar-is-set .*"
gdb_test "p tlsvar" " = 2" "tlsvar in thread" gdb_test "p tlsvar" " = 2" "tlsvar in thread"
gdb_test "thread 1" ".*" gdb_test "thread 1" ".*"
# Unwind from pthread_join. # Unwind to main.
gdb_test "up 10" " in main .*" gdb_test "up 10" " in main .*"
gdb_test "p tlsvar" " = 1" "tlsvar in main" gdb_test "p tlsvar" " = 1" "tlsvar in main"
} }