espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-20 09:58:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

[testsuite] Don't use 'testfile' before 'standard_testfile'.

Browse Source 
While running tests on arm-none-eabi, I noticed following errors in some
gdb.threads tests.

ERROR: can't read "testfile": no such variable

These were being caused by ${testfile} being used before 'standard_testfile'
which sets it. This patch just moves standard_testfile before the use.

2021-02-09  Abid Qadeer  <abidh@codesourcery.com>

	gdb/testsuite/ChangeLog:

	* gdb.threads/signal-command-handle-nopass.exp: Call
	'standard_testfile' before using 'testfile'.
	* gdb.threads/signal-command-multiple-signals-pending.exp: Likewise.
	* gdb.threads/signal-delivered-right-thread.exp: Likewise
	* gdb.threads/signal-sigtrap.exp: Likewise
This commit is contained in:
Hafiz Abid Qadeer
2021-02-09 17:11:28 +00:00
parent f73e424f7b
commit b61f78118a
5 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,11 @@
2021-02-09 Abid Qadeer <abidh@codesourcery.com>
* gdb.threads/signal-command-handle-nopass.exp: Call
'standard_testfile' before using 'testfile'.
* gdb.threads/signal-command-multiple-signals-pending.exp: Likewise.
* gdb.threads/signal-delivered-right-thread.exp: Likewise
* gdb.threads/signal-sigtrap.exp: Likewise
2021-02-08 Luis Machado <luis.machado@linaro.org> 2021-02-08 Luis Machado <luis.machado@linaro.org>
* gdb.base/gnu-ifunc.exp (build): Pass -Wl,z,lazy. * gdb.base/gnu-ifunc.exp (build): Pass -Wl,z,lazy.

4
gdb/testsuite/gdb.threads/signal-command-handle-nopass.exp
View File

@ -18,13 +18,13 @@
# delivered to the right thread, even if GDB has to step over a # delivered to the right thread, even if GDB has to step over a
# breakpoint in some other thread first. # breakpoint in some other thread first.
standard_testfile
if [target_info exists gdb,nosignals] { if [target_info exists gdb,nosignals] {
verbose "Skipping ${testfile}.exp because of nosignals." verbose "Skipping ${testfile}.exp because of nosignals."
return -1 return -1
} }
standard_testfile
if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" \ if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" \
executable { debug }] != "" } { executable { debug }] != "" } {
return -1 return -1

4
gdb/testsuite/gdb.threads/signal-command-multiple-signals-pending.exp
View File

@ -16,13 +16,13 @@
# Test that "signal FOO" behaves correctly when we have multiple # Test that "signal FOO" behaves correctly when we have multiple
# threads that have stopped for a signal. # threads that have stopped for a signal.
standard_testfile
if [target_info exists gdb,nosignals] { if [target_info exists gdb,nosignals] {
verbose "Skipping ${testfile}.exp because of nosignals." verbose "Skipping ${testfile}.exp because of nosignals."
return -1 return -1
} }
standard_testfile
if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" \ if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" \
executable { debug }] != "" } { executable { debug }] != "" } {
return -1 return -1

4
gdb/testsuite/gdb.threads/signal-delivered-right-thread.exp
View File

@ -13,13 +13,13 @@
# You should have received a copy of the GNU General Public License # You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>. */ # along with this program. If not, see <http://www.gnu.org/licenses/>. */
standard_testfile
if [target_info exists gdb,nosignals] { if [target_info exists gdb,nosignals] {
verbose "Skipping ${testfile}.exp because of nosignals." verbose "Skipping ${testfile}.exp because of nosignals."
return -1 return -1
} }
standard_testfile
if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" \ if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" \
executable { debug }] != "" } { executable { debug }] != "" } {
return -1 return -1

4
gdb/testsuite/gdb.threads/signal-sigtrap.exp
View File

@ -16,13 +16,13 @@
# Check that GDB doesn't forget to pass SIGTRAP to the program when # Check that GDB doesn't forget to pass SIGTRAP to the program when
# the user explicitly passes it with the signal command. # the user explicitly passes it with the signal command.
standard_testfile
if [target_info exists gdb,nosignals] { if [target_info exists gdb,nosignals] {
verbose "Skipping ${testfile}.exp because of nosignals." verbose "Skipping ${testfile}.exp because of nosignals."
return -1 return -1
} }
standard_testfile
if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug pthreads}]} { if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug pthreads}]} {
return -1 return -1
} }