espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-06 23:50:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

Simplify regcache_dup

Browse Source 
regcache_dup, in fact, is to create a readonly regcache from a
non-readonly regcache.  This patch adds an assert that src is not
readonly.

gdb:

2017-04-28  Yao Qi  <yao.qi@linaro.org>

	* regcache.c (regcache_dup): Assert !src->m_readonly_p and
	call method save instead of regcache_cpy.
	* regcache.h (struct regcache): Make regcache_dup a friend.
This commit is contained in:
Yao Qi
2017-04-28 22:48:42 +01:00
parent ef79d9a3c6
commit b421c83cb8
3 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2017-04-28 Yao Qi <yao.qi@linaro.org>
* regcache.c (regcache_dup): Assert !src->m_readonly_p and
call method save instead of regcache_cpy.
* regcache.h (struct regcache): Make regcache_dup a friend.
2017-04-28 Yao Qi <yao.qi@linaro.org> 2017-04-28 Yao Qi <yao.qi@linaro.org>
* regcache.c (struct regcache): Move to regcache.h * regcache.c (struct regcache): Move to regcache.h

3
gdb/regcache.c
View File

@ -422,8 +422,9 @@ regcache_dup (struct regcache *src)
{ {
struct regcache *newbuf; struct regcache *newbuf;
gdb_assert (!src->m_readonly_p);
newbuf = regcache_xmalloc (src->arch (), get_regcache_aspace (src)); newbuf = regcache_xmalloc (src->arch (), get_regcache_aspace (src));
regcache_cpy (newbuf, src); newbuf->save (do_cooked_read, src);
return newbuf; return newbuf;
} }

3
gdb/regcache.h
View File

@ -373,6 +373,9 @@ private:
friend void friend void
regcache_cpy (struct regcache *dst, struct regcache *src); regcache_cpy (struct regcache *dst, struct regcache *src);
friend struct regcache *
regcache_dup (struct regcache *src);
}; };
/* Copy/duplicate the contents of a register cache. By default, the /* Copy/duplicate the contents of a register cache. By default, the