espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-21 02:24:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix an illegal memory access when copying a PE format file with corrupt debug information.

Browse Source 
PR 23110
	* peXXigen.c (_bfd_XX_bfd_copy_private_bfd_data_common): Check for
	a negative PE_DEBUG_DATA size before iterating over the debug data.
This commit is contained in:
Nick Clifton
2018-04-24 16:31:27 +01:00
parent 0a8ddac418
commit aa4a8c2a2a
3 changed files with 2889 additions and 3211 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
bfd/ChangeLog
View File

@ -1,3 +1,9 @@
2018-04-24 Nick Clifton <nickc@redhat.com>
PR 23110
* peXXigen.c (_bfd_XX_bfd_copy_private_bfd_data_common): Check for
a negative PE_DEBUG_DATA size before iterating over the debug data.
2018-04-23 Alan Modra <amodra@gmail.com> 2018-04-23 Alan Modra <amodra@gmail.com>
* elf-linux-core.h: Revert last change. * elf-linux-core.h: Revert last change.

9
bfd/peXXigen.c
View File

@ -2993,6 +2993,15 @@ _bfd_XX_bfd_copy_private_bfd_data_common (bfd * ibfd, bfd * obfd)
(uint64_t) (section->size - (addr - section->vma))); (uint64_t) (section->size - (addr - section->vma)));
return FALSE; return FALSE;
} }
/* PR 23110. */
else if (ope->pe_opthdr.DataDirectory[PE_DEBUG_DATA].Size < 0)
{
/* xgettext:c-format */
_bfd_error_handler
(_("%pB: Data Directory size (%#lx) is negative"),
obfd, ope->pe_opthdr.DataDirectory[PE_DEBUG_DATA].Size);
return FALSE;
}
for (i = 0; i < ope->pe_opthdr.DataDirectory[PE_DEBUG_DATA].Size for (i = 0; i < ope->pe_opthdr.DataDirectory[PE_DEBUG_DATA].Size
/ sizeof (struct external_IMAGE_DEBUG_DIRECTORY); i++) / sizeof (struct external_IMAGE_DEBUG_DIRECTORY); i++)

6085
bfd/po/bfd.pot
View File

File diff suppressed because it is too large Load Diff