espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-23 11:39:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use std::vector in uploaded_tp

Browse Source 
This patch changes the VEC(char_ptr) fields in uploaded_tp to use
std::vector<char *>.  At first, I wanted to creep in more changes, like
using std::string, but it was making the patch too big and less focused,
so I decided to keep it to just that.

It also looks like the strings in those vectors are never free'd.  If
so, we can fix that in another patch.

gdb/ChangeLog:

	* tracepoint.h (struct uploaded_tp): Initialize fields.
	<actions, step_actions, cmd_strings>: Change type to
	std::vector<char *>.
	* tracepoint.c (get_uploaded_tp): Allocate with new.
	(free_uploaded_tps): Free with delete.
	(parse_tracepoint_definition): Adjust to std::vector change.
	* breakpoint.c (read_uploaded_action): Likewise.
	(create_tracepoint_from_upload): Likewise.
	* ctf.c (ctf_write_uploaded_tp): Likewise.
	(SET_ARRAY_FIELD): Likewise.
	* tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.
This commit is contained in:
Simon Marchi
2018-03-30 17:18:54 -04:00
parent a7961323e2
commit a18ba4e4c9
6 changed files with 55 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
gdb/tracepoint.h
View File

@ -165,38 +165,38 @@ extern const char *stop_reason_names[];
struct uploaded_tp
{
int number;
enum bptype type;
ULONGEST addr;
int enabled;
int step;
int pass;
int orig_size;
int number = 0;
enum bptype type = bp_none;
ULONGEST addr = 0;
int enabled = 0;
int step = 0;
int pass = 0;
int orig_size = 0;
/* String that is the encoded form of the tracepoint's condition. */
char *cond;
char *cond = nullptr;
/* Vectors of strings that are the encoded forms of a tracepoint's
actions. */
VEC(char_ptr) *actions;
VEC(char_ptr) *step_actions;
std::vector<char *> actions;
std::vector<char *> step_actions;
/* The original string defining the location of the tracepoint. */
char *at_string;
char *at_string = nullptr;
/* The original string defining the tracepoint's condition. */
char *cond_string;
char *cond_string = nullptr;
/* List of original strings defining the tracepoint's actions. */
VEC(char_ptr) *cmd_strings;
std::vector<char *> cmd_strings;
/* The tracepoint's current hit count. */
int hit_count;
int hit_count = 0;
/* The tracepoint's current traceframe usage. */
ULONGEST traceframe_usage;
ULONGEST traceframe_usage = 0;
struct uploaded_tp *next;
struct uploaded_tp *next = nullptr;
};
/* Struct recording info about trace state variables on the target. */