espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-28 23:39:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

PowerPC md_end: Don't htab_delete(NULL)

Browse Source 
It might be possible to hit md_end before md_begin is called, don't
segfault if so.  Also, remove a useless check.

	* gas/config/tc-ppc.c (insn_calloc): Remove needless overflow
	check.
	(ppc_md_end): Check ppc_hash before deleting.  Clear ppc_hash.
This commit is contained in:
Alan Modra
2022-07-12 11:17:38 +09:30
parent 35c5dcc666
commit a14413ddff
1 changed files with 8 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
gas/config/tc-ppc.c
View File

@ -1620,14 +1620,8 @@ insn_validate (const struct powerpc_opcode *op)
static void * static void *
insn_calloc (size_t n, size_t size) insn_calloc (size_t n, size_t size)
{ {
size_t amt; size_t amt = n * size;
void *ret; void *ret = obstack_alloc (&insn_obstack, amt);
if (gas_mul_overflow (n, size, &amt))
{
obstack_alloc_failed_handler ();
abort ();
}
ret = obstack_alloc (&insn_obstack, amt);
memset (ret, 0, amt); memset (ret, 0, amt);
return ret; return ret;
} }
@ -1903,8 +1897,12 @@ md_begin (void)
void void
ppc_md_end (void) ppc_md_end (void)
{ {
htab_delete (ppc_hash); if (ppc_hash)
_obstack_free (&insn_obstack, NULL); {
htab_delete (ppc_hash);
_obstack_free (&insn_obstack, NULL);
}
ppc_hash = NULL;
} }
void void