espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-24 20:28:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

[gdb/testsuite] Add missing wait in gdb.base/signals-state-child.exp

Browse Source 
On OBS I ran into:
...
(gdb) shell diff -s outputs/gdb.base/signals-state-child/standalone.txt \
  outputs/gdb.base/signals-state-child/gdb.txt^M
diff: outputs/gdb.base/signals-state-child/standalone.txt: \
  No such file or directory^M
(gdb) FAIL: gdb.base/signals-state-child.exp: signals states are identical
...

I managed to reproduce this by adding "sleep (5)" at the start of main in
signals-state-child.c.

Fix this by waiting on the result of the spawned command.

Tested on x86_64-linux.
This commit is contained in:
Tom de Vries
2021-11-18 15:52:07 +01:00
parent 7a53275579
commit a0cfd0ca0e
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
gdb/testsuite/gdb.base/signals-state-child.exp
View File

@ -69,9 +69,11 @@ set res [remote_spawn target "$binfile-standalone"]
if { $res < 0 || $res == "" } { if { $res < 0 || $res == "" } {
untested "spawning $binfile-standalone failed" untested "spawning $binfile-standalone failed"
return 1 return 1
} else {
pass "collect standalone signals state"
} }
set wait_status [remote_wait target 60]
set have_standalone [expr [lindex $wait_status 0] == 0]
gdb_assert { $have_standalone } "collect standalone signals state"
remote_close target remote_close target
# Now run the program through gdb, and dump its initial signal actions # Now run the program through gdb, and dump its initial signal actions
@ -85,6 +87,12 @@ if { ! [ runto_main ] } then {
gdb_continue_to_end "collect signals state under gdb" gdb_continue_to_end "collect signals state under gdb"
set test "signals states are identical"
if { ! $have_standalone } {
untested $test
return -1
}
if {!$purely_local} { if {!$purely_local} {
# Copy file from target to host through build. # Copy file from target to host through build.
remote_download host [remote_upload target gdb.txt] gdb.txt remote_download host [remote_upload target gdb.txt] gdb.txt
@ -94,4 +102,4 @@ if {!$purely_local} {
# Diff the .txt files. They should be identical. # Diff the .txt files. They should be identical.
gdb_test "shell diff -s $standalone_txt $gdb_txt" \ gdb_test "shell diff -s $standalone_txt $gdb_txt" \
"Files .* are identical.*" \ "Files .* are identical.*" \
"signals states are identical" $test