espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-17 07:53:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

PR gdb/27876 - debuginfod-downloaded source files don't pass proper fullname across mi / (gdb)info source

Browse Source 
Source files downloaded from debuginfod currently use their original DWARF
filename as their "fullname".  This causes a mismatch between the fullname
and the actual location of the source file in the debuginfod client cache.

MI consumers such as VSCode will fail to open debuginfod-downloaded
source files due to this.  Also 'info source' will fail to include the
true paths of these files.

To fix this, use the debuginfod cache path as the fullname for debuginfod-
downloaded source files.
This commit is contained in:
Aaron Merey
2021-11-19 19:41:40 -05:00
parent a9c82bc13c
commit 9ac37a9ce6
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/debuginfod-support.c
View File

@ -202,6 +202,7 @@ debuginfod_source_query (const unsigned char *build_id,
if (c == nullptr) if (c == nullptr)
return scoped_fd (-ENOMEM); return scoped_fd (-ENOMEM);
char *dname = nullptr;
user_data data ("source file", srcpath); user_data data ("source file", srcpath);
debuginfod_set_user_data (c, &data); debuginfod_set_user_data (c, &data);
@ -216,7 +217,7 @@ debuginfod_source_query (const unsigned char *build_id,
build_id, build_id,
build_id_len, build_id_len,
srcpath, srcpath,
nullptr)); &dname));
debuginfod_set_user_data (c, nullptr); debuginfod_set_user_data (c, nullptr);
if (debuginfod_verbose > 0 && fd.get () < 0 && fd.get () != -ENOENT) if (debuginfod_verbose > 0 && fd.get () < 0 && fd.get () != -ENOENT)
@ -225,7 +226,7 @@ debuginfod_source_query (const unsigned char *build_id,
styled_string (file_name_style.style (), srcpath)); styled_string (file_name_style.style (), srcpath));
if (fd.get () >= 0) if (fd.get () >= 0)
*destname = make_unique_xstrdup (srcpath); destname->reset (dname);
return fd; return fd;
} }